From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 036D9C432C3 for ; Thu, 21 Nov 2019 11:32:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CEC4220898 for ; Thu, 21 Nov 2019 11:32:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574335931; bh=ojiuDFiYTw8I726hFOqmkuUZ2H/Y8Yt0mV9sqr8BO0o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=Ol6zAmgjprRhJ0MgmrBeYhBxPRtMFKx/13WTniRvaKBvN2fk1U112CZOlwUDk1TvX zwj56JvOt8AoDy7xhTBZQD0BlQNWBS545KWsx+eAdjTGaLEvWvwgaq4Jr+pXkqt8tW 94gmq+wFtXANmdWCbR/lNsjMjkme2UwzuGTggNFU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726757AbfKULcK (ORCPT ); Thu, 21 Nov 2019 06:32:10 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:36589 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726170AbfKULcK (ORCPT ); Thu, 21 Nov 2019 06:32:10 -0500 Received: by mail-ot1-f68.google.com with SMTP id f10so2620315oto.3; Thu, 21 Nov 2019 03:32:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f3k4Aw80bkAO/6lAcOnkrOVE0ZhJFwvrlGzBabrShVQ=; b=Kv1F6bEUhx6XQilNyRp5ccDX97+jKHY04dGPtgnXkkNmN1nLCsZet1HBp6NxiFTCog LFD0D3/jhQrn3W+nMSAx+K7SiH3b7BUp6boLA4Uils2pfjlE4o3TCsknqqVYMD80hAw7 BgDVuUgWkXW8nOUM/tAavm4mCsW1TeHPJdU2VqLKkwazZ27TFUIrsjssF3fNVThU0pJ5 z1qjBToEZMIIYuTX9F8ubmlrBHK+Bxvn4ujWxg5FuoMCbvgzUJW6nWLHA1u1F2dzaXfj lT85jmnalnuQ5yGCQPiD0paYorzZqOJvKqVsibm9e8jPhpJEuFcMbPpupdgK2n30PZq2 srpQ== X-Gm-Message-State: APjAAAXqIg6oIv7uJUPnZvBy0m/fv6zw9IXiur2wEVxHpIDmdM6TuYmt N3ph8zTqmHJE/KZz1+H9V+mLPUHvkRiGQdB9FTY= X-Google-Smtp-Source: APXvYqyCvKoq/cebzpfoCwlOfAUaYaxdKEecqatFjILqmn5JZJGCEgUqfxdBRzz6K72JW/bHFhwWpS917aNaWsJQbzY= X-Received: by 2002:a9d:4c85:: with SMTP id m5mr5838389otf.118.1574335929309; Thu, 21 Nov 2019 03:32:09 -0800 (PST) MIME-Version: 1.0 References: <20191120120913.GE11621@lahna.fi.intel.com> <20191120151542.GH11621@lahna.fi.intel.com> <20191120155301.GL11621@lahna.fi.intel.com> <20191120162306.GM11621@lahna.fi.intel.com> <20191121101423.GQ11621@lahna.fi.intel.com> <20191121111739.GT11621@lahna.fi.intel.com> In-Reply-To: <20191121111739.GT11621@lahna.fi.intel.com> From: "Rafael J. Wysocki" Date: Thu, 21 Nov 2019 12:31:57 +0100 Message-ID: Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges To: Mika Westerberg Cc: "Rafael J. Wysocki" , Karol Herbst , Bjorn Helgaas , LKML , Lyude Paul , "Rafael J . Wysocki" , Linux PCI , Linux PM , dri-devel , nouveau , Dave Airlie , Mario Limonciello Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 21, 2019 at 12:17 PM Mika Westerberg wrote: > > On Thu, Nov 21, 2019 at 12:03:52PM +0100, Rafael J. Wysocki wrote: > > On Thu, Nov 21, 2019 at 11:14 AM Mika Westerberg > > wrote: > > > > > > On Wed, Nov 20, 2019 at 10:36:31PM +0100, Karol Herbst wrote: > > > > with the branch and patch applied: > > > > https://gist.githubusercontent.com/karolherbst/03c4c8141b0fa292d781badfa186479e/raw/5c62640afbc57d6e69ea924c338bd2836e770d02/gistfile1.txt > > > > > > Thanks for testing. Too bad it did not help :( I suppose there is no > > > change if you increase the delay to say 1s? > > > > Well, look at the original patch in this thread. > > > > What it does is to prevent the device (GPU in this particular case) > > from going into a PCI low-power state before invoking AML to power it > > down (the AML is still invoked after this patch AFAICS), so why would > > that have anything to do with the delays? > > Yes, I know what it does :) I was just thinking that maybe it's still > the link that does not come up when we go back to D0 I guess that's not > the case here. I'm not sure why that would be related to putting the device into, say, PCI D3 before invoking AML to remove power from it. If it is not in PCI D3 at this point, the AML still runs and still removes power from it IIUC, so on the way back the situation is the same regardless: the device has no power which (again) needs to be restored by AML. That (in principle) should not depend on what happened to the device before it lost power. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D7E8C432C0 for ; Thu, 21 Nov 2019 11:32:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D5E920714 for ; Thu, 21 Nov 2019 11:32:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D5E920714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B4E656EDD3; Thu, 21 Nov 2019 11:32:11 +0000 (UTC) Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1360B6E0A6; Thu, 21 Nov 2019 11:32:10 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id f10so2620313oto.3; Thu, 21 Nov 2019 03:32:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f3k4Aw80bkAO/6lAcOnkrOVE0ZhJFwvrlGzBabrShVQ=; b=fBiX7lTsQ1sr50LYDLegjog2fd/+RAO6D7QtnCThfaQLa44PTCDiFPQodfx2fHVQ3n j5l6EjhlTUMT0f9CO1gsnCsLvdyoLwsVFFC4/W3wjcvPWKmIaJWwMaFj3phDxGq/Uik4 J+q7CiSCLMZWGLVyZ2de9tDmY2yCuOrMVYg2xKTWtuiqrlmiZraXEA4ciuADVHh+fmAY +tgOKM/4hE9VNSioOBsPZ6WPmFyNub2D7G/fHXGNQE35dw4VewEV195C50kBmRDqKOKZ xdKFjuBlzDuO3v+0Uwz7SnzI364bgBYJtlWdXFHxMWbp6GIbTZHQo6pCgMxHBvj1uG9M OqWQ== X-Gm-Message-State: APjAAAUlR2l2PSDD0cGToDsAVUGdizeBL5tjmINjcjrOzPp/57Fa95oX 4h2NuEXGW0WOrnAQCgTj3vQKz+9QiWkrhRhK/Uo= X-Google-Smtp-Source: APXvYqyCvKoq/cebzpfoCwlOfAUaYaxdKEecqatFjILqmn5JZJGCEgUqfxdBRzz6K72JW/bHFhwWpS917aNaWsJQbzY= X-Received: by 2002:a9d:4c85:: with SMTP id m5mr5838389otf.118.1574335929309; Thu, 21 Nov 2019 03:32:09 -0800 (PST) MIME-Version: 1.0 References: <20191120120913.GE11621@lahna.fi.intel.com> <20191120151542.GH11621@lahna.fi.intel.com> <20191120155301.GL11621@lahna.fi.intel.com> <20191120162306.GM11621@lahna.fi.intel.com> <20191121101423.GQ11621@lahna.fi.intel.com> <20191121111739.GT11621@lahna.fi.intel.com> In-Reply-To: <20191121111739.GT11621@lahna.fi.intel.com> From: "Rafael J. Wysocki" Date: Thu, 21 Nov 2019 12:31:57 +0100 Message-ID: Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges To: Mika Westerberg X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karol Herbst , "Rafael J. Wysocki" , Linux PCI , Linux PM , "Rafael J . Wysocki" , LKML , dri-devel , Mario Limonciello , Bjorn Helgaas , nouveau Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191121113157.8bk9lbCf2cb_8ElhBvSaME4ldZGYElACnuBlGIalPDU@z> T24gVGh1LCBOb3YgMjEsIDIwMTkgYXQgMTI6MTcgUE0gTWlrYSBXZXN0ZXJiZXJnCjxtaWthLndl c3RlcmJlcmdAaW50ZWwuY29tPiB3cm90ZToKPgo+IE9uIFRodSwgTm92IDIxLCAyMDE5IGF0IDEy OjAzOjUyUE0gKzAxMDAsIFJhZmFlbCBKLiBXeXNvY2tpIHdyb3RlOgo+ID4gT24gVGh1LCBOb3Yg MjEsIDIwMTkgYXQgMTE6MTQgQU0gTWlrYSBXZXN0ZXJiZXJnCj4gPiA8bWlrYS53ZXN0ZXJiZXJn QGludGVsLmNvbT4gd3JvdGU6Cj4gPiA+Cj4gPiA+IE9uIFdlZCwgTm92IDIwLCAyMDE5IGF0IDEw OjM2OjMxUE0gKzAxMDAsIEthcm9sIEhlcmJzdCB3cm90ZToKPiA+ID4gPiB3aXRoIHRoZSBicmFu Y2ggYW5kIHBhdGNoIGFwcGxpZWQ6Cj4gPiA+ID4gaHR0cHM6Ly9naXN0LmdpdGh1YnVzZXJjb250 ZW50LmNvbS9rYXJvbGhlcmJzdC8wM2M0YzgxNDFiMGZhMjkyZDc4MWJhZGZhMTg2NDc5ZS9yYXcv NWM2MjY0MGFmYmM1N2Q2ZTY5ZWE5MjRjMzM4YmQyODM2ZTc3MGQwMi9naXN0ZmlsZTEudHh0Cj4g PiA+Cj4gPiA+IFRoYW5rcyBmb3IgdGVzdGluZy4gVG9vIGJhZCBpdCBkaWQgbm90IGhlbHAgOigg SSBzdXBwb3NlIHRoZXJlIGlzIG5vCj4gPiA+IGNoYW5nZSBpZiB5b3UgaW5jcmVhc2UgdGhlIGRl bGF5IHRvIHNheSAxcz8KPiA+Cj4gPiBXZWxsLCBsb29rIGF0IHRoZSBvcmlnaW5hbCBwYXRjaCBp biB0aGlzIHRocmVhZC4KPiA+Cj4gPiBXaGF0IGl0IGRvZXMgaXMgdG8gcHJldmVudCB0aGUgZGV2 aWNlIChHUFUgaW4gdGhpcyBwYXJ0aWN1bGFyIGNhc2UpCj4gPiBmcm9tIGdvaW5nIGludG8gYSBQ Q0kgbG93LXBvd2VyIHN0YXRlIGJlZm9yZSBpbnZva2luZyBBTUwgdG8gcG93ZXIgaXQKPiA+IGRv d24gKHRoZSBBTUwgaXMgc3RpbGwgaW52b2tlZCBhZnRlciB0aGlzIHBhdGNoIEFGQUlDUyksIHNv IHdoeSB3b3VsZAo+ID4gdGhhdCBoYXZlIGFueXRoaW5nIHRvIGRvIHdpdGggdGhlIGRlbGF5cz8K Pgo+IFllcywgSSBrbm93IHdoYXQgaXQgZG9lcyA6KSBJIHdhcyBqdXN0IHRoaW5raW5nIHRoYXQg bWF5YmUgaXQncyBzdGlsbAo+IHRoZSBsaW5rIHRoYXQgZG9lcyBub3QgY29tZSB1cCB3aGVuIHdl IGdvIGJhY2sgdG8gRDAgSSBndWVzcyB0aGF0J3Mgbm90Cj4gdGhlIGNhc2UgaGVyZS4KCkknbSBu b3Qgc3VyZSB3aHkgdGhhdCB3b3VsZCBiZSByZWxhdGVkIHRvIHB1dHRpbmcgdGhlIGRldmljZSBp bnRvLApzYXksIFBDSSBEMyBiZWZvcmUgaW52b2tpbmcgQU1MIHRvIHJlbW92ZSBwb3dlciBmcm9t IGl0LiAgSWYgaXQgaXMgbm90CmluIFBDSSBEMyBhdCB0aGlzIHBvaW50LCB0aGUgQU1MIHN0aWxs IHJ1bnMgYW5kIHN0aWxsIHJlbW92ZXMgcG93ZXIKZnJvbSBpdCBJSVVDLCBzbyBvbiB0aGUgd2F5 IGJhY2sgdGhlIHNpdHVhdGlvbiBpcyB0aGUgc2FtZSByZWdhcmRsZXNzOgp0aGUgZGV2aWNlIGhh cyBubyBwb3dlciB3aGljaCAoYWdhaW4pIG5lZWRzIHRvIGJlIHJlc3RvcmVkIGJ5IEFNTC4KVGhh dCAoaW4gcHJpbmNpcGxlKSBzaG91bGQgbm90IGRlcGVuZCBvbiB3aGF0IGhhcHBlbmVkIHRvIHRo ZSBkZXZpY2UKYmVmb3JlIGl0IGxvc3QgcG93ZXIuCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbA==