* [PATCH] ACPICA: Use fallthrough pseudo-keyword
@ 2021-05-06 12:49 Wei Ming Chen
2021-05-10 17:06 ` [Devel] " Rafael J. Wysocki
2021-05-11 18:20 ` Kaneda, Erik
0 siblings, 2 replies; 4+ messages in thread
From: Wei Ming Chen @ 2021-05-06 12:49 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-acpi, devel, Wei Ming Chen
Replace /* FALLTHROUGH */ comment with pseudo-keyword macro fallthrough[1]
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Wei Ming Chen <jj251510319013@gmail.com>
---
drivers/acpi/acpica/utprint.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/acpica/utprint.c b/drivers/acpi/acpica/utprint.c
index e37d612e8db5..0b511434b80b 100644
--- a/drivers/acpi/acpica/utprint.c
+++ b/drivers/acpi/acpica/utprint.c
@@ -475,7 +475,7 @@ int vsnprintf(char *string, acpi_size size, const char *format, va_list args)
case 'X':
type |= ACPI_FORMAT_UPPER;
- /* FALLTHROUGH */
+ fallthrough;
case 'x':
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPICA: Use fallthrough pseudo-keyword
@ 2021-05-10 17:06 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2021-05-10 17:06 UTC (permalink / raw)
To: Wei Ming Chen
Cc: Linux Kernel Mailing List, ACPI Devel Maling List,
open list:ACPI COMPONENT ARCHITECTURE (ACPICA),
Erik Kaneda, Robert Moore
On Thu, May 6, 2021 at 2:49 PM Wei Ming Chen <jj251510319013@gmail.com> wrote:
>
> Replace /* FALLTHROUGH */ comment with pseudo-keyword macro fallthrough[1]
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> Signed-off-by: Wei Ming Chen <jj251510319013@gmail.com>
> ---
> drivers/acpi/acpica/utprint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpica/utprint.c b/drivers/acpi/acpica/utprint.c
> index e37d612e8db5..0b511434b80b 100644
> --- a/drivers/acpi/acpica/utprint.c
> +++ b/drivers/acpi/acpica/utprint.c
> @@ -475,7 +475,7 @@ int vsnprintf(char *string, acpi_size size, const char *format, va_list args)
> case 'X':
>
> type |= ACPI_FORMAT_UPPER;
> - /* FALLTHROUGH */
> + fallthrough;
>
> case 'x':
>
> --
This is ACPICA material, so I'm leaving it to Erik and Bob.
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Devel] Re: [PATCH] ACPICA: Use fallthrough pseudo-keyword
@ 2021-05-10 17:06 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2021-05-10 17:06 UTC (permalink / raw)
To: devel
[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]
On Thu, May 6, 2021 at 2:49 PM Wei Ming Chen <jj251510319013(a)gmail.com> wrote:
>
> Replace /* FALLTHROUGH */ comment with pseudo-keyword macro fallthrough[1]
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> Signed-off-by: Wei Ming Chen <jj251510319013(a)gmail.com>
> ---
> drivers/acpi/acpica/utprint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpica/utprint.c b/drivers/acpi/acpica/utprint.c
> index e37d612e8db5..0b511434b80b 100644
> --- a/drivers/acpi/acpica/utprint.c
> +++ b/drivers/acpi/acpica/utprint.c
> @@ -475,7 +475,7 @@ int vsnprintf(char *string, acpi_size size, const char *format, va_list args)
> case 'X':
>
> type |= ACPI_FORMAT_UPPER;
> - /* FALLTHROUGH */
> + fallthrough;
>
> case 'x':
>
> --
This is ACPICA material, so I'm leaving it to Erik and Bob.
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] ACPICA: Use fallthrough pseudo-keyword
2021-05-06 12:49 [PATCH] ACPICA: Use fallthrough pseudo-keyword Wei Ming Chen
2021-05-10 17:06 ` [Devel] " Rafael J. Wysocki
@ 2021-05-11 18:20 ` Kaneda, Erik
1 sibling, 0 replies; 4+ messages in thread
From: Kaneda, Erik @ 2021-05-11 18:20 UTC (permalink / raw)
To: Wei Ming Chen, linux-kernel; +Cc: linux-acpi, devel, Rafael J. Wysocki
> -----Original Message-----
> From: Wei Ming Chen <jj251510319013@gmail.com>
> Sent: Thursday, May 6, 2021 5:49 AM
> To: linux-kernel@vger.kernel.org
> Cc: linux-acpi@vger.kernel.org; devel@acpica.org; Wei Ming Chen
> <jj251510319013@gmail.com>
> Subject: [PATCH] ACPICA: Use fallthrough pseudo-keyword
>
> Replace /* FALLTHROUGH */ comment with pseudo-keyword macro
> fallthrough[1]
>
> [1]
> https://www.kernel.org/doc/html/latest/process/deprecated.html?highligh
> t=fallthrough#implicit-switch-case-fall-through
>
> Signed-off-by: Wei Ming Chen <jj251510319013@gmail.com>
> ---
> drivers/acpi/acpica/utprint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpica/utprint.c b/drivers/acpi/acpica/utprint.c
> index e37d612e8db5..0b511434b80b 100644
> --- a/drivers/acpi/acpica/utprint.c
> +++ b/drivers/acpi/acpica/utprint.c
> @@ -475,7 +475,7 @@ int vsnprintf(char *string, acpi_size size, const char
> *format, va_list args)
> case 'X':
>
Hi,
> type |= ACPI_FORMAT_UPPER;
> - /* FALLTHROUGH */
> + fallthrough;
Since fallthrough is specific to gcc, we use the macro ACPI_FALLTHROUGH for code in drivers/acpi/acpica. Please resubmit using this keyword and I can take the commit for upstream ACPICA.
Thanks,
Erik
>
> case 'x':
>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-11 18:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-06 12:49 [PATCH] ACPICA: Use fallthrough pseudo-keyword Wei Ming Chen
2021-05-10 17:06 ` Rafael J. Wysocki
2021-05-10 17:06 ` [Devel] " Rafael J. Wysocki
2021-05-11 18:20 ` Kaneda, Erik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.