From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2BA2C433EF for ; Mon, 14 Feb 2022 21:27:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231203AbiBNV1z (ORCPT ); Mon, 14 Feb 2022 16:27:55 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:39536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230370AbiBNV1z (ORCPT ); Mon, 14 Feb 2022 16:27:55 -0500 Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A793D205CC; Mon, 14 Feb 2022 13:27:43 -0800 (PST) Received: by mail-ua1-f52.google.com with SMTP id v5so8833640uam.3; Mon, 14 Feb 2022 13:27:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kI/su3rLIeICfLlNKWmUFjgPBcsY2C15d0MI7GuavKc=; b=wCG6p/+P3vdcrqHorWmabfT4JogzaP2GngcXL6Rxslb9pFcQ3qhxmXb4vIwbzI+D9x QE6A6BnOGaCW2ByXnXT+9bo8CUpRDavYWaNQyU5w7fw1/aH7//yyy5tE6dTwFca6ildI eWcA4h2F2Es8No5XO25NjGEod83i0wh050SkVgIX32EoyNqEJjnw4uaLAU1gVruG+AI0 HvUXLFPhcyClkkzAoKwE1ook66cfajOied7mYCEzClRYoYu3nufRvMYOkrN67iMlJRet tGh6ojISA+4lTGp1SE9fygp5ToV03w8D89bQfP49oACIfF/HTsugq7I1u5H0VOSMFHbh ldAA== X-Gm-Message-State: AOAM531I1BEuY5+JcROkHhgPhMkhwU/5T3l36VuBURdqL5vVUluJjbjp vYof5q4Dr7+ruzp1aRcpuDinLJNBLq/rf03+U6DoPDcj X-Google-Smtp-Source: ABdhPJxGZGt2fPgzAqcgORvIh0/Y5CWB2tlTZbwqTAX/KQ7CW6L1r5+mAHGuDyElx2Pd5u2NGjMMyir7212xQ8cyY/A= X-Received: by 2002:a25:7e81:: with SMTP id z123mr550858ybc.466.1644866318513; Mon, 14 Feb 2022 11:18:38 -0800 (PST) MIME-Version: 1.0 References: <20220210224933.379149-1-yury.norov@gmail.com> <20220210224933.379149-46-yury.norov@gmail.com> In-Reply-To: <20220210224933.379149-46-yury.norov@gmail.com> From: "Rafael J. Wysocki" Date: Mon, 14 Feb 2022 20:18:27 +0100 Message-ID: Subject: Re: [PATCH 45/49] ACPI: replace nodes__weight with nodes_weight_ge for numa To: Yury Norov Cc: Andy Shevchenko , Rasmus Villemoes , Andrew Morton , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Greg Kroah-Hartman , Peter Zijlstra , David Laight , Joe Perches , Dennis Zhou , Emil Renner Berthing , Nicholas Piggin , Matti Vaittinen , Alexey Klimov , Linux Kernel Mailing List , "Rafael J. Wysocki" , Len Brown , Dan Williams , Huacai Chen , Vitaly Kuznetsov , Alison Schofield , ACPI Devel Maling List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Feb 11, 2022 at 1:31 AM Yury Norov wrote: > > acpi_map_pxm_to_node() calls nodes_weight() to compare the weight > of nodemask with a given number. We can do it more efficiently with > nodes_weight_eq() because conditional nodes_weight may stop > traversing the nodemask earlier, as soon as condition is (or is not) > met. > > Signed-off-by: Yury Norov > --- > drivers/acpi/numa/srat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > index 3b818ab186be..fe7a7996f553 100644 > --- a/drivers/acpi/numa/srat.c > +++ b/drivers/acpi/numa/srat.c > @@ -67,7 +67,7 @@ int acpi_map_pxm_to_node(int pxm) > node = pxm_to_node_map[pxm]; > > if (node == NUMA_NO_NODE) { > - if (nodes_weight(nodes_found_map) >= MAX_NUMNODES) > + if (nodes_weight_ge(nodes_found_map, MAX_NUMNODES)) > return NUMA_NO_NODE; > node = first_unset_node(nodes_found_map); > __acpi_map_pxm_to_node(pxm, node); > -- Applied as 5.18 material, thanks!