From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C62C5C433FE for ; Tue, 17 May 2022 18:28:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352197AbiEQS2z convert rfc822-to-8bit (ORCPT ); Tue, 17 May 2022 14:28:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352248AbiEQS2p (ORCPT ); Tue, 17 May 2022 14:28:45 -0400 Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1549449F19; Tue, 17 May 2022 11:28:42 -0700 (PDT) Received: by mail-yb1-f172.google.com with SMTP id a3so14824099ybg.5; Tue, 17 May 2022 11:28:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=yLKFTvllEnb3n3nFUIfBrKxcB6r2mY4TZ0eJaZi1jOo=; b=iyC1p4vbdozsAmKTgsiO69uGEugKzSk9HnSGJqxPzPE6xl78cQ0jUS6AfICx2pR1kP X7T/zIH0T4NNTnlqxLTPorh9VMqESfhzZ/E5MvC1yi8QDlGIPt4cGVHiAt7AmbQB7YTf 8MBnVXaFUn0JFTyctt0EStxCzUhcdCfV/9feKwHtmR5xm0K0OGERk1ygHU2Rz6/OKv1q myBbxQfx4Amqg9vioTunmAHydDxUyrwtk4GufaKLwg9a5fAvowJlFkerEInIKxZf0zVW mlIwbpfFha6hWhusxMOxG/RTSBbQ7k/JoopAgmM+pFRLmvpVjuNn6GCG/QYd9xeN2DmV u73w== X-Gm-Message-State: AOAM530c/IJ0iymz8jIG3i3jqya3/qFAfGdzK2cARgARdtjDCbCjc7bZ a5XbEBWJQ4lTUmosV4fccuoMPu2ZKDR6UVdUC/f++vfF X-Google-Smtp-Source: ABdhPJygZZcshgEgipo6qKLVDSNEV4d442F2Y1m4FFHpoe9ENg6PLcKPOa83NuL3VpOGX/liUe0jzjwEBdFcig8Z7pE= X-Received: by 2002:a25:1145:0:b0:64d:d6be:c741 with SMTP id 66-20020a251145000000b0064dd6bec741mr8749396ybr.137.1652812121705; Tue, 17 May 2022 11:28:41 -0700 (PDT) MIME-Version: 1.0 References: <28686e8d994c297a78fb816805cd3652a8f8c90a.camel@mniewoehner.de> In-Reply-To: <28686e8d994c297a78fb816805cd3652a8f8c90a.camel@mniewoehner.de> From: "Rafael J. Wysocki" Date: Tue, 17 May 2022 20:28:30 +0200 Message-ID: Subject: Re: [PATCH] ACPI: utils: include UUID in _DSM evaluation warning To: =?UTF-8?Q?Michael_Niew=C3=B6hner?= Cc: "Rafael J. Wysocki" , Len Brown , "open list:ACPI" , open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, May 17, 2022 at 8:26 PM Michael Niewöhner wrote: > > On Tue, 2022-05-17 at 16:49 +0200, Rafael J. Wysocki wrote: > > On Mon, May 16, 2022 at 7:25 PM Michael Niewöhner > > wrote: > > > > > > The _DSM evaluation warning in its current form is not very helpful, as > > > it lacks any specific information: > > > ACPI: \: failed to evaluate _DSM (0x1001) > > > > > > Thus, include the UUID of the missing _DSM: > > > ACPI: \: failed to evaluate _DSM bf0212f2-... (0x1001) > > > > > > Signed-off-by: Michael Niewöhner > > > --- > > > drivers/acpi/utils.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c > > > index d5cedffeeff9..7da993f5b6c3 100644 > > > --- a/drivers/acpi/utils.c > > > +++ b/drivers/acpi/utils.c > > > @@ -681,7 +681,8 @@ acpi_evaluate_dsm(acpi_handle handle, const guid_t > > > *guid, > > > u64 rev, u64 func, > > > > > > if (ret != AE_NOT_FOUND) > > > acpi_handle_warn(handle, > > > - "failed to evaluate _DSM (0x%x)\n", ret); > > > + "failed to evaluate _DSM %pUb (0x%x)\n", > > > + ret, guid); > > > > Shouldn't this be "guid, ret" ? > > Ouch, yes ofc. > > > Also, don't you want to print the > > value of the GUID rather than the address of its location? > > Not sure what you mean tbh. Documentation/core-api/printk-formats.rst states > %pUb being the right format. lib/test_printf.c implements it that way, too. I missed that, sorry.