From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDF15C00454 for ; Mon, 9 Dec 2019 11:39:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B39C02080D for ; Mon, 9 Dec 2019 11:39:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575891547; bh=SVfy5JgsypTwmpiZU+DLENcZr2fgweQuNe+ZcwawK0I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=A0SQNXHPTo0QC6zIynKaxI/ipfC8/NoWBqe/RYF4xw9wYrxUF+UbwmUVvqVlupRP4 UPZs2LiIzJUa7dSpSDP5NM92lmwv5pXrA0f31WAJVr683LZf3LdkV3byXncqECUMEu FU0uXQeB0J8w7S4qtz/zQGhTkbVgb4HEmHuSaLmc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727504AbfLILjG (ORCPT ); Mon, 9 Dec 2019 06:39:06 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:42249 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727326AbfLILjG (ORCPT ); Mon, 9 Dec 2019 06:39:06 -0500 Received: by mail-oi1-f196.google.com with SMTP id j22so5985784oij.9; Mon, 09 Dec 2019 03:39:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mPM/hwSdd2dpR68KRDIRUCSfL+ZarPQKfGdIq8K3ckk=; b=Y4eQkSZOSr43h0aL45DzLMphxNKlD0BI/If9WdLqXzn7K7BUcBBmdQWzg2OVXb4AIS mcG+v3YF8MHn/CtlnPnh6i8gu7pWhSqNHchoBv9CEKFlM98Il5ciD86gFSuKGEGV4cCP wcx+BgXMzuryB89HBwFi5TMa2rH81MdNnFEcw7Q/ojylaNIVC1rju+Gh3ZzhlvVJ0Ac4 D8DZCLeCps3Seh2zVQ1KcZ6Q6nV0v+OpPOetnwCpzNwkWdT3a6Bthk518s+WT+6ucx9W PXhCbUcQJPDOtYYXdsjjtb7RCLRT8M8ZfC1IIbxJLgqoESCMqiV10DGT6/ZtVXmY504T 6glQ== X-Gm-Message-State: APjAAAV9rYFSjXtWoAJrRMPjyMBuYCZwwg9K0JT3mvDHdXvgP1eV2t/e oNgLHHrmDria8Wd6GqVGVv81zn0bhsnhrNfZlLk= X-Google-Smtp-Source: APXvYqzG8vwOM20aU3KzuzbhZ5+B1Tkp8z1UETWtoGf+LzRaBUX4n5P3Sb4ZJ2d9h2hcY0SF6eTRe0bkPN0OirKV+LE= X-Received: by 2002:a05:6808:1c5:: with SMTP id x5mr17465882oic.57.1575891545016; Mon, 09 Dec 2019 03:39:05 -0800 (PST) MIME-Version: 1.0 References: <20191121112821.GU11621@lahna.fi.intel.com> <20191121114610.GW11621@lahna.fi.intel.com> <20191127114856.GZ11621@lahna.fi.intel.com> In-Reply-To: From: "Rafael J. Wysocki" Date: Mon, 9 Dec 2019 12:38:53 +0100 Message-ID: Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges To: Karol Herbst Cc: Lyude Paul , Mika Westerberg , "Rafael J. Wysocki" , Bjorn Helgaas , LKML , "Rafael J . Wysocki" , Linux PCI , Linux PM , dri-devel , nouveau , Dave Airlie , Mario Limonciello Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 9, 2019 at 12:17 PM Karol Herbst wrote: > > anybody any other ideas? Not yet, but I'm trying to collect some more information. > It seems that both patches don't really fix > the issue and I have no idea left on my side to try out. The only > thing left I could do to further investigate would be to reverse > engineer the Nvidia driver as they support runpm on Turing+ GPUs now, > but I've heard users having similar issues to the one Lyude told us > about... and I couldn't verify that the patches help there either in a > reliable way. It looks like the newer (8+) versions of Windows expect the GPU driver to prepare the GPU for power removal in some specific way and the latter fails if the GPU has not been prepared as expected. Because testing indicates that the Windows 7 path in the platform firmware works, it may be worth trying to do what it does to the PCIe link before invoking the _OFF method for the power resource controlling the GPU power. If the Mika's theory that the Win7 path simply turns the PCIe link off is correct, then whatever the _OFF method tries to do to the link after that should not matter. > On Wed, Nov 27, 2019 at 8:55 PM Lyude Paul wrote: > > > > On Wed, 2019-11-27 at 12:51 +0100, Karol Herbst wrote: > > > On Wed, Nov 27, 2019 at 12:49 PM Mika Westerberg > > > wrote: > > > > On Tue, Nov 26, 2019 at 06:10:36PM -0500, Lyude Paul wrote: > > > > > Hey-this is almost certainly not the right place in this thread to > > > > > respond, > > > > > but this thread has gotten so deep evolution can't push the subject > > > > > further to > > > > > the right, heh. So I'll just respond here. > > > > > > > > :) > > > > > > > > > I've been following this and helping out Karol with testing here and > > > > > there. > > > > > They had me test Bjorn's PCI branch on the X1 Extreme 2nd generation, > > > > > which > > > > > has a turing GPU and 8086:1901 PCI bridge. > > > > > > > > > > I was about to say "the patch fixed things, hooray!" but it seems that > > > > > after > > > > > trying runtime suspend/resume a couple times things fall apart again: > > > > > > > > You mean $subject patch, no? > > > > > > > > > > no, I told Lyude to test the pci/pm branch as the runpm errors we saw > > > on that machine looked different. Some BAR error the GPU reported > > > after it got resumed, so I was wondering if the delays were helping > > > with that. But after some cycles it still caused the same issue, that > > > the GPU disappeared. Later testing also showed that my patch also > > > didn't seem to help with this error sadly :/ > > > > > > > > [ 686.883247] nouveau 0000:01:00.0: DRM: suspending object tree... > > > > > [ 752.866484] ACPI Error: Aborting method \_SB.PCI0.PEG0.PEGP.NVPO due > > > > > to previous error (AE_AML_LOOP_TIMEOUT) (20190816/psparse-529) > > > > > [ 752.866508] ACPI Error: Aborting method \_SB.PCI0.PGON due to > > > > > previous error (AE_AML_LOOP_TIMEOUT) (20190816/psparse-529) > > > > > [ 752.866521] ACPI Error: Aborting method \_SB.PCI0.PEG0.PG00._ON due > > > > > to previous error (AE_AML_LOOP_TIMEOUT) (20190816/psparse-529) > > > > > > > > This is probably the culprit. The same AML code fails to properly turn > > > > on the device. > > > > > > > > Is acpidump from this system available somewhere? > > > > Attached it to this email > > > > > > > > -- > > Cheers, > > Lyude Paul > From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges Date: Mon, 9 Dec 2019 12:38:53 +0100 Message-ID: References: <20191121112821.GU11621@lahna.fi.intel.com> <20191121114610.GW11621@lahna.fi.intel.com> <20191127114856.GZ11621@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Karol Herbst Cc: "Rafael J. Wysocki" , Linux PCI , Mika Westerberg , Linux PM , "Rafael J . Wysocki" , LKML , dri-devel , Mario Limonciello , Bjorn Helgaas , nouveau List-Id: nouveau.vger.kernel.org T24gTW9uLCBEZWMgOSwgMjAxOSBhdCAxMjoxNyBQTSBLYXJvbCBIZXJic3QgPGtoZXJic3RAcmVk aGF0LmNvbT4gd3JvdGU6Cj4KPiBhbnlib2R5IGFueSBvdGhlciBpZGVhcz8KCk5vdCB5ZXQsIGJ1 dCBJJ20gdHJ5aW5nIHRvIGNvbGxlY3Qgc29tZSBtb3JlIGluZm9ybWF0aW9uLgoKPiBJdCBzZWVt cyB0aGF0IGJvdGggcGF0Y2hlcyBkb24ndCByZWFsbHkgZml4Cj4gdGhlIGlzc3VlIGFuZCBJIGhh dmUgbm8gaWRlYSBsZWZ0IG9uIG15IHNpZGUgdG8gdHJ5IG91dC4gVGhlIG9ubHkKPiB0aGluZyBs ZWZ0IEkgY291bGQgZG8gdG8gZnVydGhlciBpbnZlc3RpZ2F0ZSB3b3VsZCBiZSB0byByZXZlcnNl Cj4gZW5naW5lZXIgdGhlIE52aWRpYSBkcml2ZXIgYXMgdGhleSBzdXBwb3J0IHJ1bnBtIG9uIFR1 cmluZysgR1BVcyBub3csCj4gYnV0IEkndmUgaGVhcmQgdXNlcnMgaGF2aW5nIHNpbWlsYXIgaXNz dWVzIHRvIHRoZSBvbmUgTHl1ZGUgdG9sZCB1cwo+IGFib3V0Li4uIGFuZCBJIGNvdWxkbid0IHZl cmlmeSB0aGF0IHRoZSBwYXRjaGVzIGhlbHAgdGhlcmUgZWl0aGVyIGluIGEKPiByZWxpYWJsZSB3 YXkuCgpJdCBsb29rcyBsaWtlIHRoZSBuZXdlciAoOCspIHZlcnNpb25zIG9mIFdpbmRvd3MgZXhw ZWN0IHRoZSBHUFUgZHJpdmVyCnRvIHByZXBhcmUgdGhlIEdQVSBmb3IgcG93ZXIgcmVtb3ZhbCBp biBzb21lIHNwZWNpZmljIHdheSBhbmQgdGhlCmxhdHRlciBmYWlscyBpZiB0aGUgR1BVIGhhcyBu b3QgYmVlbiBwcmVwYXJlZCBhcyBleHBlY3RlZC4KCkJlY2F1c2UgdGVzdGluZyBpbmRpY2F0ZXMg dGhhdCB0aGUgV2luZG93cyA3IHBhdGggaW4gdGhlIHBsYXRmb3JtCmZpcm13YXJlIHdvcmtzLCBp dCBtYXkgYmUgd29ydGggdHJ5aW5nIHRvIGRvIHdoYXQgaXQgZG9lcyB0byB0aGUgUENJZQpsaW5r IGJlZm9yZSBpbnZva2luZyB0aGUgX09GRiBtZXRob2QgZm9yIHRoZSBwb3dlciByZXNvdXJjZQpj b250cm9sbGluZyB0aGUgR1BVIHBvd2VyLgoKSWYgdGhlIE1pa2EncyB0aGVvcnkgdGhhdCB0aGUg V2luNyBwYXRoIHNpbXBseSB0dXJucyB0aGUgUENJZSBsaW5rIG9mZgppcyBjb3JyZWN0LCB0aGVu IHdoYXRldmVyIHRoZSBfT0ZGIG1ldGhvZCB0cmllcyB0byBkbyB0byB0aGUgbGluawphZnRlciB0 aGF0IHNob3VsZCBub3QgbWF0dGVyLgoKPiBPbiBXZWQsIE5vdiAyNywgMjAxOSBhdCA4OjU1IFBN IEx5dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5jb20+IHdyb3RlOgo+ID4KPiA+IE9uIFdlZCwgMjAx OS0xMS0yNyBhdCAxMjo1MSArMDEwMCwgS2Fyb2wgSGVyYnN0IHdyb3RlOgo+ID4gPiBPbiBXZWQs IE5vdiAyNywgMjAxOSBhdCAxMjo0OSBQTSBNaWthIFdlc3RlcmJlcmcKPiA+ID4gPG1pa2Eud2Vz dGVyYmVyZ0BpbnRlbC5jb20+IHdyb3RlOgo+ID4gPiA+IE9uIFR1ZSwgTm92IDI2LCAyMDE5IGF0 IDA2OjEwOjM2UE0gLTA1MDAsIEx5dWRlIFBhdWwgd3JvdGU6Cj4gPiA+ID4gPiBIZXktdGhpcyBp cyBhbG1vc3QgY2VydGFpbmx5IG5vdCB0aGUgcmlnaHQgcGxhY2UgaW4gdGhpcyB0aHJlYWQgdG8K PiA+ID4gPiA+IHJlc3BvbmQsCj4gPiA+ID4gPiBidXQgdGhpcyB0aHJlYWQgaGFzIGdvdHRlbiBz byBkZWVwIGV2b2x1dGlvbiBjYW4ndCBwdXNoIHRoZSBzdWJqZWN0Cj4gPiA+ID4gPiBmdXJ0aGVy IHRvCj4gPiA+ID4gPiB0aGUgcmlnaHQsIGhlaC4gU28gSSdsbCBqdXN0IHJlc3BvbmQgaGVyZS4K PiA+ID4gPgo+ID4gPiA+IDopCj4gPiA+ID4KPiA+ID4gPiA+IEkndmUgYmVlbiBmb2xsb3dpbmcg dGhpcyBhbmQgaGVscGluZyBvdXQgS2Fyb2wgd2l0aCB0ZXN0aW5nIGhlcmUgYW5kCj4gPiA+ID4g PiB0aGVyZS4KPiA+ID4gPiA+IFRoZXkgaGFkIG1lIHRlc3QgQmpvcm4ncyBQQ0kgYnJhbmNoIG9u IHRoZSBYMSBFeHRyZW1lIDJuZCBnZW5lcmF0aW9uLAo+ID4gPiA+ID4gd2hpY2gKPiA+ID4gPiA+ IGhhcyBhIHR1cmluZyBHUFUgYW5kIDgwODY6MTkwMSBQQ0kgYnJpZGdlLgo+ID4gPiA+ID4KPiA+ ID4gPiA+IEkgd2FzIGFib3V0IHRvIHNheSAidGhlIHBhdGNoIGZpeGVkIHRoaW5ncywgaG9vcmF5 ISIgYnV0IGl0IHNlZW1zIHRoYXQKPiA+ID4gPiA+IGFmdGVyCj4gPiA+ID4gPiB0cnlpbmcgcnVu dGltZSBzdXNwZW5kL3Jlc3VtZSBhIGNvdXBsZSB0aW1lcyB0aGluZ3MgZmFsbCBhcGFydCBhZ2Fp bjoKPiA+ID4gPgo+ID4gPiA+IFlvdSBtZWFuICRzdWJqZWN0IHBhdGNoLCBubz8KPiA+ID4gPgo+ ID4gPgo+ID4gPiBubywgSSB0b2xkIEx5dWRlIHRvIHRlc3QgdGhlIHBjaS9wbSBicmFuY2ggYXMg dGhlIHJ1bnBtIGVycm9ycyB3ZSBzYXcKPiA+ID4gb24gdGhhdCBtYWNoaW5lIGxvb2tlZCBkaWZm ZXJlbnQuIFNvbWUgQkFSIGVycm9yIHRoZSBHUFUgcmVwb3J0ZWQKPiA+ID4gYWZ0ZXIgaXQgZ290 IHJlc3VtZWQsIHNvIEkgd2FzIHdvbmRlcmluZyBpZiB0aGUgZGVsYXlzIHdlcmUgaGVscGluZwo+ ID4gPiB3aXRoIHRoYXQuIEJ1dCBhZnRlciBzb21lIGN5Y2xlcyBpdCBzdGlsbCBjYXVzZWQgdGhl IHNhbWUgaXNzdWUsIHRoYXQKPiA+ID4gdGhlIEdQVSBkaXNhcHBlYXJlZC4gTGF0ZXIgdGVzdGlu ZyBhbHNvIHNob3dlZCB0aGF0IG15IHBhdGNoIGFsc28KPiA+ID4gZGlkbid0IHNlZW0gdG8gaGVs cCB3aXRoIHRoaXMgZXJyb3Igc2FkbHkgOi8KPiA+ID4KPiA+ID4gPiA+IFsgIDY4Ni44ODMyNDdd IG5vdXZlYXUgMDAwMDowMTowMC4wOiBEUk06IHN1c3BlbmRpbmcgb2JqZWN0IHRyZWUuLi4KPiA+ ID4gPiA+IFsgIDc1Mi44NjY0ODRdIEFDUEkgRXJyb3I6IEFib3J0aW5nIG1ldGhvZCBcX1NCLlBD STAuUEVHMC5QRUdQLk5WUE8gZHVlCj4gPiA+ID4gPiB0byBwcmV2aW91cyBlcnJvciAoQUVfQU1M X0xPT1BfVElNRU9VVCkgKDIwMTkwODE2L3BzcGFyc2UtNTI5KQo+ID4gPiA+ID4gWyAgNzUyLjg2 NjUwOF0gQUNQSSBFcnJvcjogQWJvcnRpbmcgbWV0aG9kIFxfU0IuUENJMC5QR09OIGR1ZSB0bwo+ ID4gPiA+ID4gcHJldmlvdXMgZXJyb3IgKEFFX0FNTF9MT09QX1RJTUVPVVQpICgyMDE5MDgxNi9w c3BhcnNlLTUyOSkKPiA+ID4gPiA+IFsgIDc1Mi44NjY1MjFdIEFDUEkgRXJyb3I6IEFib3J0aW5n IG1ldGhvZCBcX1NCLlBDSTAuUEVHMC5QRzAwLl9PTiBkdWUKPiA+ID4gPiA+IHRvIHByZXZpb3Vz IGVycm9yIChBRV9BTUxfTE9PUF9USU1FT1VUKSAoMjAxOTA4MTYvcHNwYXJzZS01MjkpCj4gPiA+ ID4KPiA+ID4gPiBUaGlzIGlzIHByb2JhYmx5IHRoZSBjdWxwcml0LiBUaGUgc2FtZSBBTUwgY29k ZSBmYWlscyB0byBwcm9wZXJseSB0dXJuCj4gPiA+ID4gb24gdGhlIGRldmljZS4KPiA+ID4gPgo+ ID4gPiA+IElzIGFjcGlkdW1wIGZyb20gdGhpcyBzeXN0ZW0gYXZhaWxhYmxlIHNvbWV3aGVyZT8K PiA+Cj4gPiBBdHRhY2hlZCBpdCB0byB0aGlzIGVtYWlsCj4gPgo+ID4gPiA+Cj4gPiAtLQo+ID4g Q2hlZXJzLAo+ID4gICAgICAgICBMeXVkZSBQYXVsCj4KX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KTm91dmVhdSBtYWlsaW5nIGxpc3QKTm91dmVhdUBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9ub3V2ZWF1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B17AC2BD09 for ; Mon, 9 Dec 2019 11:39:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B58F20726 for ; Mon, 9 Dec 2019 11:39:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B58F20726 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B2DC66E40B; Mon, 9 Dec 2019 11:39:07 +0000 (UTC) Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by gabe.freedesktop.org (Postfix) with ESMTPS id D720F6E408; Mon, 9 Dec 2019 11:39:05 +0000 (UTC) Received: by mail-oi1-f196.google.com with SMTP id x195so6024191oix.4; Mon, 09 Dec 2019 03:39:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mPM/hwSdd2dpR68KRDIRUCSfL+ZarPQKfGdIq8K3ckk=; b=W2DrXuMs1Wja/NsetbjmOTd96jyQgNXUoPlm9LvSjCuFTllYQJFVz+nYGKchiEmYZ1 GgCgDGtmZnJXRxtWVaqgkLngC8YGqGIOzS9CBJSXLQQyXyJP6nUrMnJ5++TllItDaEsv BocnHiEwWrI3TO7LQTuJ8D+bCAZqmywz7U1kF1R4ASyEB12hFNwjjJUi70ybnEDUNzui IYINyEkRO2bd8s++wxBaXXb/Dho5m614raWyygM0i815q8/G9jtqm77OZGFvKRfSfb4O VGT2En+Rfstd+JTFjYJVSQ9FplLUDYX2O2yMflVRwYQokUP2BJqCcgG91FKQdD3+YCkT j7sw== X-Gm-Message-State: APjAAAV89HU6yOHHWz98G3sUtjbiXWW3EiPX50Dgp0QvyGHkRaIghtpA Mqg3agKwS2Ka1z9FBD40niibCfjSpf3Q4g+D2pw= X-Google-Smtp-Source: APXvYqzG8vwOM20aU3KzuzbhZ5+B1Tkp8z1UETWtoGf+LzRaBUX4n5P3Sb4ZJ2d9h2hcY0SF6eTRe0bkPN0OirKV+LE= X-Received: by 2002:a05:6808:1c5:: with SMTP id x5mr17465882oic.57.1575891545016; Mon, 09 Dec 2019 03:39:05 -0800 (PST) MIME-Version: 1.0 References: <20191121112821.GU11621@lahna.fi.intel.com> <20191121114610.GW11621@lahna.fi.intel.com> <20191127114856.GZ11621@lahna.fi.intel.com> In-Reply-To: From: "Rafael J. Wysocki" Date: Mon, 9 Dec 2019 12:38:53 +0100 Message-ID: Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges To: Karol Herbst X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Rafael J. Wysocki" , Linux PCI , Mika Westerberg , Linux PM , "Rafael J . Wysocki" , LKML , dri-devel , Mario Limonciello , Bjorn Helgaas , nouveau Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCBEZWMgOSwgMjAxOSBhdCAxMjoxNyBQTSBLYXJvbCBIZXJic3QgPGtoZXJic3RAcmVk aGF0LmNvbT4gd3JvdGU6Cj4KPiBhbnlib2R5IGFueSBvdGhlciBpZGVhcz8KCk5vdCB5ZXQsIGJ1 dCBJJ20gdHJ5aW5nIHRvIGNvbGxlY3Qgc29tZSBtb3JlIGluZm9ybWF0aW9uLgoKPiBJdCBzZWVt cyB0aGF0IGJvdGggcGF0Y2hlcyBkb24ndCByZWFsbHkgZml4Cj4gdGhlIGlzc3VlIGFuZCBJIGhh dmUgbm8gaWRlYSBsZWZ0IG9uIG15IHNpZGUgdG8gdHJ5IG91dC4gVGhlIG9ubHkKPiB0aGluZyBs ZWZ0IEkgY291bGQgZG8gdG8gZnVydGhlciBpbnZlc3RpZ2F0ZSB3b3VsZCBiZSB0byByZXZlcnNl Cj4gZW5naW5lZXIgdGhlIE52aWRpYSBkcml2ZXIgYXMgdGhleSBzdXBwb3J0IHJ1bnBtIG9uIFR1 cmluZysgR1BVcyBub3csCj4gYnV0IEkndmUgaGVhcmQgdXNlcnMgaGF2aW5nIHNpbWlsYXIgaXNz dWVzIHRvIHRoZSBvbmUgTHl1ZGUgdG9sZCB1cwo+IGFib3V0Li4uIGFuZCBJIGNvdWxkbid0IHZl cmlmeSB0aGF0IHRoZSBwYXRjaGVzIGhlbHAgdGhlcmUgZWl0aGVyIGluIGEKPiByZWxpYWJsZSB3 YXkuCgpJdCBsb29rcyBsaWtlIHRoZSBuZXdlciAoOCspIHZlcnNpb25zIG9mIFdpbmRvd3MgZXhw ZWN0IHRoZSBHUFUgZHJpdmVyCnRvIHByZXBhcmUgdGhlIEdQVSBmb3IgcG93ZXIgcmVtb3ZhbCBp biBzb21lIHNwZWNpZmljIHdheSBhbmQgdGhlCmxhdHRlciBmYWlscyBpZiB0aGUgR1BVIGhhcyBu b3QgYmVlbiBwcmVwYXJlZCBhcyBleHBlY3RlZC4KCkJlY2F1c2UgdGVzdGluZyBpbmRpY2F0ZXMg dGhhdCB0aGUgV2luZG93cyA3IHBhdGggaW4gdGhlIHBsYXRmb3JtCmZpcm13YXJlIHdvcmtzLCBp dCBtYXkgYmUgd29ydGggdHJ5aW5nIHRvIGRvIHdoYXQgaXQgZG9lcyB0byB0aGUgUENJZQpsaW5r IGJlZm9yZSBpbnZva2luZyB0aGUgX09GRiBtZXRob2QgZm9yIHRoZSBwb3dlciByZXNvdXJjZQpj b250cm9sbGluZyB0aGUgR1BVIHBvd2VyLgoKSWYgdGhlIE1pa2EncyB0aGVvcnkgdGhhdCB0aGUg V2luNyBwYXRoIHNpbXBseSB0dXJucyB0aGUgUENJZSBsaW5rIG9mZgppcyBjb3JyZWN0LCB0aGVu IHdoYXRldmVyIHRoZSBfT0ZGIG1ldGhvZCB0cmllcyB0byBkbyB0byB0aGUgbGluawphZnRlciB0 aGF0IHNob3VsZCBub3QgbWF0dGVyLgoKPiBPbiBXZWQsIE5vdiAyNywgMjAxOSBhdCA4OjU1IFBN IEx5dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5jb20+IHdyb3RlOgo+ID4KPiA+IE9uIFdlZCwgMjAx OS0xMS0yNyBhdCAxMjo1MSArMDEwMCwgS2Fyb2wgSGVyYnN0IHdyb3RlOgo+ID4gPiBPbiBXZWQs IE5vdiAyNywgMjAxOSBhdCAxMjo0OSBQTSBNaWthIFdlc3RlcmJlcmcKPiA+ID4gPG1pa2Eud2Vz dGVyYmVyZ0BpbnRlbC5jb20+IHdyb3RlOgo+ID4gPiA+IE9uIFR1ZSwgTm92IDI2LCAyMDE5IGF0 IDA2OjEwOjM2UE0gLTA1MDAsIEx5dWRlIFBhdWwgd3JvdGU6Cj4gPiA+ID4gPiBIZXktdGhpcyBp cyBhbG1vc3QgY2VydGFpbmx5IG5vdCB0aGUgcmlnaHQgcGxhY2UgaW4gdGhpcyB0aHJlYWQgdG8K PiA+ID4gPiA+IHJlc3BvbmQsCj4gPiA+ID4gPiBidXQgdGhpcyB0aHJlYWQgaGFzIGdvdHRlbiBz byBkZWVwIGV2b2x1dGlvbiBjYW4ndCBwdXNoIHRoZSBzdWJqZWN0Cj4gPiA+ID4gPiBmdXJ0aGVy IHRvCj4gPiA+ID4gPiB0aGUgcmlnaHQsIGhlaC4gU28gSSdsbCBqdXN0IHJlc3BvbmQgaGVyZS4K PiA+ID4gPgo+ID4gPiA+IDopCj4gPiA+ID4KPiA+ID4gPiA+IEkndmUgYmVlbiBmb2xsb3dpbmcg dGhpcyBhbmQgaGVscGluZyBvdXQgS2Fyb2wgd2l0aCB0ZXN0aW5nIGhlcmUgYW5kCj4gPiA+ID4g PiB0aGVyZS4KPiA+ID4gPiA+IFRoZXkgaGFkIG1lIHRlc3QgQmpvcm4ncyBQQ0kgYnJhbmNoIG9u IHRoZSBYMSBFeHRyZW1lIDJuZCBnZW5lcmF0aW9uLAo+ID4gPiA+ID4gd2hpY2gKPiA+ID4gPiA+ IGhhcyBhIHR1cmluZyBHUFUgYW5kIDgwODY6MTkwMSBQQ0kgYnJpZGdlLgo+ID4gPiA+ID4KPiA+ ID4gPiA+IEkgd2FzIGFib3V0IHRvIHNheSAidGhlIHBhdGNoIGZpeGVkIHRoaW5ncywgaG9vcmF5 ISIgYnV0IGl0IHNlZW1zIHRoYXQKPiA+ID4gPiA+IGFmdGVyCj4gPiA+ID4gPiB0cnlpbmcgcnVu dGltZSBzdXNwZW5kL3Jlc3VtZSBhIGNvdXBsZSB0aW1lcyB0aGluZ3MgZmFsbCBhcGFydCBhZ2Fp bjoKPiA+ID4gPgo+ID4gPiA+IFlvdSBtZWFuICRzdWJqZWN0IHBhdGNoLCBubz8KPiA+ID4gPgo+ ID4gPgo+ID4gPiBubywgSSB0b2xkIEx5dWRlIHRvIHRlc3QgdGhlIHBjaS9wbSBicmFuY2ggYXMg dGhlIHJ1bnBtIGVycm9ycyB3ZSBzYXcKPiA+ID4gb24gdGhhdCBtYWNoaW5lIGxvb2tlZCBkaWZm ZXJlbnQuIFNvbWUgQkFSIGVycm9yIHRoZSBHUFUgcmVwb3J0ZWQKPiA+ID4gYWZ0ZXIgaXQgZ290 IHJlc3VtZWQsIHNvIEkgd2FzIHdvbmRlcmluZyBpZiB0aGUgZGVsYXlzIHdlcmUgaGVscGluZwo+ ID4gPiB3aXRoIHRoYXQuIEJ1dCBhZnRlciBzb21lIGN5Y2xlcyBpdCBzdGlsbCBjYXVzZWQgdGhl IHNhbWUgaXNzdWUsIHRoYXQKPiA+ID4gdGhlIEdQVSBkaXNhcHBlYXJlZC4gTGF0ZXIgdGVzdGlu ZyBhbHNvIHNob3dlZCB0aGF0IG15IHBhdGNoIGFsc28KPiA+ID4gZGlkbid0IHNlZW0gdG8gaGVs cCB3aXRoIHRoaXMgZXJyb3Igc2FkbHkgOi8KPiA+ID4KPiA+ID4gPiA+IFsgIDY4Ni44ODMyNDdd IG5vdXZlYXUgMDAwMDowMTowMC4wOiBEUk06IHN1c3BlbmRpbmcgb2JqZWN0IHRyZWUuLi4KPiA+ ID4gPiA+IFsgIDc1Mi44NjY0ODRdIEFDUEkgRXJyb3I6IEFib3J0aW5nIG1ldGhvZCBcX1NCLlBD STAuUEVHMC5QRUdQLk5WUE8gZHVlCj4gPiA+ID4gPiB0byBwcmV2aW91cyBlcnJvciAoQUVfQU1M X0xPT1BfVElNRU9VVCkgKDIwMTkwODE2L3BzcGFyc2UtNTI5KQo+ID4gPiA+ID4gWyAgNzUyLjg2 NjUwOF0gQUNQSSBFcnJvcjogQWJvcnRpbmcgbWV0aG9kIFxfU0IuUENJMC5QR09OIGR1ZSB0bwo+ ID4gPiA+ID4gcHJldmlvdXMgZXJyb3IgKEFFX0FNTF9MT09QX1RJTUVPVVQpICgyMDE5MDgxNi9w c3BhcnNlLTUyOSkKPiA+ID4gPiA+IFsgIDc1Mi44NjY1MjFdIEFDUEkgRXJyb3I6IEFib3J0aW5n IG1ldGhvZCBcX1NCLlBDSTAuUEVHMC5QRzAwLl9PTiBkdWUKPiA+ID4gPiA+IHRvIHByZXZpb3Vz IGVycm9yIChBRV9BTUxfTE9PUF9USU1FT1VUKSAoMjAxOTA4MTYvcHNwYXJzZS01MjkpCj4gPiA+ ID4KPiA+ID4gPiBUaGlzIGlzIHByb2JhYmx5IHRoZSBjdWxwcml0LiBUaGUgc2FtZSBBTUwgY29k ZSBmYWlscyB0byBwcm9wZXJseSB0dXJuCj4gPiA+ID4gb24gdGhlIGRldmljZS4KPiA+ID4gPgo+ ID4gPiA+IElzIGFjcGlkdW1wIGZyb20gdGhpcyBzeXN0ZW0gYXZhaWxhYmxlIHNvbWV3aGVyZT8K PiA+Cj4gPiBBdHRhY2hlZCBpdCB0byB0aGlzIGVtYWlsCj4gPgo+ID4gPiA+Cj4gPiAtLQo+ID4g Q2hlZXJzLAo+ID4gICAgICAgICBMeXVkZSBQYXVsCj4KX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVs