From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DFFCC43215 for ; Wed, 20 Nov 2019 21:37:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2187A2089D for ; Wed, 20 Nov 2019 21:37:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574285839; bh=wCVkX5zJWXohjxns4syxefXspebuJN052ShGvcXSY0Q=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=d0DlKbhCJYH0MFeiSNdez4h5n6Nk1uGPwn2d++OnZdCWrpYOeUmYLefZjq/ODsug/ 9c27pUxw71vQ79M34rBZnscquPDZRa3T04GPml9FdWA+kwdw2EBWTMVv9LC5/vrlde ykycc005ynwqHHoVUg1v8r3OekyvKDbCYlQUrSHc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726744AbfKTVhS (ORCPT ); Wed, 20 Nov 2019 16:37:18 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:33393 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725956AbfKTVhR (ORCPT ); Wed, 20 Nov 2019 16:37:17 -0500 Received: by mail-ot1-f66.google.com with SMTP id u13so1024423ote.0; Wed, 20 Nov 2019 13:37:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wCVkX5zJWXohjxns4syxefXspebuJN052ShGvcXSY0Q=; b=dyOdHjs5B6oOP5ZyPPB2BDet1F0ONaYW1mGbfWZQaO/H7jrC5Pulz9d1PD2TLYS+yb X/Sbsli1fGhX60D2w7CwUdZKWXkSj4sU0cfh3bh95tdvZ/DGgw6HrHen/vudsojOA8ZM BCaS3KPtabWU+UDHGJAV7CP1guTHEf7/IOMucVKGPTAdUNayS6JxZ38mHDzKwy5YABEU GddaF76PraCVuAWXXA2XJqig6XEqR54TYwsP16eoG3n78eF9b2/fazUPqelrBUIN/56a sOTdl3rpyL5dYXCzhbw3KSWVvs+Gzgm3v2UfX2NTbp9pAc54Iq1pV8ugDhz18Lpwe26d ou3w== X-Gm-Message-State: APjAAAXkJU6n0aAwCdlSmo42+LvHU+19QzsABxRd2jJlfaQoJVYlx6Os lSaDKxpiMEuU5I4i7AtyrDuYA3Wzc7aAMPg0kMc= X-Google-Smtp-Source: APXvYqyRmkpra7eCONirWdvpeM1m2+b4g+wNLsgwEi2XIALPyQJCt4qe8N7ImCPtPVHMrV4j5umXCYDJtFGHlucB2gA= X-Received: by 2002:a05:6830:103:: with SMTP id i3mr3888714otp.266.1574285836460; Wed, 20 Nov 2019 13:37:16 -0800 (PST) MIME-Version: 1.0 References: <20191120101816.GX11621@lahna.fi.intel.com> <20191120112212.GA11621@lahna.fi.intel.com> <20191120115127.GD11621@lahna.fi.intel.com> <20191120120913.GE11621@lahna.fi.intel.com> <20191120151542.GH11621@lahna.fi.intel.com> <20191120155301.GL11621@lahna.fi.intel.com> In-Reply-To: <20191120155301.GL11621@lahna.fi.intel.com> From: "Rafael J. Wysocki" Date: Wed, 20 Nov 2019 22:37:05 +0100 Message-ID: Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges To: Mika Westerberg Cc: Karol Herbst , "Rafael J. Wysocki" , Bjorn Helgaas , LKML , Lyude Paul , "Rafael J . Wysocki" , Linux PCI , Linux PM , dri-devel , nouveau , Dave Airlie , Mario Limonciello Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 20, 2019 at 4:53 PM Mika Westerberg wrote: > > On Wed, Nov 20, 2019 at 04:37:14PM +0100, Karol Herbst wrote: > > On Wed, Nov 20, 2019 at 4:15 PM Mika Westerberg > > wrote: > > > > > > On Wed, Nov 20, 2019 at 01:11:52PM +0100, Karol Herbst wrote: > > > > On Wed, Nov 20, 2019 at 1:09 PM Mika Westerberg > > > > wrote: > > > > > > > > > > On Wed, Nov 20, 2019 at 12:58:00PM +0100, Karol Herbst wrote: > > > > > > overall, what I really want to know is, _why_ does it work on windows? > > > > > > > > > > So do I ;-) > > > > > > > > > > > Or what are we doing differently on Linux so that it doesn't work? If > > > > > > anybody has any idea on how we could dig into this and figure it out > > > > > > on this level, this would probably allow us to get closer to the root > > > > > > cause? no? > > > > > > > > > > Have you tried to use the acpi_rev_override parameter in your system and > > > > > does it have any effect? > > > > > > > > > > Also did you try to trace the ACPI _ON/_OFF() methods? I think that > > > > > should hopefully reveal something. > > > > > > > > > > > > > I think I did in the past and it seemed to have worked, there is just > > > > one big issue with this: it's a Dell specific workaround afaik, and > > > > this issue plagues not just Dell, but we've seen it on HP and Lenovo > > > > laptops as well, and I've heard about users having the same issues on > > > > Asus and MSI laptops as well. > > > > > > Maybe it is not a workaround at all but instead it simply determines > > > whether the system supports RTD3 or something like that (IIRC Windows 8 > > > started supporting it). Maybe Dell added check for Linux because at that > > > time Linux did not support it. > > > > > > > the point is, it's not checking it by default, so by default you still > > run into the windows 8 codepath. > > Well you can add the quirk to acpi_rev_dmi_table[] so it goes to that > path by default. There are a bunch of similar entries for Dell machines. OK, so the "Linux path" works and the other doesn't. I thought that this was the other way around, sorry for the confusion. > Of course this does not help the non-Dell users so we would still need > to figure out the root cause. Right. Whatever it is, though, AML appears to be involved in it and AFAICS there's no evidence that it affects any root ports that are not populated with NVidia GPUs. Now, one thing is still not clear to me from the discussion so far: is the _PR3 method you mentioned defined under the GPU device object or under the port device object? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8E05C432C0 for ; Wed, 20 Nov 2019 21:37:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B47C32075E for ; Wed, 20 Nov 2019 21:37:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B47C32075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C28436EA2E; Wed, 20 Nov 2019 21:37:24 +0000 (UTC) Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5C3F66EA28; Wed, 20 Nov 2019 21:37:17 +0000 (UTC) Received: by mail-ot1-f67.google.com with SMTP id m15so976371otq.7; Wed, 20 Nov 2019 13:37:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wCVkX5zJWXohjxns4syxefXspebuJN052ShGvcXSY0Q=; b=BvdFi/5cyMQKFPj4ZoQtommTQv+Y+um4xRXPZXJCe9M9wIfUbIpwBgYcQ7oo+0bSD5 O60AdnnYYnZbXXTqUs1EO/fYHUTycMKpCLbJJ2gji50fNofwHFSvHfu5FLtYhcQX/Prh bIb+32MFRqOkGYIEFFKMDq5NoB/6HrtVKd66gG8i/fVfQaHPR0xakMaCUoifQlCnDyTq QAKTSRet9ZOPox3lJnHugScGK9uZCA7vRg3wwEOK4/jCbSlqQugKH8Wb+rtDeD/Rg7g7 AXjwrUiGEqPNlKyIpuW8IRn6MDq51YnFVP61LABI0ta2jxbzolaYFNwMqSp1DCtfOqcc ws7Q== X-Gm-Message-State: APjAAAXiJ5z+m0vaO6y17dEM+OKmR4JtAJdTUuJtWE9fQColjR3RlSQa 0WMrwlPVSLWAK1zLWdAHieyX1h+Xo8PIkjRAqlI= X-Google-Smtp-Source: APXvYqyRmkpra7eCONirWdvpeM1m2+b4g+wNLsgwEi2XIALPyQJCt4qe8N7ImCPtPVHMrV4j5umXCYDJtFGHlucB2gA= X-Received: by 2002:a05:6830:103:: with SMTP id i3mr3888714otp.266.1574285836460; Wed, 20 Nov 2019 13:37:16 -0800 (PST) MIME-Version: 1.0 References: <20191120101816.GX11621@lahna.fi.intel.com> <20191120112212.GA11621@lahna.fi.intel.com> <20191120115127.GD11621@lahna.fi.intel.com> <20191120120913.GE11621@lahna.fi.intel.com> <20191120151542.GH11621@lahna.fi.intel.com> <20191120155301.GL11621@lahna.fi.intel.com> In-Reply-To: <20191120155301.GL11621@lahna.fi.intel.com> From: "Rafael J. Wysocki" Date: Wed, 20 Nov 2019 22:37:05 +0100 Message-ID: Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges To: Mika Westerberg X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karol Herbst , "Rafael J. Wysocki" , Linux PCI , Linux PM , "Rafael J . Wysocki" , LKML , dri-devel , Mario Limonciello , Bjorn Helgaas , nouveau Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191120213705.i9IKYvbruOrietqSTEg1PgkXOTFhXrbq_Zm-WWPU_1E@z> T24gV2VkLCBOb3YgMjAsIDIwMTkgYXQgNDo1MyBQTSBNaWthIFdlc3RlcmJlcmcKPG1pa2Eud2Vz dGVyYmVyZ0BpbnRlbC5jb20+IHdyb3RlOgo+Cj4gT24gV2VkLCBOb3YgMjAsIDIwMTkgYXQgMDQ6 Mzc6MTRQTSArMDEwMCwgS2Fyb2wgSGVyYnN0IHdyb3RlOgo+ID4gT24gV2VkLCBOb3YgMjAsIDIw MTkgYXQgNDoxNSBQTSBNaWthIFdlc3RlcmJlcmcKPiA+IDxtaWthLndlc3RlcmJlcmdAaW50ZWwu Y29tPiB3cm90ZToKPiA+ID4KPiA+ID4gT24gV2VkLCBOb3YgMjAsIDIwMTkgYXQgMDE6MTE6NTJQ TSArMDEwMCwgS2Fyb2wgSGVyYnN0IHdyb3RlOgo+ID4gPiA+IE9uIFdlZCwgTm92IDIwLCAyMDE5 IGF0IDE6MDkgUE0gTWlrYSBXZXN0ZXJiZXJnCj4gPiA+ID4gPG1pa2Eud2VzdGVyYmVyZ0BpbnRl bC5jb20+IHdyb3RlOgo+ID4gPiA+ID4KPiA+ID4gPiA+IE9uIFdlZCwgTm92IDIwLCAyMDE5IGF0 IDEyOjU4OjAwUE0gKzAxMDAsIEthcm9sIEhlcmJzdCB3cm90ZToKPiA+ID4gPiA+ID4gb3ZlcmFs bCwgd2hhdCBJIHJlYWxseSB3YW50IHRvIGtub3cgaXMsIF93aHlfIGRvZXMgaXQgd29yayBvbiB3 aW5kb3dzPwo+ID4gPiA+ID4KPiA+ID4gPiA+IFNvIGRvIEkgOy0pCj4gPiA+ID4gPgo+ID4gPiA+ ID4gPiBPciB3aGF0IGFyZSB3ZSBkb2luZyBkaWZmZXJlbnRseSBvbiBMaW51eCBzbyB0aGF0IGl0 IGRvZXNuJ3Qgd29yaz8gSWYKPiA+ID4gPiA+ID4gYW55Ym9keSBoYXMgYW55IGlkZWEgb24gaG93 IHdlIGNvdWxkIGRpZyBpbnRvIHRoaXMgYW5kIGZpZ3VyZSBpdCBvdXQKPiA+ID4gPiA+ID4gb24g dGhpcyBsZXZlbCwgdGhpcyB3b3VsZCBwcm9iYWJseSBhbGxvdyB1cyB0byBnZXQgY2xvc2VyIHRv IHRoZSByb290Cj4gPiA+ID4gPiA+IGNhdXNlPyBubz8KPiA+ID4gPiA+Cj4gPiA+ID4gPiBIYXZl IHlvdSB0cmllZCB0byB1c2UgdGhlIGFjcGlfcmV2X292ZXJyaWRlIHBhcmFtZXRlciBpbiB5b3Vy IHN5c3RlbSBhbmQKPiA+ID4gPiA+IGRvZXMgaXQgaGF2ZSBhbnkgZWZmZWN0Pwo+ID4gPiA+ID4K PiA+ID4gPiA+IEFsc28gZGlkIHlvdSB0cnkgdG8gdHJhY2UgdGhlIEFDUEkgX09OL19PRkYoKSBt ZXRob2RzPyBJIHRoaW5rIHRoYXQKPiA+ID4gPiA+IHNob3VsZCBob3BlZnVsbHkgcmV2ZWFsIHNv bWV0aGluZy4KPiA+ID4gPiA+Cj4gPiA+ID4KPiA+ID4gPiBJIHRoaW5rIEkgZGlkIGluIHRoZSBw YXN0IGFuZCBpdCBzZWVtZWQgdG8gaGF2ZSB3b3JrZWQsIHRoZXJlIGlzIGp1c3QKPiA+ID4gPiBv bmUgYmlnIGlzc3VlIHdpdGggdGhpczogaXQncyBhIERlbGwgc3BlY2lmaWMgd29ya2Fyb3VuZCBh ZmFpaywgYW5kCj4gPiA+ID4gdGhpcyBpc3N1ZSBwbGFndWVzIG5vdCBqdXN0IERlbGwsIGJ1dCB3 ZSd2ZSBzZWVuIGl0IG9uIEhQIGFuZCBMZW5vdm8KPiA+ID4gPiBsYXB0b3BzIGFzIHdlbGwsIGFu ZCBJJ3ZlIGhlYXJkIGFib3V0IHVzZXJzIGhhdmluZyB0aGUgc2FtZSBpc3N1ZXMgb24KPiA+ID4g PiBBc3VzIGFuZCBNU0kgbGFwdG9wcyBhcyB3ZWxsLgo+ID4gPgo+ID4gPiBNYXliZSBpdCBpcyBu b3QgYSB3b3JrYXJvdW5kIGF0IGFsbCBidXQgaW5zdGVhZCBpdCBzaW1wbHkgZGV0ZXJtaW5lcwo+ ID4gPiB3aGV0aGVyIHRoZSBzeXN0ZW0gc3VwcG9ydHMgUlREMyBvciBzb21ldGhpbmcgbGlrZSB0 aGF0IChJSVJDIFdpbmRvd3MgOAo+ID4gPiBzdGFydGVkIHN1cHBvcnRpbmcgaXQpLiBNYXliZSBE ZWxsIGFkZGVkIGNoZWNrIGZvciBMaW51eCBiZWNhdXNlIGF0IHRoYXQKPiA+ID4gdGltZSBMaW51 eCBkaWQgbm90IHN1cHBvcnQgaXQuCj4gPiA+Cj4gPgo+ID4gdGhlIHBvaW50IGlzLCBpdCdzIG5v dCBjaGVja2luZyBpdCBieSBkZWZhdWx0LCBzbyBieSBkZWZhdWx0IHlvdSBzdGlsbAo+ID4gcnVu IGludG8gdGhlIHdpbmRvd3MgOCBjb2RlcGF0aC4KPgo+IFdlbGwgeW91IGNhbiBhZGQgdGhlIHF1 aXJrIHRvIGFjcGlfcmV2X2RtaV90YWJsZVtdIHNvIGl0IGdvZXMgdG8gdGhhdAo+IHBhdGggYnkg ZGVmYXVsdC4gVGhlcmUgYXJlIGEgYnVuY2ggb2Ygc2ltaWxhciBlbnRyaWVzIGZvciBEZWxsIG1h Y2hpbmVzLgoKT0ssIHNvIHRoZSAiTGludXggcGF0aCIgd29ya3MgYW5kIHRoZSBvdGhlciBkb2Vz bid0LgoKSSB0aG91Z2h0IHRoYXQgdGhpcyB3YXMgdGhlIG90aGVyIHdheSBhcm91bmQsIHNvcnJ5 IGZvciB0aGUgY29uZnVzaW9uLgoKPiBPZiBjb3Vyc2UgdGhpcyBkb2VzIG5vdCBoZWxwIHRoZSBu b24tRGVsbCB1c2VycyBzbyB3ZSB3b3VsZCBzdGlsbCBuZWVkCj4gdG8gZmlndXJlIG91dCB0aGUg cm9vdCBjYXVzZS4KClJpZ2h0LgoKV2hhdGV2ZXIgaXQgaXMsIHRob3VnaCwgQU1MIGFwcGVhcnMg dG8gYmUgaW52b2x2ZWQgaW4gaXQgYW5kIEFGQUlDUwp0aGVyZSdzIG5vIGV2aWRlbmNlIHRoYXQg aXQgYWZmZWN0cyBhbnkgcm9vdCBwb3J0cyB0aGF0IGFyZSBub3QKcG9wdWxhdGVkIHdpdGggTlZp ZGlhIEdQVXMuCgpOb3csIG9uZSB0aGluZyBpcyBzdGlsbCBub3QgY2xlYXIgdG8gbWUgZnJvbSB0 aGUgZGlzY3Vzc2lvbiBzbyBmYXI6IGlzCnRoZSBfUFIzIG1ldGhvZCB5b3UgbWVudGlvbmVkIGRl ZmluZWQgdW5kZXIgdGhlIEdQVSBkZXZpY2Ugb2JqZWN0IG9yCnVuZGVyIHRoZSBwb3J0IGRldmlj ZSBvYmplY3Q/Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==