From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACD76C433DF for ; Tue, 26 May 2020 08:39:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D99C20787 for ; Tue, 26 May 2020 08:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590482350; bh=LZd35WMOa7IbfDvr8mZwpDwQwMekO2DmhzIGj/f0MHg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=U08NSgA+EYxkxDUZ3c5r/MJJOuJv4zGUCTL7+t2R0rXJ2M5RO/T/mmWwLoHDivVZ8 jdNNUuFFbnqucPHVvM38ziNu9nBOHqjT7Qcythoz6XAtjI8hDtvhT/lOApG0hnIpLF 15m7RJ0IgcZatUL7kYXiZrYaqMOFjHr9YeLpB96c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730023AbgEZIjK convert rfc822-to-8bit (ORCPT ); Tue, 26 May 2020 04:39:10 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:42355 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728516AbgEZIjJ (ORCPT ); Tue, 26 May 2020 04:39:09 -0400 Received: by mail-ot1-f67.google.com with SMTP id z3so15626949otp.9; Tue, 26 May 2020 01:39:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MpwY3EHc5z85EihmevYmSupSr3w2Pyaz4sc6UHi08wA=; b=THJavD6TYGCMTkFEN445a4SyCaYydzMAEnjQ4yo3GHCeH7RP+WZy8uJJuPgZ2/pLfC x9igDO4yJmCJtVoypSWlVb96jb1cmxDovIgbOODut3UXEq52tlpgZYtV630arLaultMe WgoN96/7MOnzQHLvmF80oa7Fl3U1zD4AXAtzFTDRxdWJVVX+UM/iUAkvfn9GBOMxDQbn CoCJJwN/9lR9M+BzeAJ2Fvu6Ew1quXmt5BHM1a9TDEPinK12Y9FFEdr2H2hdSkaMR5nj uPH9e7X1x8lsd237CMFsegWizytsLwIJJnvLQCDh0t6eNbYoUcYlwu518FRW9q9IVe2y Y0uA== X-Gm-Message-State: AOAM532+cJb3MDqSS6QdXTcf5LwAF685IGszKu0Kjp4V1aHyfptx0AQU 4b1hWTGbPm/j75JxsTBvKpPCPHQbU5TAVGAhUBA= X-Google-Smtp-Source: ABdhPJyg99dhbbsUdUpzqyLlD2Zp0WEwPi+B3o8RxPqwRzQCCrVCeDF3laDVas19O0CvHdxuwQP2MEhi6k5TafK25JQ= X-Received: by 2002:a9d:6c0f:: with SMTP id f15mr94657otq.118.1590482348592; Tue, 26 May 2020 01:39:08 -0700 (PDT) MIME-Version: 1.0 References: <20200525182608.1823735-1-kw@linux.com> <20200525182608.1823735-6-kw@linux.com> In-Reply-To: <20200525182608.1823735-6-kw@linux.com> From: "Rafael J. Wysocki" Date: Tue, 26 May 2020 10:38:56 +0200 Message-ID: Subject: Re: [PATCH 5/8] usb: phy: fsl: Use the new device_to_pm() helper to access struct dev_pm_ops To: =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= Cc: Dan Carpenter , "Rafael J. Wysocki" , Len Brown , Kevin Hilman , Ulf Hansson , Pavel Machek , Greg Kroah-Hartman , Johan Hovold , Alex Elder , Bjorn Helgaas , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , Julian Wiedmann , Karsten Graul , Ursula Braun , Jakub Kicinski , Bjorn Andersson , John Stultz , "David S. Miller" , greybus-dev@lists.linaro.org, netdev , ACPI Devel Maling List , Linux PCI , Linux PM , linux-s390@vger.kernel.org, "open list:TARGET SUBSYSTEM" , "open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, May 25, 2020 at 8:26 PM Krzysztof Wilczyński wrote: > > Use the new device_to_pm() helper to access Power Management callbacs > (struct dev_pm_ops) for a particular device (struct device_driver). > > No functional change intended. > > Signed-off-by: Krzysztof Wilczyński > --- > drivers/usb/phy/phy-fsl-usb.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/phy/phy-fsl-usb.c b/drivers/usb/phy/phy-fsl-usb.c > index b451f4695f3f..3b9ad5db8380 100644 > --- a/drivers/usb/phy/phy-fsl-usb.c > +++ b/drivers/usb/phy/phy-fsl-usb.c > @@ -460,6 +460,7 @@ int fsl_otg_start_host(struct otg_fsm *fsm, int on) > struct device *dev; > struct fsl_otg *otg_dev = > container_of(otg->usb_phy, struct fsl_otg, phy); > + const struct dev_pm_ops *pm; > u32 retval = 0; > > if (!otg->host) > @@ -479,8 +480,9 @@ int fsl_otg_start_host(struct otg_fsm *fsm, int on) > else { > otg_reset_controller(); > VDBG("host on......\n"); > - if (dev->driver->pm && dev->driver->pm->resume) { > - retval = dev->driver->pm->resume(dev); > + pm = driver_to_pm(dev->driver); > + if (pm && pm->resume) { > + retval = pm->resume(dev); And why is the new version better this time? > if (fsm->id) { > /* default-b */ > fsl_otg_drv_vbus(fsm, 1); > @@ -504,8 +506,9 @@ int fsl_otg_start_host(struct otg_fsm *fsm, int on) > else { > VDBG("host off......\n"); > if (dev && dev->driver) { > - if (dev->driver->pm && dev->driver->pm->suspend) > - retval = dev->driver->pm->suspend(dev); > + pm = driver_to_pm(dev->driver); > + if (pm && pm->suspend) > + retval = pm->suspend(dev); > if (fsm->id) > /* default-b */ > fsl_otg_drv_vbus(fsm, 0); > -- > 2.26.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 References: <20200525182608.1823735-1-kw@linux.com> <20200525182608.1823735-6-kw@linux.com> In-Reply-To: <20200525182608.1823735-6-kw@linux.com> From: "Rafael J. Wysocki" Date: Tue, 26 May 2020 10:38:56 +0200 Message-ID: Subject: Re: [PATCH 5/8] usb: phy: fsl: Use the new device_to_pm() helper to access struct dev_pm_ops Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org List-ID: To: =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= Cc: Dan Carpenter , "Rafael J. Wysocki" , Len Brown , Kevin Hilman , Ulf Hansson , Pavel Machek , Greg Kroah-Hartman , Johan Hovold , Alex Elder , Bjorn Helgaas , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , Julian Wiedmann , Karsten Graul , Ursula Braun , Jakub Kicinski , Bjorn Andersson , John Stultz , "David S. Miller" , greybus-dev@lists.linaro.org, netdev , ACPI Devel Maling List , Linux PCI , Linux PM , linux-s390@vger.kernel.org, "open list:TARGET SUBSYSTEM" , "open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:" On Mon, May 25, 2020 at 8:26 PM Krzysztof Wilczyński wrote: > > Use the new device_to_pm() helper to access Power Management callbacs > (struct dev_pm_ops) for a particular device (struct device_driver). > > No functional change intended. > > Signed-off-by: Krzysztof Wilczyński > --- > drivers/usb/phy/phy-fsl-usb.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/phy/phy-fsl-usb.c b/drivers/usb/phy/phy-fsl-usb.c > index b451f4695f3f..3b9ad5db8380 100644 > --- a/drivers/usb/phy/phy-fsl-usb.c > +++ b/drivers/usb/phy/phy-fsl-usb.c > @@ -460,6 +460,7 @@ int fsl_otg_start_host(struct otg_fsm *fsm, int on) > struct device *dev; > struct fsl_otg *otg_dev = > container_of(otg->usb_phy, struct fsl_otg, phy); > + const struct dev_pm_ops *pm; > u32 retval = 0; > > if (!otg->host) > @@ -479,8 +480,9 @@ int fsl_otg_start_host(struct otg_fsm *fsm, int on) > else { > otg_reset_controller(); > VDBG("host on......\n"); > - if (dev->driver->pm && dev->driver->pm->resume) { > - retval = dev->driver->pm->resume(dev); > + pm = driver_to_pm(dev->driver); > + if (pm && pm->resume) { > + retval = pm->resume(dev); And why is the new version better this time? > if (fsm->id) { > /* default-b */ > fsl_otg_drv_vbus(fsm, 1); > @@ -504,8 +506,9 @@ int fsl_otg_start_host(struct otg_fsm *fsm, int on) > else { > VDBG("host off......\n"); > if (dev && dev->driver) { > - if (dev->driver->pm && dev->driver->pm->suspend) > - retval = dev->driver->pm->suspend(dev); > + pm = driver_to_pm(dev->driver); > + if (pm && pm->suspend) > + retval = pm->suspend(dev); > if (fsm->id) > /* default-b */ > fsl_otg_drv_vbus(fsm, 0); > -- > 2.26.2 >