From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1EF6C433E3 for ; Wed, 26 Aug 2020 13:20:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 755FC2080C for ; Wed, 26 Aug 2020 13:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598448034; bh=PWAM+fSMgJoSOIShD1u7yfMXsrJhEvdfCxjPmQvzz1A=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=jgkYuh5wY9DWLLj2SOZwFaRVbVtdSD4/nc+r+iQVu29guP+Y9La05XR/gDpfG0D57 SUFDBFiV9aawYuQONvmLtlgWds1UTOy3kEv4BFV/G96hr2eyjXGG8KQK/Hsl9BGJMp MTZbI2lgTdsvuOFVdEidfhynaLhEmxBV+NNO2w7A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730244AbgHZNUb (ORCPT ); Wed, 26 Aug 2020 09:20:31 -0400 Received: from mail-oo1-f65.google.com ([209.85.161.65]:38303 "EHLO mail-oo1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730227AbgHZNUZ (ORCPT ); Wed, 26 Aug 2020 09:20:25 -0400 Received: by mail-oo1-f65.google.com with SMTP id z11so432336oon.5; Wed, 26 Aug 2020 06:20:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PWAM+fSMgJoSOIShD1u7yfMXsrJhEvdfCxjPmQvzz1A=; b=fc4Inb13Wth035FjdizJpRz9UYhvQ7ZNvjLUUiwmNKznOcrYJeeobLDEqaTbXlu8fW 1CYk4y4t1gG+dRmrdx25yy66Zj7Gn7hRDCJnUPoVsgigI7I8bSIUZtk1bvLH2gLjwwTb wOssj+kNKpAq8zZ4BDjpf0weCESwscHnKwoDcwYPXPWHkuvb3zUu4vBtwVzyK63gBNf+ AVyQ0JV5iFHaH+d/t/gsAH3zEt3K3EmwrSVDcW6T5SjLZKH6hBbCIv1vsGhi8QYyEn3n gUTerWcJcOwsIwXVZRyhPq7pTAQ1P4jIauEemboO03zJoDJ4E8UDa2EOKw8eunErTIKE UMXQ== X-Gm-Message-State: AOAM530nm2RnDEKdVMjWmzPWqVo4+BaPu1PvPO5kkgbucYgw23aJDUY/ 75aFBlQq3PJfCPuA2c18ZRic1m+Vj+F9q85et6g= X-Google-Smtp-Source: ABdhPJyYYmr8DMHJ7k2ZgyqVB9v2GAJt6G0w+tTYb2PRyQqL6H9WNqhVZH4qzKdXt4Tll8WOsUMEjHzxpQ+U0Vs4SRU= X-Received: by 2002:a4a:d62c:: with SMTP id n12mr10597744oon.38.1598448023959; Wed, 26 Aug 2020 06:20:23 -0700 (PDT) MIME-Version: 1.0 References: <20200826120421.44356-1-guilhem@barpilot.io> In-Reply-To: From: "Rafael J. Wysocki" Date: Wed, 26 Aug 2020 15:20:12 +0200 Message-ID: Subject: Re: [PATCH] intel_idle: Add ICL support To: Artem Bityutskiy Cc: Guilhem Lettron , "Rafael J. Wysocki" , Jacob Pan , Len Brown , Linux PM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 26, 2020 at 3:09 PM Artem Bityutskiy wrote: > > On Wed, 2020-08-26 at 15:03 +0200, Guilhem Lettron wrote: > > On Wed, 26 Aug 2020 at 14:43, Rafael J. Wysocki wrote: > > > On Wed, Aug 26, 2020 at 2:05 PM Guilhem Lettron wrote: > > > > Use the same C-states as SKL > > > > > > Why is this change needed? > > > > On my laptop, a Dell XPS 13 7390 2-in-1 with i7-1065G7, ACPI only > > report "C1_ACPI", "C2_ACPI" and "C3_ACPI". > > Did you try to dig into the BIOS menus and check if you can enable > more/deeper C-states? I would be surprised if there were settings for that in the BIOS, as Windows only expects #1, C2 and C3 AFAICS. It might be possible to disable C1E autopromotion, but that option is not likely to be available on a laptop. Cheers!