From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B44EDC433E1 for ; Thu, 14 May 2020 11:21:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8707A207EA for ; Thu, 14 May 2020 11:21:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589455266; bh=eWBgO47lnG713+uOJyYwph49VutX66y/dqfc4fFqRL8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=oirCuFlzaXNE78RQjftb3mIn2MnAhvGkBYbISwwA+CNNc5kwK7KZikckeggOlw2uj vLQ63sM2B/zNauhNOftrUhvP65YuJpHyo0xa1e8MfMLV0bRiRojUYhF3d5rkpE07bX YXq0L/Jo0oVkFkpXQ2MuuuVdD3Mq1LkD8zjQPhQM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726140AbgENLVF (ORCPT ); Thu, 14 May 2020 07:21:05 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:37575 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725925AbgENLVF (ORCPT ); Thu, 14 May 2020 07:21:05 -0400 Received: by mail-ot1-f67.google.com with SMTP id z17so2036064oto.4; Thu, 14 May 2020 04:21:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mjaEhAMukt4Q737HPM6C7TaDlquG096H0lSzCeaiEoc=; b=VGMfZMnKMmRN0cmSILvH0P4ao1gR1iQgt3cfzoBTCo29kKZA1Bo3Uisa8WNIMuD7gT qIbA3qiidb1vjWKCAlirii9q8W0nfFogmp/fr3j1dSu2mpVVcRDMg7N+5+g6jUn0ijYm YJoPHhFOYhonTtEBbBVzJysvcy9EPEIxluC4JgLfo1lm3LxB/eRda3cyJ6MGl0kr+3+H cm0jimxmbJRUj0NgJLcFGs4aehzAXD96Huh3905dRQe5p6cYAQsyCvWlEsjf2TM3HCNu GoGAQcavk/wM3wYb9sAQvyKF6W/OuVenXNGOJ6KO7B1DVCdDQWSkol+WiMCvLEZ+gixi FemQ== X-Gm-Message-State: AOAM531/QTpQ34AAhyy/lGM20zp4x/hjVFsPxeoVw9ekjbUZwy0Qk3Rp MKzJXBuXKAJl9F2ylttfEhuCs7j7ikyYeLq+yYY= X-Google-Smtp-Source: ABdhPJyTpBVQvJyPeh8jlL2d0XL6Aye1NJbTU0L7nP/qUpDkvDYChurJ2m7cErQetQ0NI1Dhki2u1VhMPXPI4JktJ7I= X-Received: by 2002:a9d:6356:: with SMTP id y22mr2944323otk.167.1589455262888; Thu, 14 May 2020 04:21:02 -0700 (PDT) MIME-Version: 1.0 References: <20200513214351.2138580-1-emil.l.velikov@gmail.com> <20200513214351.2138580-10-emil.l.velikov@gmail.com> In-Reply-To: <20200513214351.2138580-10-emil.l.velikov@gmail.com> From: "Rafael J. Wysocki" Date: Thu, 14 May 2020 13:20:51 +0200 Message-ID: Subject: Re: [PATCH 10/11] kernel/power: constify sysrq_key_op To: Emil Velikov Cc: dri-devel , Greg Kroah-Hartman , Jiri Slaby , Linux Kernel Mailing List , "Rafael J. Wysocki" , Len Brown , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 13, 2020 at 11:46 PM Emil Velikov wrote: > > With earlier commits, the API no longer discards the const-ness of the > sysrq_key_op. As such we can add the notation. > > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linux-kernel@vger.kernel.org > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: linux-pm@vger.kernel.org > Signed-off-by: Emil Velikov Acked-by: Rafael J. Wysocki and I'm assuming that this is going to be applied along with the rest of the series. > --- > Please keep me in the CC list, as I'm not subscribed to the list. > > IMHO it would be better if this gets merged this via the tty tree. > --- > kernel/power/poweroff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/power/poweroff.c b/kernel/power/poweroff.c > index 6d475281c730..562aa0e450ed 100644 > --- a/kernel/power/poweroff.c > +++ b/kernel/power/poweroff.c > @@ -29,7 +29,7 @@ static void handle_poweroff(int key) > schedule_work_on(cpumask_first(cpu_online_mask), &poweroff_work); > } > > -static struct sysrq_key_op sysrq_poweroff_op = { > +static const struct sysrq_key_op sysrq_poweroff_op = { > .handler = handle_poweroff, > .help_msg = "poweroff(o)", > .action_msg = "Power Off", > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1C70C433DF for ; Thu, 14 May 2020 11:21:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAEA2206A5 for ; Thu, 14 May 2020 11:21:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAEA2206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 467A26E326; Thu, 14 May 2020 11:21:04 +0000 (UTC) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A8BA6E326 for ; Thu, 14 May 2020 11:21:03 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id 63so2023022oto.8 for ; Thu, 14 May 2020 04:21:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mjaEhAMukt4Q737HPM6C7TaDlquG096H0lSzCeaiEoc=; b=mOXBRYwJnKRNXGpLr1E6rMWnYCaRIEDjBCruqko+V0Q0OB0xHrlU/fJMuSD+M7k/1d wSKA9T83yjHOIz9do4fPtC+wuD6K3kkIXH6/meq76g7xE41jGtRJVHl53Vsa5GzPe8rg 15MQCwCH/d6sauRn5xtEH/cZhKfJVn+0bikBQ1PSWvVzopiX0ZiY1o4IIl1idq+syKwI AvITZHAUsMi7xoVH5yV62eihovHNxe0F2LmMY6KKM8jM4GD8Cuuihq3NQ0g+Dd2G23VU WdBEq/gtU4kWMZ7wkQtTXaRJq7ErHhLWMxqGoAJYpItNt6Qi9p36bAsw6j6VQZ3fZgRM CUPw== X-Gm-Message-State: AOAM532CRkrE2Ou/AFYI0rjiEe18lU3DBc2oeqmvxPI63ZapiFGWdiNQ cz6bTF0qsmzJOCA5GhJpcCi9mZsZbNVXqem7q9o= X-Google-Smtp-Source: ABdhPJyTpBVQvJyPeh8jlL2d0XL6Aye1NJbTU0L7nP/qUpDkvDYChurJ2m7cErQetQ0NI1Dhki2u1VhMPXPI4JktJ7I= X-Received: by 2002:a9d:6356:: with SMTP id y22mr2944323otk.167.1589455262888; Thu, 14 May 2020 04:21:02 -0700 (PDT) MIME-Version: 1.0 References: <20200513214351.2138580-1-emil.l.velikov@gmail.com> <20200513214351.2138580-10-emil.l.velikov@gmail.com> In-Reply-To: <20200513214351.2138580-10-emil.l.velikov@gmail.com> From: "Rafael J. Wysocki" Date: Thu, 14 May 2020 13:20:51 +0200 Message-ID: Subject: Re: [PATCH 10/11] kernel/power: constify sysrq_key_op To: Emil Velikov X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Len Brown , Linux PM , Greg Kroah-Hartman , "Rafael J. Wysocki" , Linux Kernel Mailing List , dri-devel , Jiri Slaby Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, May 13, 2020 at 11:46 PM Emil Velikov wrote: > > With earlier commits, the API no longer discards the const-ness of the > sysrq_key_op. As such we can add the notation. > > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linux-kernel@vger.kernel.org > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: linux-pm@vger.kernel.org > Signed-off-by: Emil Velikov Acked-by: Rafael J. Wysocki and I'm assuming that this is going to be applied along with the rest of the series. > --- > Please keep me in the CC list, as I'm not subscribed to the list. > > IMHO it would be better if this gets merged this via the tty tree. > --- > kernel/power/poweroff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/power/poweroff.c b/kernel/power/poweroff.c > index 6d475281c730..562aa0e450ed 100644 > --- a/kernel/power/poweroff.c > +++ b/kernel/power/poweroff.c > @@ -29,7 +29,7 @@ static void handle_poweroff(int key) > schedule_work_on(cpumask_first(cpu_online_mask), &poweroff_work); > } > > -static struct sysrq_key_op sysrq_poweroff_op = { > +static const struct sysrq_key_op sysrq_poweroff_op = { > .handler = handle_poweroff, > .help_msg = "poweroff(o)", > .action_msg = "Power Off", > -- > 2.25.1 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel