From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 332EAC433FE for ; Thu, 7 Oct 2021 16:51:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12F4D61029 for ; Thu, 7 Oct 2021 16:51:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236109AbhJGQww (ORCPT ); Thu, 7 Oct 2021 12:52:52 -0400 Received: from mail-ot1-f43.google.com ([209.85.210.43]:45584 "EHLO mail-ot1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229810AbhJGQwv (ORCPT ); Thu, 7 Oct 2021 12:52:51 -0400 Received: by mail-ot1-f43.google.com with SMTP id g15-20020a9d128f000000b0054e3d55dd81so3118775otg.12; Thu, 07 Oct 2021 09:50:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aQITjc9EkelfmrMblmNfFJUe60PWwUG8kF/gKJHNbBc=; b=Bt/vlGbBj6PsGhgxH84G7Cx1PPHFg/FL0IjwoYSmOoJtjj/YbjisB2UmFXDvakIwa1 /+kd/Kyo214vY0mJnbMAOL+Jmb/BB/bi43lKfqLP9V+cBTHINpFuJO330wlJiy5IaaZC UbDDvDyDCIEmoDy2+d8Sv5cdKPNb/gvq2UUP2rGQt2IholhX8fcyh0D2Izo92Vr5zjig 5PanzghM+4P8NAre2Uy2IXjsIN+In8Br/P2NFE9AvNXGuQpgzDexZCNOA7WmapANiuHO Jxlf9bfmvWNqZvQi/CXnRL3FgY6Eov+qjJMPmHMpJtUWDWs2uEB0LnxQrggsEMdf+WZo 1LAg== X-Gm-Message-State: AOAM530KmRQWdS8dp2VkRm/ppGYZ2/nTvLBEEGrWHVXcM6xrxeg59qf0 ufICzw/g1/M3M0mWyHKsdFPBMRxBGWlunlIsTLc= X-Google-Smtp-Source: ABdhPJxkjmzjRmeA6qfA9L5v1U4is/YhJfMjAJ5Dp0rAk60j7IrwbvPf+wzuD0LRsGALgVrNNm8Wh2hn7IhCG/VmVtk= X-Received: by 2002:a9d:2f24:: with SMTP id h33mr4678062otb.254.1633625457450; Thu, 07 Oct 2021 09:50:57 -0700 (PDT) MIME-Version: 1.0 References: <20211006173125.84423-1-andriy.shevchenko@linux.intel.com> <20211006173125.84423-3-andriy.shevchenko@linux.intel.com> In-Reply-To: <20211006173125.84423-3-andriy.shevchenko@linux.intel.com> From: "Rafael J. Wysocki" Date: Thu, 7 Oct 2021 18:50:46 +0200 Message-ID: Subject: Re: [PATCH v2 3/3] gpiolib: acpi: Replace custom code with device_match_acpi_handle() To: Andy Shevchenko Cc: Greg Kroah-Hartman , Saravana Kannan , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , ACPI Devel Maling List , linux-i2c , "Rafael J. Wysocki" , Mika Westerberg , Linus Walleij , Bartosz Golaszewski , Wolfram Sang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Oct 6, 2021 at 7:31 PM Andy Shevchenko wrote: > > Since driver core provides a generic device_match_acpi_handle() > we may replace the custom code with it. > > Signed-off-by: Andy Shevchenko > --- > v2: no changes > drivers/gpio/gpiolib-acpi.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c > index 47712b6903b5..32f1f720b94b 100644 > --- a/drivers/gpio/gpiolib-acpi.c > +++ b/drivers/gpio/gpiolib-acpi.c > @@ -95,10 +95,7 @@ static bool acpi_gpio_deferred_req_irqs_done; > > static int acpi_gpiochip_find(struct gpio_chip *gc, void *data) > { > - if (!gc->parent) > - return false; > - > - return ACPI_HANDLE(gc->parent) == data; > + return gc->parent ? device_match_acpi_handle(gc->parent, data) : false; return gc->parent && device_match_acpi_handle(gc->parent, data); would work too if I'm not mistaken. > } > > /** > --