* [PATCH] i2c: i2c-scmi: Drop unused ACPI_MODULE_NAME definition
@ 2021-03-05 18:28 Rafael J. Wysocki
2021-03-10 14:47 ` Rafael J. Wysocki
2021-03-18 11:12 ` Wolfram Sang
0 siblings, 2 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2021-03-05 18:28 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, Linux ACPI, LKML
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
The ACPI_MODULE_NAME() definition is only used by the message
printing macros from ACPICA that are not used by the code in
question, so it is redundant. Drop it.
No functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/i2c/busses/i2c-scmi.c | 2 --
1 file changed, 2 deletions(-)
Index: linux-pm/drivers/i2c/busses/i2c-scmi.c
===================================================================
--- linux-pm.orig/drivers/i2c/busses/i2c-scmi.c
+++ linux-pm/drivers/i2c/busses/i2c-scmi.c
@@ -18,8 +18,6 @@
/* SMBUS HID definition as supported by Microsoft Windows */
#define ACPI_SMBUS_MS_HID "SMB0001"
-ACPI_MODULE_NAME("smbus_cmi");
-
struct smbus_methods_t {
char *mt_info;
char *mt_sbr;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: i2c-scmi: Drop unused ACPI_MODULE_NAME definition
2021-03-05 18:28 [PATCH] i2c: i2c-scmi: Drop unused ACPI_MODULE_NAME definition Rafael J. Wysocki
@ 2021-03-10 14:47 ` Rafael J. Wysocki
2021-03-10 16:08 ` Wolfram Sang
2021-03-18 11:12 ` Wolfram Sang
1 sibling, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2021-03-10 14:47 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: linux-i2c, Wolfram Sang, Linux ACPI, LKML
On Fri, Mar 5, 2021 at 7:29 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The ACPI_MODULE_NAME() definition is only used by the message
> printing macros from ACPICA that are not used by the code in
> question, so it is redundant. Drop it.
>
> No functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
If there are no concerns regarding this, I'll queue it up for 5.13 in
the ACPI tree, thanks!
> ---
> drivers/i2c/busses/i2c-scmi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: linux-pm/drivers/i2c/busses/i2c-scmi.c
> ===================================================================
> --- linux-pm.orig/drivers/i2c/busses/i2c-scmi.c
> +++ linux-pm/drivers/i2c/busses/i2c-scmi.c
> @@ -18,8 +18,6 @@
> /* SMBUS HID definition as supported by Microsoft Windows */
> #define ACPI_SMBUS_MS_HID "SMB0001"
>
> -ACPI_MODULE_NAME("smbus_cmi");
> -
> struct smbus_methods_t {
> char *mt_info;
> char *mt_sbr;
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: i2c-scmi: Drop unused ACPI_MODULE_NAME definition
2021-03-10 14:47 ` Rafael J. Wysocki
@ 2021-03-10 16:08 ` Wolfram Sang
2021-03-10 16:50 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2021-03-10 16:08 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Rafael J. Wysocki, linux-i2c, Linux ACPI, LKML
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
On Wed, Mar 10, 2021 at 03:47:10PM +0100, Rafael J. Wysocki wrote:
> On Fri, Mar 5, 2021 at 7:29 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > The ACPI_MODULE_NAME() definition is only used by the message
> > printing macros from ACPICA that are not used by the code in
> > question, so it is redundant. Drop it.
> >
> > No functional impact.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> If there are no concerns regarding this, I'll queue it up for 5.13 in
> the ACPI tree, thanks!
I'd prefer the I2C tree a tad to avoid conflicts. Any reason for the
ACPI tree?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: i2c-scmi: Drop unused ACPI_MODULE_NAME definition
2021-03-10 16:08 ` Wolfram Sang
@ 2021-03-10 16:50 ` Rafael J. Wysocki
0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2021-03-10 16:50 UTC (permalink / raw)
To: Wolfram Sang
Cc: Rafael J. Wysocki, Rafael J. Wysocki, linux-i2c, Linux ACPI, LKML
On Wed, Mar 10, 2021 at 5:08 PM Wolfram Sang <wsa@kernel.org> wrote:
>
> On Wed, Mar 10, 2021 at 03:47:10PM +0100, Rafael J. Wysocki wrote:
> > On Fri, Mar 5, 2021 at 7:29 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > >
> > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > >
> > > The ACPI_MODULE_NAME() definition is only used by the message
> > > printing macros from ACPICA that are not used by the code in
> > > question, so it is redundant. Drop it.
> > >
> > > No functional impact.
> > >
> > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > If there are no concerns regarding this, I'll queue it up for 5.13 in
> > the ACPI tree, thanks!
>
> I'd prefer the I2C tree a tad to avoid conflicts. Any reason for the
> ACPI tree?
There are some patches doing this type of a cleanup in the ACPI tree,
but this is the only reason, so please route it through the i2c tree
if that is preferred.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: i2c-scmi: Drop unused ACPI_MODULE_NAME definition
2021-03-05 18:28 [PATCH] i2c: i2c-scmi: Drop unused ACPI_MODULE_NAME definition Rafael J. Wysocki
2021-03-10 14:47 ` Rafael J. Wysocki
@ 2021-03-18 11:12 ` Wolfram Sang
1 sibling, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2021-03-18 11:12 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: linux-i2c, Linux ACPI, LKML
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
On Fri, Mar 05, 2021 at 07:28:30PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The ACPI_MODULE_NAME() definition is only used by the message
> printing macros from ACPICA that are not used by the code in
> question, so it is redundant. Drop it.
>
> No functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-18 11:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 18:28 [PATCH] i2c: i2c-scmi: Drop unused ACPI_MODULE_NAME definition Rafael J. Wysocki
2021-03-10 14:47 ` Rafael J. Wysocki
2021-03-10 16:08 ` Wolfram Sang
2021-03-10 16:50 ` Rafael J. Wysocki
2021-03-18 11:12 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.