All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Jian-Hong Pan <jhp@endlessos.org>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	Chris Chiu <chris.chiu@canonical.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux@endlessos.org
Subject: Re: [PATCH] ACPI / EC: Fix media keys not working problem on more Asus laptops
Date: Mon, 17 May 2021 16:40:13 +0200	[thread overview]
Message-ID: <CAJZ5v0iU15F42yGm5etxmMLsDwC=u7p1eT6EoVADnJnV8+S4VA@mail.gmail.com> (raw)
In-Reply-To: <CAJZ5v0hsNSpL+1ero_+pzz97Xz4UCwjBv7swg+3CAne7_OUKkQ@mail.gmail.com>

On Mon, May 17, 2021 at 4:32 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Tue, May 11, 2021 at 8:40 AM Jian-Hong Pan <jhp@endlessos.org> wrote:
> >
> > From: Chris Chiu <chiu@endlessm.com>
> >
> > More ASUS laptops have the _GPE define in the DSDT table with a
> > different value than the _GPE number in the ECDT.
> >
> > This is causing media keys not working on ASUS X505BA/BP, X542BA/BP
> >
> > Add model info to the quirks list.
> >
> > Signed-off-by: Chris Chiu <chiu@endlessm.com>
> > Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
> > ---
> >  drivers/acpi/ec.c | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> > index 13565629ce0a..e8c5da2b964a 100644
> > --- a/drivers/acpi/ec.c
> > +++ b/drivers/acpi/ec.c
> > @@ -1846,6 +1846,22 @@ static const struct dmi_system_id ec_dmi_table[] __initconst = {
> >         DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> >         DMI_MATCH(DMI_PRODUCT_NAME, "GL702VMK"),}, NULL},
> >         {
> > +       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BA", {
> > +       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > +       DMI_MATCH(DMI_PRODUCT_NAME, "X505BA"),}, NULL},
> > +       {
> > +       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X505BP", {
> > +       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > +       DMI_MATCH(DMI_PRODUCT_NAME, "X505BP"),}, NULL},
> > +       {
> > +       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BA", {
> > +       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > +       DMI_MATCH(DMI_PRODUCT_NAME, "X542BA"),}, NULL},
> > +       {
> > +       ec_honor_ecdt_gpe, "ASUSTeK COMPUTER INC. X542BP", {
> > +       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > +       DMI_MATCH(DMI_PRODUCT_NAME, "X542BP"),}, NULL},
> > +       {
> >         ec_honor_ecdt_gpe, "ASUS X550VXK", {
> >         DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> >         DMI_MATCH(DMI_PRODUCT_NAME, "X550VXK"),}, NULL},
> > --
>
> Applied as 5.14 material under a different subject ("ACPI: EC: Make
> more Asus laptops use ECDT _GPE"), thanks!

And dropped, because the chiu@endlessm.com email address is bouncing.

Please resend with a valid email address in the From: field, thanks!

  reply	other threads:[~2021-05-17 14:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11  6:38 [PATCH] ACPI / EC: Fix media keys not working problem on more Asus laptops Jian-Hong Pan
2021-05-17 14:32 ` Rafael J. Wysocki
2021-05-17 14:40   ` Rafael J. Wysocki [this message]
2021-05-19  3:06     ` [PATCH v2] ACPI: EC: Make more Asus laptops use ECDT _GPE Jian-Hong Pan
2021-05-19  9:53       ` Rafael J. Wysocki
2021-05-19 10:10         ` Chris Chiu
2021-05-20  3:09           ` [PATCH v3] " Jian-Hong Pan
2021-05-21 17:18             ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJZ5v0iU15F42yGm5etxmMLsDwC=u7p1eT6EoVADnJnV8+S4VA@mail.gmail.com' \
    --to=rafael@kernel.org \
    --cc=chris.chiu@canonical.com \
    --cc=jhp@endlessos.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@endlessos.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.