From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EB51C2D0EF for ; Fri, 17 Apr 2020 19:55:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CAEF2078E for ; Fri, 17 Apr 2020 19:55:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587153308; bh=MXkXesSr/2VngDlTo0GDkfmqYvakMDA/xJhToAfs6Tc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=1/n3dyRBHOUzK8oHpauccRyzAZcdiR4NYBkQeB6vzQ0yNPzD7a0ML5xiPb8GVtcdP 7SswdGwJzGxupIWgGUmsnpSMCphKHX/9fCZGvAvpJl4oKJDgHgsvRHkeWGvlMEMLNd wP7L+KfH0m4wGu5PXiM2kMigm7gNdFEhiU882iLw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730667AbgDQTzH convert rfc822-to-8bit (ORCPT ); Fri, 17 Apr 2020 15:55:07 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:35177 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730573AbgDQTzH (ORCPT ); Fri, 17 Apr 2020 15:55:07 -0400 Received: by mail-ot1-f68.google.com with SMTP id e20so2468647otl.2; Fri, 17 Apr 2020 12:55:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=irXuNro8HvnRk+BrWbbABXUvW4MljqIc9AUWoi1f2Eo=; b=Hx40PtklOQjWpRU4woK0+sZwX9lJ18V/yloRjlwhrs9y6/7n25ydy2NPsNpMk7r2Ol mORS1QiQH98RV3R2k4eKZvXV02QKaKfX1gahfecWCv10NdrG2a/BDDSVCrQNTWftVB0a BmlNzyH2H3gfrV6uTfc6rTuo0pxBGnxLo2HHct2ZIxJhfOOkSnxskMmgxylK7MhLOyLb vsepFZczZPihiEwN5MyZV3WM3+duvGBcTIcjxbSjLpWNJrpJxOJ1k4zrdjpdwOtEL2Ri owtrJDvST2KE+Ibdq6XtehnBwc2Ge6oDnVY8WIbG1iX+T/u/DKXFarbtPLEQ1fKrWGJe Ersw== X-Gm-Message-State: AGi0Pua+t8tU7LYNlTfnLEgYaExTqydMvyLcZG7EDG5EmBngYHrVqm40 fCGVCRB8OGkatbJDrudi/GoE/Y/RS0uHc2Oxd78= X-Google-Smtp-Source: APiQypI0BBzCQh563PyRKr+8vxbIskn+ZdpBUycqdaHyYpZErR2AUCMpj2pG/e17Vusf5CRqe6Ug/6dWW7CPyJqTQDA= X-Received: by 2002:a9d:1d07:: with SMTP id m7mr384246otm.167.1587153306213; Fri, 17 Apr 2020 12:55:06 -0700 (PDT) MIME-Version: 1.0 References: <5478a950-4355-8084-ea7d-fe8b270bf2e3@infradead.org> <5392275.BHAU0OPJTB@kreacher> <4b21c095-fbe5-1138-b977-a505baa41a2b@gmx.de> In-Reply-To: From: "Rafael J. Wysocki" Date: Fri, 17 Apr 2020 21:54:54 +0200 Message-ID: Subject: Re: regression 5.6.4->5.6.5 at drivers/acpi/ec.c To: =?UTF-8?Q?Toralf_F=C3=B6rster?= , Greg Kroah-Hartman Cc: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Randy Dunlap , Linux Kernel , ACPI Devel Mailing List , Stable Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Apr 17, 2020 at 9:41 PM Toralf Förster wrote: > > On 4/17/20 8:52 PM, Rafael J. Wysocki wrote: > > On Fri, Apr 17, 2020 at 6:36 PM Toralf Förster wrote: > >> > >> On 4/17/20 5:53 PM, Rafael J. Wysocki wrote: > >>> Does the patch below (untested) make any difference? > >>> > >>> --- > >>> drivers/acpi/ec.c | 5 ++++- > >>> 1 file changed, 4 insertions(+), 1 deletion(-) > >>> > >>> Index: linux-pm/drivers/acpi/ec.c > >>> =================================================================== > >>> --- linux-pm.orig/drivers/acpi/ec.c > >>> +++ linux-pm/drivers/acpi/ec.c > >>> @@ -2067,7 +2067,10 @@ static struct acpi_driver acpi_ec_driver > >>> .add = acpi_ec_add, > >>> .remove = acpi_ec_remove, > >>> }, > >>> - .drv.pm = &acpi_ec_pm, > >>> + .drv = { > >>> + .probe_type = PROBE_FORCE_SYNCHRONOUS, > >>> + .pm = &acpi_ec_pm, > >>> + }, > >>> }; > >>> > >>> static void acpi_ec_destroy_workqueues(void) > >> I'd say no, but for completeness: > > > > OK, it looks like mainline commit > > > > 65a691f5f8f0 ("ACPI: EC: Do not clear boot_ec_is_ecdt in acpi_ec_add()") > > > > was backported into 5.6.5 by mistake. > > > > Can you please revert that patch and retest? > > > Yes, reverting that commit solved the issue. OK, thanks! Greg, I'm not sure why commit 65a691f5f8f0 from the mainline ended up in 5.6.5. It has not been marked for -stable or otherwise requested to be included AFAICS. Also it depends on other mainline commits that have not been included into 5.6.5. Can you please drop it?