From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73112C433DF for ; Tue, 30 Jun 2020 13:00:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51ED9206EB for ; Tue, 30 Jun 2020 13:00:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593522049; bh=gM0irjghrH8cc5OMtaevMb0DpG9WQfoprM7amJWpVkY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=zCiCXuOB/2rxWMiMp0btuL/dG9IwyWtxGjQIS47PayA4ZdfPBtrvTXYokZv5+mHb8 Rgtl36OF6NekAtRNTIYWOkevULZze7I6eZ9kti3cTQ0+OnrqCGQqpFVHOqKwyjR1Ie Dy+hooKNMLRzc/Q4W1N152D7METTpT5I8kLAapG4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387986AbgF3NAs (ORCPT ); Tue, 30 Jun 2020 09:00:48 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:35058 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387860AbgF3NAr (ORCPT ); Tue, 30 Jun 2020 09:00:47 -0400 Received: by mail-ot1-f65.google.com with SMTP id d4so18322175otk.2; Tue, 30 Jun 2020 06:00:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WqwbwU46JyOBSJ4M/llFeE1rugAXIYDl6Af9czQJBYA=; b=jDFgAAuJGqYlbU3fXLv/gMLOuQAgYysSgZSbE6LepFkZOT3HfO8Qp2g512nitXF8WU tNL8LbHaLiHWlMgAIIEiCFaAfI6TO/0L9EiHmYLaWoh6gUj1VLFDDvC/aVPiU86eNlzD NWuurDaD4xa5PQzaFP/bfg4nNL2GJTW09ssxbhRplYCxZikO+6H75j0Q9MwIUq3s7Htc 4poFgdVtWsWy2dxLNFi6TDz4/vaAgL/rDpMso6eUUDfCVbFWLEmmN4fwK2mXrNcX1GAz TmOlI6aWtq66iOgYRYYrpAN6RfUx0CbUwNnQzncJs2/WFMTdR7vaJX1ol8Fe6gG6vJfL Xl/Q== X-Gm-Message-State: AOAM530oW9yWTHcFvY2+YKQ5T4QFA6QisDf0aqqI//cEwLhdIuchj9vF uMDPD/AqqOnGSb60rDvQSvEjZVIcv4Khfs7w0b45kg== X-Google-Smtp-Source: ABdhPJxcZHXFcqosLW4f6iGFDsj3uWlS9K4nihvXh0uIED4aD7noF+010OtlL0o8ZeIfLr5tSucG2WE3CDKvAel9ATU= X-Received: by 2002:a9d:39f5:: with SMTP id y108mr17985171otb.262.1593522045805; Tue, 30 Jun 2020 06:00:45 -0700 (PDT) MIME-Version: 1.0 References: <20200630044943.3425049-1-rajatja@google.com> <20200630044943.3425049-6-rajatja@google.com> <20200630104948.GC856968@kuha.fi.intel.com> <20200630125216.GA1109228@kroah.com> In-Reply-To: <20200630125216.GA1109228@kroah.com> From: "Rafael J. Wysocki" Date: Tue, 30 Jun 2020 15:00:34 +0200 Message-ID: Subject: Re: [PATCH v2 5/7] driver core: Add device location to "struct device" and expose it in sysfs To: Greg Kroah-Hartman , Rajat Jain Cc: Heikki Krogerus , David Woodhouse , Lu Baolu , Joerg Roedel , Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown , "open list:AMD IOMMU (AMD-VI)" , Linux Kernel Mailing List , Linux PCI , ACPI Devel Maling List , Raj Ashok , lalithambika.krishnakumar@intel.com, Mika Westerberg , Jean-Philippe Brucker , Prashant Malani , Benson Leung , Todd Broch , Alex Levin , Mattias Nissler , Rajat Jain , Bernie Keany , Aaron Durbin , Diego Rivas , Duncan Laurie , Furquan Shaikh , Jesse Barnes , Christian Kellner , Alex Williamson , "Oliver O'Halloran" , Saravana Kannan , Suzuki K Poulose , Arnd Bergmann Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Jun 30, 2020 at 2:52 PM Greg Kroah-Hartman wrote: > > On Tue, Jun 30, 2020 at 01:49:48PM +0300, Heikki Krogerus wrote: > > On Mon, Jun 29, 2020 at 09:49:41PM -0700, Rajat Jain wrote: > > > Add a new (optional) field to denote the physical location of a device > > > in the system, and expose it in sysfs. This was discussed here: > > > https://lore.kernel.org/linux-acpi/20200618184621.GA446639@kroah.com/ > > > > > > (The primary choice for attribute name i.e. "location" is already > > > exposed as an ABI elsewhere, so settled for "site"). Individual buses > > > that want to support this new attribute can opt-in by setting a flag in > > > bus_type, and then populating the location of device while enumerating > > > it. > > > > So why not just call it "physical_location"? > > That's better, and will allow us to put "3rd blue plug from the left, > 4th row down" in there someday :) > > All of this is "relative" to the CPU, right? But what CPU? Again, how > are the systems with drawers of PCI and CPUs and memory that can be > added/removed at any point in time being handled here? What is > "internal" and "external" for them? > > What exactly is the physical boundry here that is attempting to be > described? Also, where is the "physical location" information going to come from? If that is the platform firmware (which I suspect is the anticipated case), there may be problems with reliability related to that. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0F4FC433DF for ; Tue, 30 Jun 2020 13:00:51 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFB70206B6 for ; Tue, 30 Jun 2020 13:00:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFB70206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 8B77322B7A; Tue, 30 Jun 2020 13:00:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rGhXVeH5JCiX; Tue, 30 Jun 2020 13:00:50 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id D56E722926; Tue, 30 Jun 2020 13:00:50 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B9714C088F; Tue, 30 Jun 2020 13:00:50 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id CFB51C016E for ; Tue, 30 Jun 2020 13:00:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id BCEBE86D04 for ; Tue, 30 Jun 2020 13:00:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D6Aty9pHG2Is for ; Tue, 30 Jun 2020 13:00:47 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 90A1886935 for ; Tue, 30 Jun 2020 13:00:47 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id n6so18342750otl.0 for ; Tue, 30 Jun 2020 06:00:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WqwbwU46JyOBSJ4M/llFeE1rugAXIYDl6Af9czQJBYA=; b=t2hNva0+6NG40I7u/F/FTlJSZwhWrdjkJFAIEekQ1pjXY3DnoUYQvSh4HLKk4c+bj4 7sY7IOEx6aP8GKCkzTWWiy24v+cXbBXmeqD7zKJXp7n8dKpmeRMwa7A/fp2ycQ+hA2eT QfQ+B0ufuaaSGJ6RSOHfDJOTAAHKHjx8YSUqXaL3pEiQJ9O+/piuw/2vfEqQiI0GUp3+ wp5aZrEFbJhWigOKF6R574ZkBGtNEbOxPogGEpQyZt0dlNkd982PQF8tdPwm3nXrJu4S 1AOMfZ7CUH78ou7i/cEacJs9GNTmfqzKUVzTuyksER3LNmF9bp0PtD25N+UJ1jYaQYed NSgg== X-Gm-Message-State: AOAM531+sbnIQGh8jZiKVtmGp57ftzvEJiJDftYJ8Z4dFLhc7dDYQtP3 cv5MvATUZ1/bquyKQNqnEqGjnFjGTLWnxEwKcSI= X-Google-Smtp-Source: ABdhPJxcZHXFcqosLW4f6iGFDsj3uWlS9K4nihvXh0uIED4aD7noF+010OtlL0o8ZeIfLr5tSucG2WE3CDKvAel9ATU= X-Received: by 2002:a9d:39f5:: with SMTP id y108mr17985171otb.262.1593522045805; Tue, 30 Jun 2020 06:00:45 -0700 (PDT) MIME-Version: 1.0 References: <20200630044943.3425049-1-rajatja@google.com> <20200630044943.3425049-6-rajatja@google.com> <20200630104948.GC856968@kuha.fi.intel.com> <20200630125216.GA1109228@kroah.com> In-Reply-To: <20200630125216.GA1109228@kroah.com> From: "Rafael J. Wysocki" Date: Tue, 30 Jun 2020 15:00:34 +0200 Message-ID: Subject: Re: [PATCH v2 5/7] driver core: Add device location to "struct device" and expose it in sysfs To: Greg Kroah-Hartman , Rajat Jain Cc: Heikki Krogerus , Linux PCI , lalithambika.krishnakumar@intel.com, Todd Broch , Diego Rivas , Jean-Philippe Brucker , Furquan Shaikh , Raj Ashok , Saravana Kannan , ACPI Devel Maling List , Christian Kellner , Mattias Nissler , Jesse Barnes , Len Brown , Rajat Jain , Prashant Malani , Suzuki K Poulose , Aaron Durbin , Alex Williamson , Bjorn Helgaas , Mika Westerberg , Bernie Keany , Duncan Laurie , "Rafael J. Wysocki" , Linux Kernel Mailing List , "open list:AMD IOMMU \(AMD-VI\)" , Arnd Bergmann , Oliver O'Halloran , Benson Leung , David Woodhouse , Alex Levin X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Jun 30, 2020 at 2:52 PM Greg Kroah-Hartman wrote: > > On Tue, Jun 30, 2020 at 01:49:48PM +0300, Heikki Krogerus wrote: > > On Mon, Jun 29, 2020 at 09:49:41PM -0700, Rajat Jain wrote: > > > Add a new (optional) field to denote the physical location of a device > > > in the system, and expose it in sysfs. This was discussed here: > > > https://lore.kernel.org/linux-acpi/20200618184621.GA446639@kroah.com/ > > > > > > (The primary choice for attribute name i.e. "location" is already > > > exposed as an ABI elsewhere, so settled for "site"). Individual buses > > > that want to support this new attribute can opt-in by setting a flag in > > > bus_type, and then populating the location of device while enumerating > > > it. > > > > So why not just call it "physical_location"? > > That's better, and will allow us to put "3rd blue plug from the left, > 4th row down" in there someday :) > > All of this is "relative" to the CPU, right? But what CPU? Again, how > are the systems with drawers of PCI and CPUs and memory that can be > added/removed at any point in time being handled here? What is > "internal" and "external" for them? > > What exactly is the physical boundry here that is attempting to be > described? Also, where is the "physical location" information going to come from? If that is the platform firmware (which I suspect is the anticipated case), there may be problems with reliability related to that. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu