From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B825C433EF for ; Tue, 17 May 2022 15:46:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350450AbiEQPqc (ORCPT ); Tue, 17 May 2022 11:46:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350954AbiEQPqS (ORCPT ); Tue, 17 May 2022 11:46:18 -0400 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAB1BDCD; Tue, 17 May 2022 08:45:59 -0700 (PDT) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-2fedd26615cso79230487b3.7; Tue, 17 May 2022 08:45:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YYWNzMuuewxR1SV/ukbRTxfo/sdpKRPPvAFXL4eruR8=; b=6XqMOD8uig4GB0Zemf0k0haKksXwhLBiIE8SA18r80Z3ssHwQqnybXwg1GszlAQwR1 L6rAua2PC3iq2lBO2ZWMQVEQYwh4fMc244dVv4QF+Zqe1NHR8Bew42T+AvlA5W2lxE5G +bx2dyrtPCWBXbYcvpEMYrsDQswgMWPKUSp7wkgS+q0yx4j7Ykpie9f8486pVIlg2+Ff tEDRx4LYqTasZtWpWg9wOBUUtTVZQ49ih13QA3AbgAY21Pxd1p8O14O4nZ9gaN+lq8zN qryzsKC2HJlib5tcBDhrgSVwAh0ZD7weMxjgGKHaEUW6gVEClbyzsOlv2bnfOe5u2VTt YoVQ== X-Gm-Message-State: AOAM532x5t3PcW5P5IxchrKKSgIO9aMHO4nfRmHVBFNYCWmJOKpljgfe XFSvLvOGtm594a7EhgPmO1i3FrlVijrtSCPvZaV8hk6u X-Google-Smtp-Source: ABdhPJyZF4TFOOHUnKIQbbE6OWyLZ7lurMBsWJS+zPoAHDBvBWAUU9dMN0H3v61AiA1KxsbQ2EKFYjLAckJbsa6oFc8= X-Received: by 2002:a0d:c5c7:0:b0:2fe:e955:2c45 with SMTP id h190-20020a0dc5c7000000b002fee9552c45mr14037451ywd.19.1652802359160; Tue, 17 May 2022 08:45:59 -0700 (PDT) MIME-Version: 1.0 References: <20220507125443.2766939-1-daniel.lezcano@linexp.org> <20220507125443.2766939-4-daniel.lezcano@linexp.org> In-Reply-To: <20220507125443.2766939-4-daniel.lezcano@linexp.org> From: "Rafael J. Wysocki" Date: Tue, 17 May 2022 17:45:48 +0200 Message-ID: Subject: Re: [PATCH v2 03/14] thermal/core: Remove duplicate information when an error occurs To: Daniel Lezcano Cc: Daniel Lezcano , "Rafael J. Wysocki" , Kevin Hilman , Alexandre Bailon , Linux PM , Linux Kernel Mailing List , Amit Kucheria , Zhang Rui Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 7, 2022 at 2:55 PM Daniel Lezcano wrote: > > The pr_err already tells it is an error, it is pointless to add the > 'Error:' string in the messages. Remove them. > > Cc: Alexandre Bailon > Cc: Kevin Hilman > Cc; Eduardo Valentin > Signed-off-by: Daniel Lezcano > --- > drivers/thermal/thermal_core.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c > index 1a405854748a..dc5a03d51f5c 100644 > --- a/drivers/thermal/thermal_core.c > +++ b/drivers/thermal/thermal_core.c > @@ -1197,23 +1197,23 @@ thermal_zone_device_register(const char *type, int trips, int mask, > struct thermal_governor *governor; > > if (!type || strlen(type) == 0) { > - pr_err("Error: No thermal zone type defined\n"); > + pr_err("No thermal zone type defined\n"); > return ERR_PTR(-EINVAL); > } > > if (type && strlen(type) >= THERMAL_NAME_LENGTH) { > - pr_err("Error: Thermal zone name (%s) too long, should be under %d chars\n", > + pr_err("Thermal zone name (%s) too long, should be under %d chars\n", > type, THERMAL_NAME_LENGTH); > return ERR_PTR(-EINVAL); > } > > if (trips > THERMAL_MAX_TRIPS || trips < 0 || mask >> trips) { > - pr_err("Error: Incorrect number of thermal trips\n"); > + pr_err("Incorrect number of thermal trips\n"); > return ERR_PTR(-EINVAL); > } > > if (!ops) { > - pr_err("Error: Thermal zone device ops not defined\n"); > + pr_err("Thermal zone device ops not defined\n"); > return ERR_PTR(-EINVAL); > } > > -- Do these need to be pr_err() messages at all? They all seem to be debug-type messages regarding thermal zone drivers.