All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ACPI: APEI: Add BERT error log footer
@ 2022-08-24 13:01 Dmitry Monakhov
  2022-09-03 18:26 ` Rafael J. Wysocki
  0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Monakhov @ 2022-08-24 13:01 UTC (permalink / raw)
  To: linux-acpi; +Cc: tony.luck, rafael, Dmitry Monakhov

Print total number of records found during BERT log parsing.
This also simplify dmesg parser implementation for BERT events.

Signed-off-by: Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>

diff --git a/drivers/acpi/apei/bert.c b/drivers/acpi/apei/bert.c
index 45973aa6e06d..c23eb75866d0 100644
--- a/drivers/acpi/apei/bert.c
+++ b/drivers/acpi/apei/bert.c
@@ -90,6 +90,9 @@ static void __init bert_print_all(struct acpi_bert_region *region,
 
 	if (skipped)
 		pr_info(HW_ERR "Skipped %d error records\n", skipped);
+
+	if (printed + skipped)
+		pr_info("Total records found: %d\n", printed + skipped);
 }
 
 static int __init setup_bert_disable(char *str)
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] ACPI: APEI: Add BERT error log footer
  2022-08-24 13:01 [PATCH] ACPI: APEI: Add BERT error log footer Dmitry Monakhov
@ 2022-09-03 18:26 ` Rafael J. Wysocki
  0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2022-09-03 18:26 UTC (permalink / raw)
  To: Dmitry Monakhov; +Cc: ACPI Devel Maling List, Tony Luck, Rafael J. Wysocki

On Wed, Aug 24, 2022 at 3:02 PM Dmitry Monakhov
<dmtrmonakhov@yandex-team.ru> wrote:
>
> Print total number of records found during BERT log parsing.
> This also simplify dmesg parser implementation for BERT events.
>
> Signed-off-by: Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>
>
> diff --git a/drivers/acpi/apei/bert.c b/drivers/acpi/apei/bert.c
> index 45973aa6e06d..c23eb75866d0 100644
> --- a/drivers/acpi/apei/bert.c
> +++ b/drivers/acpi/apei/bert.c
> @@ -90,6 +90,9 @@ static void __init bert_print_all(struct acpi_bert_region *region,
>
>         if (skipped)
>                 pr_info(HW_ERR "Skipped %d error records\n", skipped);
> +
> +       if (printed + skipped)
> +               pr_info("Total records found: %d\n", printed + skipped);
>  }
>
>  static int __init setup_bert_disable(char *str)
> --

Applied as 6.1 material with an ACK from Tony.

Thanks!

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] ACPI: APEI: Add bert error log footer
  2022-08-23 16:29 ` Rafael J. Wysocki
@ 2022-08-23 16:37   ` Luck, Tony
  0 siblings, 0 replies; 5+ messages in thread
From: Luck, Tony @ 2022-08-23 16:37 UTC (permalink / raw)
  To: Rafael J. Wysocki, Dmitry Monakhov; +Cc: ACPI Devel Maling List

> +       if (printed + skipped)
> +               pr_info("Total records found: %d\n", printed + skipped);

Concept seems fine. So with the s/bert/BERT/ changes in subject and body.

Acked-by: Tony Luck <tony.luck@intel.com>

-Tony

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ACPI: APEI: Add bert error log footer
  2022-08-15  9:14 [PATCH] ACPI: APEI: Add bert " Dmitry Monakhov
@ 2022-08-23 16:29 ` Rafael J. Wysocki
  2022-08-23 16:37   ` Luck, Tony
  0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2022-08-23 16:29 UTC (permalink / raw)
  To: Dmitry Monakhov; +Cc: ACPI Devel Maling List, Tony Luck

On Mon, Aug 15, 2022 at 11:22 AM Dmitry Monakhov
<dmtrmonakhov@yandex-team.ru> wrote:
>
> Print total number of records found during bert log parsing.

Please spell BERT in capitals everywhere, including the subject.

> This also simplify dmesg parser implementation for bert events.
>
> Signed-off-by: Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>
>
> diff --git a/drivers/acpi/apei/bert.c b/drivers/acpi/apei/bert.c
> index 45973aa6e06d..c23eb75866d0 100644
> --- a/drivers/acpi/apei/bert.c
> +++ b/drivers/acpi/apei/bert.c
> @@ -90,6 +90,9 @@ static void __init bert_print_all(struct acpi_bert_region *region,
>
>         if (skipped)
>                 pr_info(HW_ERR "Skipped %d error records\n", skipped);
> +
> +       if (printed + skipped)
> +               pr_info("Total records found: %d\n", printed + skipped);
>  }
>
>  static int __init setup_bert_disable(char *str)
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ACPI: APEI: Add bert error log footer
@ 2022-08-15  9:14 Dmitry Monakhov
  2022-08-23 16:29 ` Rafael J. Wysocki
  0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Monakhov @ 2022-08-15  9:14 UTC (permalink / raw)
  To: linux-acpi; +Cc: tony.luck, Dmitry Monakhov

Print total number of records found during bert log parsing.
This also simplify dmesg parser implementation for bert events.

Signed-off-by: Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>

diff --git a/drivers/acpi/apei/bert.c b/drivers/acpi/apei/bert.c
index 45973aa6e06d..c23eb75866d0 100644
--- a/drivers/acpi/apei/bert.c
+++ b/drivers/acpi/apei/bert.c
@@ -90,6 +90,9 @@ static void __init bert_print_all(struct acpi_bert_region *region,
 
 	if (skipped)
 		pr_info(HW_ERR "Skipped %d error records\n", skipped);
+
+	if (printed + skipped)
+		pr_info("Total records found: %d\n", printed + skipped);
 }
 
 static int __init setup_bert_disable(char *str)
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-09-03 18:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-24 13:01 [PATCH] ACPI: APEI: Add BERT error log footer Dmitry Monakhov
2022-09-03 18:26 ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2022-08-15  9:14 [PATCH] ACPI: APEI: Add bert " Dmitry Monakhov
2022-08-23 16:29 ` Rafael J. Wysocki
2022-08-23 16:37   ` Luck, Tony

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.