From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE83FC433DB for ; Thu, 28 Jan 2021 12:02:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C42864DDB for ; Thu, 28 Jan 2021 12:02:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229908AbhA1MCK (ORCPT ); Thu, 28 Jan 2021 07:02:10 -0500 Received: from mail-ot1-f47.google.com ([209.85.210.47]:34380 "EHLO mail-ot1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231467AbhA1MBd (ORCPT ); Thu, 28 Jan 2021 07:01:33 -0500 Received: by mail-ot1-f47.google.com with SMTP id a109so4921098otc.1; Thu, 28 Jan 2021 04:01:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YFd+ePX8uVw6q9k4sjKVG2onbgLoQUdjhM3fDLy+Btw=; b=LKAWVBS4m/h6/48Dn7N3w/0wd/2/YrXf3YGyPnTCTcha00mJP7Bcd7j0kSVCxIlT1a nRFIRNFxyLbsSFE1bIT9E6R9RfRE7Ix+IkidxlxQidzV63n//jEn7JK2dOYUPYXuVNrx 4346xc/BYZWanIKx34Gua+023jjAl8+GnV2eGbNp45x4NIPODrXb+SlG+mQ1VBNe10q3 9JeQJ0cI0kiuFN5ygg7dL5JMWfNVcCCVhqJ8FL9HtpoZ04zafFjdCpS2DxHeY0YYC3zR UYAKxHRuBfPUsJ3BjyAQSHy3UchLkW4+UDe5YZLud5VJV7vgoDk5RqgIbSozJUiK4v99 KO8w== X-Gm-Message-State: AOAM531WQHwOAHnXHH+l80TuECAHVajGLwz9Dy6O7jQ2nLfXvqSiOsUq EIoTjc1NkZoADqscNK7YHWNL92mg1xZLgmgNTe0= X-Google-Smtp-Source: ABdhPJzw7uAHH10wT+hfkmC7l6BXx19Gtl05Ag3LL5T55Scni979vNQ+rXgR5Evx5NIc8UxTLZi8I+qmU3q2QMTkMfc= X-Received: by 2002:a9d:7a4a:: with SMTP id z10mr11396877otm.206.1611835251636; Thu, 28 Jan 2021 04:00:51 -0800 (PST) MIME-Version: 1.0 References: <20210122154300.7628-1-calvin.johnson@oss.nxp.com> <20210122154300.7628-2-calvin.johnson@oss.nxp.com> <20210128112729.GA28413@lsv03152.swis.in-blr01.nxp.com> In-Reply-To: <20210128112729.GA28413@lsv03152.swis.in-blr01.nxp.com> From: "Rafael J. Wysocki" Date: Thu, 28 Jan 2021 13:00:40 +0100 Message-ID: Subject: Re: [net-next PATCH v4 01/15] Documentation: ACPI: DSD: Document MDIO PHY To: Calvin Johnson Cc: "Rafael J. Wysocki" , Grant Likely , Jeremy Linton , Andrew Lunn , Andy Shevchenko , Florian Fainelli , Russell King - ARM Linux admin , Cristi Sovaiala , Florin Laurentiu Chiculita , Ioana Ciornei , Madalin Bucur , Heikki Krogerus , Marcin Wojtas , Pieter Jansen Van Vuuren , Jon , Saravana Kannan , Randy Dunlap , "linux.cj" , Diana Madalina Craciun , ACPI Devel Maling List , Linux ARM , Linux Kernel Mailing List , netdev , Laurentiu Tudor , Len Brown , "Rafael J. Wysocki" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Jan 28, 2021 at 12:27 PM Calvin Johnson wrote: > > Hi Rafael, > > Thanks for the review. I'll work on all the comments. > > On Fri, Jan 22, 2021 at 08:22:21PM +0100, Rafael J. Wysocki wrote: > > On Fri, Jan 22, 2021 at 4:43 PM Calvin Johnson > > wrote: > > > > > > Introduce ACPI mechanism to get PHYs registered on a MDIO bus and > > > provide them to be connected to MAC. > > > > > > Describe properties "phy-handle" and "phy-mode". > > > > > > Signed-off-by: Calvin Johnson > > > --- > > > > > > Changes in v4: > > > - More cleanup > > > > This looks much better that the previous versions IMV, some nits below. > > > > > Changes in v3: None > > > Changes in v2: > > > - Updated with more description in document > > > > > > Documentation/firmware-guide/acpi/dsd/phy.rst | 129 ++++++++++++++++++ > > > 1 file changed, 129 insertions(+) > > > create mode 100644 Documentation/firmware-guide/acpi/dsd/phy.rst > > > > > > diff --git a/Documentation/firmware-guide/acpi/dsd/phy.rst b/Documentation/firmware-guide/acpi/dsd/phy.rst > > > new file mode 100644 > > > index 000000000000..76fca994bc99 > > > --- /dev/null > > > +++ b/Documentation/firmware-guide/acpi/dsd/phy.rst > > > @@ -0,0 +1,129 @@ > > > +.. SPDX-License-Identifier: GPL-2.0 > > > + > > > +========================= > > > +MDIO bus and PHYs in ACPI > > > +========================= > > > + > > > +The PHYs on an MDIO bus [1] are probed and registered using > > > +fwnode_mdiobus_register_phy(). > > > > Empty line here, please. > > > > > +Later, for connecting these PHYs to MAC, the PHYs registered on the > > > +MDIO bus have to be referenced. > > > + > > > +The UUID given below should be used as mentioned in the "Device Properties > > > +UUID For _DSD" [2] document. > > > + - UUID: daffd814-6eba-4d8c-8a91-bc9bbf4aa301 > > > > I would drop the above paragraph. > > > > > + > > > +This document introduces two _DSD properties that are to be used > > > +for PHYs on the MDIO bus.[3] > > > > I'd say "for connecting PHYs on the MDIO bus [3] to the MAC layer." > > above and add the following here: > > > > "These properties are defined in accordance with the "Device > > Properties UUID For _DSD" [2] document and the > > daffd814-6eba-4d8c-8a91-bc9bbf4aa301 UUID must be used in the Device > > Data Descriptors containing them." > > > > > + > > > +phy-handle > > > +---------- > > > +For each MAC node, a device property "phy-handle" is used to reference > > > +the PHY that is registered on an MDIO bus. This is mandatory for > > > +network interfaces that have PHYs connected to MAC via MDIO bus. > > > + > > > +During the MDIO bus driver initialization, PHYs on this bus are probed > > > +using the _ADR object as shown below and are registered on the MDIO bus. > > > > Do you want to mention the "reg" property here? I think it would be > > useful to do that. > > No. I think we should adhere to _ADR in MDIO case. The "reg" property for ACPI > may be useful for other use cases that Andy is aware of. The code should reflect this, then. I mean it sounds like you want to check the "reg" property only if this is a non-ACPI node. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD401C433DB for ; Thu, 28 Jan 2021 12:02:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F7E361492 for ; Thu, 28 Jan 2021 12:02:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F7E361492 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wXev0AXBT/yRsvEh2xCZllq4k+CPbwTjtLfv35jtQLs=; b=NlEKxFOkGq2lE6UTkfOUJrHwu YSR5VkzU+1toPUolrhoV+MgzgljexHH5aVsyV4uIjU6iv8myGkgGtvwuj0PBR0eCs/XG7dPH/EiLt L/+xzv/fblCfjYUH0A/LdYWJIvXDaa+iVD/LO7wFhD2+M7B2D/lodd0iFaeX5SkZxA/5gVFJh72ZB fbrE1R5F8P2emDpxcmtI4W0BtmnujltijBYFt8wMrvxhxgMWzDQempe+68JY9XwXBGsrn7Kzc4uOD Eu9jNebbAxBtk1XYAryinCceZYQjiwemaOjib/ZOhO6e6eWrrK4cPK01rmqd6IEarLtAz3NnF1evR da8+Pmn7Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l55yo-0006iU-GO; Thu, 28 Jan 2021 12:00:54 +0000 Received: from mail-ot1-f41.google.com ([209.85.210.41]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l55ym-0006hk-I4 for linux-arm-kernel@lists.infradead.org; Thu, 28 Jan 2021 12:00:53 +0000 Received: by mail-ot1-f41.google.com with SMTP id s2so4904329otp.5 for ; Thu, 28 Jan 2021 04:00:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YFd+ePX8uVw6q9k4sjKVG2onbgLoQUdjhM3fDLy+Btw=; b=hiywsrqymmvcWKT8viEnLydgLqkZdLq4Q+oKcJxTrJWtiWQCULn5HrYYrqGpN9XtzC tEjkv9f9ZWZlKSnQwyLO1FX+Hpux6MG08WltW8h22teJa/vQ3OuWom8bCMF8CuhEhs2S 5Dh4WOzLdoqwmhbPFhTP2Qq5Iltjf2LHBWSgAE8fPfa4TpB3Z4jKPG9aR8t2k0lYvS+g R+M8HLwTrG+35/qzyOfnJMP2DfQtwyGrWD+C9M0LEQUTe/RtvsKQ5xkRN97tg1daLVHZ 9t0Uhafd9gAJcWSMtPdF3ZSfQfvxcswS6gAYGrHDcY4cFl/ARZZ9nrOknIHVEOjFMO0c bzXA== X-Gm-Message-State: AOAM530jcWWqBGQsjUYY2/4+SectDG6nJTY4/ZbAs1+t1GusSvPPVkqM YA83dhXr7mVD6ZJEF854bwcyA3StYdBgeZIYEcI= X-Google-Smtp-Source: ABdhPJzw7uAHH10wT+hfkmC7l6BXx19Gtl05Ag3LL5T55Scni979vNQ+rXgR5Evx5NIc8UxTLZi8I+qmU3q2QMTkMfc= X-Received: by 2002:a9d:7a4a:: with SMTP id z10mr11396877otm.206.1611835251636; Thu, 28 Jan 2021 04:00:51 -0800 (PST) MIME-Version: 1.0 References: <20210122154300.7628-1-calvin.johnson@oss.nxp.com> <20210122154300.7628-2-calvin.johnson@oss.nxp.com> <20210128112729.GA28413@lsv03152.swis.in-blr01.nxp.com> In-Reply-To: <20210128112729.GA28413@lsv03152.swis.in-blr01.nxp.com> From: "Rafael J. Wysocki" Date: Thu, 28 Jan 2021 13:00:40 +0100 Message-ID: Subject: Re: [net-next PATCH v4 01/15] Documentation: ACPI: DSD: Document MDIO PHY To: Calvin Johnson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210128_070052_720833_25EAF5C7 X-CRM114-Status: GOOD ( 32.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Heikki Krogerus , "Rafael J. Wysocki" , Grant Likely , Ioana Ciornei , Florian Fainelli , Saravana Kannan , Jon , Russell King - ARM Linux admin , Diana Madalina Craciun , ACPI Devel Maling List , Andy Shevchenko , Laurentiu Tudor , Len Brown , Madalin Bucur , Pieter Jansen Van Vuuren , Marcin Wojtas , Linux ARM , Florin Laurentiu Chiculita , netdev , Randy Dunlap , "Rafael J. Wysocki" , Linux Kernel Mailing List , Jeremy Linton , Cristi Sovaiala , "linux.cj" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 28, 2021 at 12:27 PM Calvin Johnson wrote: > > Hi Rafael, > > Thanks for the review. I'll work on all the comments. > > On Fri, Jan 22, 2021 at 08:22:21PM +0100, Rafael J. Wysocki wrote: > > On Fri, Jan 22, 2021 at 4:43 PM Calvin Johnson > > wrote: > > > > > > Introduce ACPI mechanism to get PHYs registered on a MDIO bus and > > > provide them to be connected to MAC. > > > > > > Describe properties "phy-handle" and "phy-mode". > > > > > > Signed-off-by: Calvin Johnson > > > --- > > > > > > Changes in v4: > > > - More cleanup > > > > This looks much better that the previous versions IMV, some nits below. > > > > > Changes in v3: None > > > Changes in v2: > > > - Updated with more description in document > > > > > > Documentation/firmware-guide/acpi/dsd/phy.rst | 129 ++++++++++++++++++ > > > 1 file changed, 129 insertions(+) > > > create mode 100644 Documentation/firmware-guide/acpi/dsd/phy.rst > > > > > > diff --git a/Documentation/firmware-guide/acpi/dsd/phy.rst b/Documentation/firmware-guide/acpi/dsd/phy.rst > > > new file mode 100644 > > > index 000000000000..76fca994bc99 > > > --- /dev/null > > > +++ b/Documentation/firmware-guide/acpi/dsd/phy.rst > > > @@ -0,0 +1,129 @@ > > > +.. SPDX-License-Identifier: GPL-2.0 > > > + > > > +========================= > > > +MDIO bus and PHYs in ACPI > > > +========================= > > > + > > > +The PHYs on an MDIO bus [1] are probed and registered using > > > +fwnode_mdiobus_register_phy(). > > > > Empty line here, please. > > > > > +Later, for connecting these PHYs to MAC, the PHYs registered on the > > > +MDIO bus have to be referenced. > > > + > > > +The UUID given below should be used as mentioned in the "Device Properties > > > +UUID For _DSD" [2] document. > > > + - UUID: daffd814-6eba-4d8c-8a91-bc9bbf4aa301 > > > > I would drop the above paragraph. > > > > > + > > > +This document introduces two _DSD properties that are to be used > > > +for PHYs on the MDIO bus.[3] > > > > I'd say "for connecting PHYs on the MDIO bus [3] to the MAC layer." > > above and add the following here: > > > > "These properties are defined in accordance with the "Device > > Properties UUID For _DSD" [2] document and the > > daffd814-6eba-4d8c-8a91-bc9bbf4aa301 UUID must be used in the Device > > Data Descriptors containing them." > > > > > + > > > +phy-handle > > > +---------- > > > +For each MAC node, a device property "phy-handle" is used to reference > > > +the PHY that is registered on an MDIO bus. This is mandatory for > > > +network interfaces that have PHYs connected to MAC via MDIO bus. > > > + > > > +During the MDIO bus driver initialization, PHYs on this bus are probed > > > +using the _ADR object as shown below and are registered on the MDIO bus. > > > > Do you want to mention the "reg" property here? I think it would be > > useful to do that. > > No. I think we should adhere to _ADR in MDIO case. The "reg" property for ACPI > may be useful for other use cases that Andy is aware of. The code should reflect this, then. I mean it sounds like you want to check the "reg" property only if this is a non-ACPI node. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel