From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Chen Yu <yu.c.chen@intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][v3] cpufreq: intel_pstate: Get percpu max freq via HWP MSR register if available
Date: Tue, 12 Jan 2021 19:46:31 +0100 [thread overview]
Message-ID: <CAJZ5v0igG=kyL7zFrvCLcMAE7uLzaB-MC8fZBxBX17WNTpR5Cg@mail.gmail.com> (raw)
In-Reply-To: <20210112150340.GA17152@chenyu-office.sh.intel.com>
On Tue, Jan 12, 2021 at 4:00 PM Chen Yu <yu.c.chen@intel.com> wrote:
>
> On Tue, Jan 12, 2021 at 02:52:50PM +0100, Rafael J. Wysocki wrote:
> > On Tue, Jan 12, 2021 at 6:19 AM Chen Yu <yu.c.chen@intel.com> wrote:
> > >
> > > Currently when turbo is disabled(either by BIOS or by the user), the
> > > intel_pstate driver reads the max non-turbo frequency from the package-wide
> > > MSR_PLATFORM_INFO(0xce) register. However on asymmetric platforms it is
> > > possible in theory that small and big core with HWP enabled might have
> > > different max non-turbo cpu frequency, because the MSR_HWP_CAPABILITIES
> > > is percpu scope according to Intel Software Developer Manual.
> > >
> > > The turbo max freq is already percpu basis in current code, thus make
> > > similar change to the max non-turbo frequency as well.
> > >
> > > Reported-by: Wendy Wang <wendy.wang@intel.com>
> > > Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> > > ---
> > > v2: Per Srinivas' suggestion, avoid duplicated assignment of max_pstate.
> > > v3: Per Rafael's suggestion, do not add new argument in intel_pstate_get_hwp_max()
> > > to avoid redundant local vars.
> > > Per Srinivas' suggestion, refined the commit log to reflect the 'non-turbo'
> > > max frequency.
> >
> > Looks good now, thanks!
> >
> > Is it needed in -stable and if so, which -stable series should it go into?
> >
> Yes, I think so, it should be
> Cc: stable@vger.kernel.org # 4.18+
> as the HWP reading turbo frequency was firstly introduced in v4.18-rc2 and it
> was easier to be applied.
> BTW, this patch is on top of your previous patch set on intel_pstate clean up:
> https://patchwork.kernel.org/project/linux-pm/list/?series=410797
OK, applied (with a few minor edits in the subject and changelog) as
5.12 material along with those patches , thanks!
prev parent reply other threads:[~2021-01-12 18:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 5:21 [PATCH][v3] cpufreq: intel_pstate: Get percpu max freq via HWP MSR register if available Chen Yu
2021-01-12 13:52 ` Rafael J. Wysocki
2021-01-12 15:03 ` Chen Yu
2021-01-12 18:46 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0igG=kyL7zFrvCLcMAE7uLzaB-MC8fZBxBX17WNTpR5Cg@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=viresh.kumar@linaro.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.