All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Borislav Petkov <bp@suse.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>, x86 <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Len Brown <len.brown@intel.com>,
	Linux PM <linux-pm@vger.kernel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Laura Abbott <labbott@fedoraproject.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	Simon Schricker <sschricker@suse.de>,
	Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH] PM / arch: x86: Rework the MSR_IA32_ENERGY_PERF_BIAS handling
Date: Thu, 21 Mar 2019 10:28:50 +0100	[thread overview]
Message-ID: <CAJZ5v0iiV3djzJrgj0GCeDuVs4hrtWKT9chtwLah5DpCw2sRaw@mail.gmail.com> (raw)
In-Reply-To: <20190321092055.GA7022@nazgul.tnic>

On Thu, Mar 21, 2019 at 10:21 AM Borislav Petkov <bp@suse.de> wrote:
>
> On Thu, Mar 21, 2019 at 08:58:07AM +0100, Peter Zijlstra wrote:
> > So I hate /dev/msr with a passion. It is absolute atrocious crap.
> >
> > Please, just make a real interface for this if it is important.
>
> Yeah, and we will start converting everything using /dev/msr to real
> interfaces and then taint on MSR write because, this should not have
> been allowed in the first place.

So as I've just said, I'm going to add a sysfs knob for adjusting EPB,
but I'd rather not do that in this patch.

This stuff doesn't work as intended right now, so let's fix it first
and then extend, OK?

  reply	other threads:[~2019-03-21  9:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21  0:00 [PATCH] PM / arch: x86: Rework the MSR_IA32_ENERGY_PERF_BIAS handling Rafael J. Wysocki
2019-03-21  7:58 ` Peter Zijlstra
2019-03-21  9:20   ` Borislav Petkov
2019-03-21  9:28     ` Rafael J. Wysocki [this message]
2019-03-21  9:32       ` Borislav Petkov
2019-03-21  9:36         ` Rafael J. Wysocki
2019-03-21  9:21   ` Rafael J. Wysocki
2019-04-05 15:32     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJZ5v0iiV3djzJrgj0GCeDuVs4hrtWKT9chtwLah5DpCw2sRaw@mail.gmail.com \
    --to=rafael@kernel.org \
    --cc=bp@suse.de \
    --cc=hare@suse.de \
    --cc=labbott@fedoraproject.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=sschricker@suse.de \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.