From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F7F8C433EF for ; Mon, 14 Feb 2022 18:53:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zU4aV2BCjwVRbW/zEl0TdOvWZNmwC2m36Ym/2OHdzm8=; b=sN7m12MdsWWLrn yaBdvMlapLM6ixth9UhYN3ygKOAkWObzZtOh9cbLdA+z3qYq+fjyITjf325QoYQx5ygQIONyRifIY aGb3fPZoU+06VA8P5lL67odGoOgL7i2lsfMYySunRORsvDaSlNB7ke48zW8V1dwEQRnXJvvr6veIF V5XK9b0Zg8usejQ/uDoVAHDXYpYx3IoSvHg8jii0ZblwLRwluS0bAKmCR8bLHDy1lPN5VgUlYOSCC H2WTYt0mnd3JyYQos7hs8E/XPJOowvCvtUADhtTacmFKWce48p8fotYB+AaG3gN006nR9yMTqbYc8 mPaCGo+xg0vgT8peBSdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJgRy-00GcqL-QH; Mon, 14 Feb 2022 18:51:50 +0000 Received: from mail-yb1-f178.google.com ([209.85.219.178]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJgRo-00Gcmx-3l for linux-arm-kernel@lists.infradead.org; Mon, 14 Feb 2022 18:51:41 +0000 Received: by mail-yb1-f178.google.com with SMTP id e140so29759789ybh.9 for ; Mon, 14 Feb 2022 10:51:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=b8cKkTln7w4zXU0UO1PkVXPeyp+Klu0mk/faMVTZgzg=; b=4JuW+cKrHgO0TjZqMYjp3qFTcdgmoGG5l2BpiKJUpUDnLSp/cUI69oxp1fpjqiJUnN VuidGWlzAJOhZRI8klb4oCaRv76GPE4+Ve2u1qN4upBfqEjFqJG4hhdHDY83qtdAp1/N 80gGJoKsuNgHtiYvyGXYsG1/XgSV7UGQzU5N1w0V2RkOpdePzKx+8Q5pA7y6QRXk5zcD r7iRLL3GtOKHdt/5OI/tMZFls7sI5WVvRWeSJGSQlihzpT97XqBKcOj929FYkTYSPB00 stNS34KF1v+PoYgRDgAFL2iZubg/lTo2D9QNmMCOZGJB76/iyQAj2GeRwOIownnTqD7e 7g2g== X-Gm-Message-State: AOAM533mOTRnxNk2hyV8Gr7kdNN92A+gR9LoplZTGbHRI5F53nUd87uq Se1txYYvHrpl0JvaOuISywxeF86I0MUuFRM1ILI= X-Google-Smtp-Source: ABdhPJz8jEed3icSZdx1gNohQkjgudBNW2wXvGya8/3qZoAtHt79uGNZ5RyC91bTq9wRf6j9nH+ux+C44fuxZHUnTpI= X-Received: by 2002:a81:ac4f:: with SMTP id z15mr79288ywj.7.1644864698112; Mon, 14 Feb 2022 10:51:38 -0800 (PST) MIME-Version: 1.0 References: <20211126070422.73234-1-xueshuai@linux.alibaba.com> <20220122052618.1074-1-xueshuai@linux.alibaba.com> <362d7c9c-4c5e-94f5-8168-39c007465771@linux.alibaba.com> In-Reply-To: <362d7c9c-4c5e-94f5-8168-39c007465771@linux.alibaba.com> From: "Rafael J. Wysocki" Date: Mon, 14 Feb 2022 19:51:27 +0100 Message-ID: Subject: Re: [PATCH v7 1/2] ACPI: APEI: explicit init HEST and GHES in apci_init To: Shuai Xue Cc: Bjorn Helgaas , "Rafael J. Wysocki" , Borislav Petkov , Tony Luck , James Morse , Len Brown , "Rafael J. Wysocki" , Bjorn Helgaas , luanshi , zhuo.song@linux.alibaba.com, Linux Kernel Mailing List , ACPI Devel Maling List , Linux ARM , Linux PCI X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220214_105140_205495_A5D4AF3E X-CRM114-Status: GOOD ( 34.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBGZWIgMTAsIDIwMjIgYXQgMTA6NDAgQU0gU2h1YWkgWHVlIDx4dWVzaHVhaUBsaW51 eC5hbGliYWJhLmNvbT4gd3JvdGU6Cj4KPiDlnKggMjAyMi8xLzIyIFBNMToyNiwgU2h1YWkgWHVl IOWGmemBkzoKPiA+IEZyb20gY29tbWl0IGUxNDcxMzNhNDJjYiAoIkFDUEkgLyBBUEVJOiBNYWtl IGhlc3QuYyBtYW5hZ2UgdGhlIGVzdGF0dXMKPiA+IG1lbW9yeSBwb29sIikgd2FzIG1lcmdlZCwg Z2hlc19pbml0KCkgcmVsaWVzIG9uIGFjcGlfaGVzdF9pbml0KCkgdG8gbWFuYWdlCj4gPiB0aGUg ZXN0YXR1cyBtZW1vcnkgcG9vbC4gT24gdGhlIG90aGVyIGhhbmQsIGdoZXNfaW5pdCgpIHJlbGll cyBvbgo+ID4gc2RlaV9pbml0KCkgdG8gZGV0ZWN0IHRoZSBTREVJIHZlcnNpb24gYW5kICh1bily ZWdpc3RlciBldmVudHMuIFRoZQo+ID4gZGVwZW5kZW5jaWVzIGFyZSBhcyBmb2xsb3dzOgo+ID4K PiA+ICAgICBnaGVzX2luaXQoKSA9PiBhY3BpX2hlc3RfaW5pdCgpID0+IGFjcGlfYnVzX2luaXQo KSA9PiBhY3BpX2luaXQoKQo+ID4gICAgIGdoZXNfaW5pdCgpID0+IHNkZWlfaW5pdCgpCj4gPgo+ ID4gSEVTVCBpcyBub3QgUENJLXNwZWNpZmljIGFuZCBpbml0Y2FsbCBvcmRlcmluZyBpcyBpbXBs aWNpdCBhbmQgbm90Cj4gPiB3ZWxsLWRlZmluZWQgd2l0aGluIGEgbGV2ZWwuCj4gPgo+ID4gQmFz ZWQgb24gYWJvdmUsIHJlbW92ZSBhY3BpX2hlc3RfaW5pdCgpIGZyb20gYWNwaV9wY2lfcm9vdF9p bml0KCkgYW5kCj4gPiBjb252ZXJ0IGdoZXNfaW5pdCgpIGFuZCBzZGVpX2luaXQoKSBmcm9tIGlu aXRjYWxscyB0byBleHBsaWNpdCBjYWxscyBpbiB0aGUKPiA+IGZvbGxvd2luZyBvcmRlcjoKPiA+ Cj4gPiAgICAgYWNwaV9oZXN0X2luaXQoKQo+ID4gICAgIGdoZXNfaW5pdCgpCj4gPiAgICAgICAg IHNkZWlfaW5pdCgpCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogU2h1YWkgWHVlIDx4dWVzaHVhaUBs aW51eC5hbGliYWJhLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvYWNwaS9hcGVpL2doZXMuYyAg ICB8IDE5ICsrKysrKysrLS0tLS0tLS0tLS0KPiA+ICBkcml2ZXJzL2FjcGkvYnVzLmMgICAgICAg ICAgfCAgMiArKwo+ID4gIGRyaXZlcnMvYWNwaS9wY2lfcm9vdC5jICAgICB8ICAzIC0tLQo+ID4g IGRyaXZlcnMvZmlybXdhcmUvS2NvbmZpZyAgICB8ICAxICsKPiA+ICBkcml2ZXJzL2Zpcm13YXJl L2FybV9zZGVpLmMgfCAxMyArKy0tLS0tLS0tLS0tCj4gPiAgaW5jbHVkZS9hY3BpL2FwZWkuaCAg ICAgICAgIHwgIDQgKysrLQo+ID4gIGluY2x1ZGUvbGludXgvYXJtX3NkZWkuaCAgICB8ICAyICsr Cj4gPiAgNyBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAyNiBkZWxldGlvbnMoLSkK PiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9hY3BpL2FwZWkvZ2hlcy5jIGIvZHJpdmVycy9h Y3BpL2FwZWkvZ2hlcy5jCj4gPiBpbmRleCAwYzVjOWFjYzYyNTQuLmFhZGMwYTk3MmYxOCAxMDA2 NDQKPiA+IC0tLSBhL2RyaXZlcnMvYWNwaS9hcGVpL2doZXMuYwo+ID4gKysrIGIvZHJpdmVycy9h Y3BpL2FwZWkvZ2hlcy5jCj4gPiBAQCAtMTQ1NywzMyArMTQ1NywzNSBAQCBzdGF0aWMgc3RydWN0 IHBsYXRmb3JtX2RyaXZlciBnaGVzX3BsYXRmb3JtX2RyaXZlciA9IHsKPiA+ICAgICAgIC5yZW1v dmUgICAgICAgICA9IGdoZXNfcmVtb3ZlLAo+ID4gIH07Cj4gPgo+ID4gLXN0YXRpYyBpbnQgX19p bml0IGdoZXNfaW5pdCh2b2lkKQo+ID4gK3ZvaWQgX19pbml0IGdoZXNfaW5pdCh2b2lkKQo+ID4g IHsKPiA+ICAgICAgIGludCByYzsKPiA+Cj4gPiArICAgICBzZGVpX2luaXQoKTsKPiA+ICsKPiA+ ICAgICAgIGlmIChhY3BpX2Rpc2FibGVkKQo+ID4gLSAgICAgICAgICAgICByZXR1cm4gLUVOT0RF VjsKPiA+ICsgICAgICAgICAgICAgcmV0dXJuOwo+ID4KPiA+ICAgICAgIHN3aXRjaCAoaGVzdF9k aXNhYmxlKSB7Cj4gPiAgICAgICBjYXNlIEhFU1RfTk9UX0ZPVU5EOgo+ID4gLSAgICAgICAgICAg ICByZXR1cm4gLUVOT0RFVjsKPiA+ICsgICAgICAgICAgICAgcmV0dXJuOwo+ID4gICAgICAgY2Fz ZSBIRVNUX0RJU0FCTEVEOgo+ID4gICAgICAgICAgICAgICBwcl9pbmZvKEdIRVNfUEZYICJIRVNU IGlzIG5vdCBlbmFibGVkIVxuIik7Cj4gPiAtICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ ID4gKyAgICAgICAgICAgICByZXR1cm47Cj4gPiAgICAgICBkZWZhdWx0Ogo+ID4gICAgICAgICAg ICAgICBicmVhazsKPiA+ICAgICAgIH0KPiA+Cj4gPiAgICAgICBpZiAoZ2hlc19kaXNhYmxlKSB7 Cj4gPiAgICAgICAgICAgICAgIHByX2luZm8oR0hFU19QRlggIkdIRVMgaXMgbm90IGVuYWJsZWQh XG4iKTsKPiA+IC0gICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4gPiArICAgICAgICAgICAg IHJldHVybjsKPiA+ICAgICAgIH0KPiA+Cj4gPiAgICAgICBnaGVzX25taV9pbml0X2N4dCgpOwo+ ID4KPiA+ICAgICAgIHJjID0gcGxhdGZvcm1fZHJpdmVyX3JlZ2lzdGVyKCZnaGVzX3BsYXRmb3Jt X2RyaXZlcik7Cj4gPiAgICAgICBpZiAocmMpCj4gPiAtICAgICAgICAgICAgIGdvdG8gZXJyOwo+ ID4gKyAgICAgICAgICAgICByZXR1cm47Cj4gPgo+ID4gICAgICAgcmMgPSBhcGVpX29zY19zZXR1 cCgpOwo+ID4gICAgICAgaWYgKHJjID09IDAgJiYgb3NjX3NiX2FwZWlfc3VwcG9ydF9hY2tlZCkK PiA+IEBAIC0xNDk0LDkgKzE0OTYsNCBAQCBzdGF0aWMgaW50IF9faW5pdCBnaGVzX2luaXQodm9p ZCkKPiA+ICAgICAgICAgICAgICAgcHJfaW5mbyhHSEVTX1BGWCAiQVBFSSBmaXJtd2FyZSBmaXJz dCBtb2RlIGlzIGVuYWJsZWQgYnkgQVBFSSBiaXQuXG4iKTsKPiA+ICAgICAgIGVsc2UKPiA+ICAg ICAgICAgICAgICAgcHJfaW5mbyhHSEVTX1BGWCAiRmFpbGVkIHRvIGVuYWJsZSBBUEVJIGZpcm13 YXJlIGZpcnN0IG1vZGUuXG4iKTsKPiA+IC0KPiA+IC0gICAgIHJldHVybiAwOwo+ID4gLWVycjoK PiA+IC0gICAgIHJldHVybiByYzsKPiA+ICB9Cj4gPiAtZGV2aWNlX2luaXRjYWxsKGdoZXNfaW5p dCk7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9hY3BpL2J1cy5jIGIvZHJpdmVycy9hY3BpL2J1 cy5jCj4gPiBpbmRleCAwN2Y2MDQ4MzJmZDYuLjNmNDAzZGIyMGY2OSAxMDA2NDQKPiA+IC0tLSBh L2RyaXZlcnMvYWNwaS9idXMuYwo+ID4gKysrIGIvZHJpdmVycy9hY3BpL2J1cy5jCj4gPiBAQCAt MTMzMSw2ICsxMzMxLDggQEAgc3RhdGljIGludCBfX2luaXQgYWNwaV9pbml0KHZvaWQpCj4gPgo+ ID4gICAgICAgcGNpX21tY2ZnX2xhdGVfaW5pdCgpOwo+ID4gICAgICAgYWNwaV9pb3J0X2luaXQo KTsKPiA+ICsgICAgIGFjcGlfaGVzdF9pbml0KCk7Cj4gPiArICAgICBnaGVzX2luaXQoKTsKPiA+ ICAgICAgIGFjcGlfc2Nhbl9pbml0KCk7Cj4gPiAgICAgICBhY3BpX2VjX2luaXQoKTsKPiA+ICAg ICAgIGFjcGlfZGVidWdmc19pbml0KCk7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9hY3BpL3Bj aV9yb290LmMgYi9kcml2ZXJzL2FjcGkvcGNpX3Jvb3QuYwo+ID4gaW5kZXggYjc2ZGI5OWNjZWQz Li42ZjllNzVkMTQ4MDggMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2FjcGkvcGNpX3Jvb3QuYwo+ ID4gKysrIGIvZHJpdmVycy9hY3BpL3BjaV9yb290LmMKPiA+IEBAIC0yMiw4ICsyMiw2IEBACj4g PiAgI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KPiA+ICAjaW5jbHVkZSA8bGludXgvZG1pLmg+Cj4g PiAgI2luY2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RhdGEveDg2L2FwcGxlLmg+Cj4gPiAtI2luY2x1 ZGUgPGFjcGkvYXBlaS5oPiAgICAgICAvKiBmb3IgYWNwaV9oZXN0X2luaXQoKSAqLwo+ID4gLQo+ ID4gICNpbmNsdWRlICJpbnRlcm5hbC5oIgo+ID4KPiA+ICAjZGVmaW5lIEFDUElfUENJX1JPT1Rf Q0xBU1MgICAgICAgICAgInBjaV9icmlkZ2UiCj4gPiBAQCAtOTQzLDcgKzk0MSw2IEBAIHN0cnVj dCBwY2lfYnVzICphY3BpX3BjaV9yb290X2NyZWF0ZShzdHJ1Y3QgYWNwaV9wY2lfcm9vdCAqcm9v dCwKPiA+Cj4gPiAgdm9pZCBfX2luaXQgYWNwaV9wY2lfcm9vdF9pbml0KHZvaWQpCj4gPiAgewo+ ID4gLSAgICAgYWNwaV9oZXN0X2luaXQoKTsKPiA+ICAgICAgIGlmIChhY3BpX3BjaV9kaXNhYmxl ZCkKPiA+ICAgICAgICAgICAgICAgcmV0dXJuOwo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2Zpcm13YXJlL0tjb25maWcgYi9kcml2ZXJzL2Zpcm13YXJlL0tjb25maWcKPiA+IGluZGV4IDc1 Y2I5MTA1NWMxNy4uYWQxMTRkOWNkZjhlIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9maXJtd2Fy ZS9LY29uZmlnCj4gPiArKysgYi9kcml2ZXJzL2Zpcm13YXJlL0tjb25maWcKPiA+IEBAIC00MCw2 ICs0MCw3IEBAIGNvbmZpZyBBUk1fU0NQSV9QT1dFUl9ET01BSU4KPiA+ICBjb25maWcgQVJNX1NE RV9JTlRFUkZBQ0UKPiA+ICAgICAgIGJvb2wgIkFSTSBTb2Z0d2FyZSBEZWxlZ2F0ZWQgRXhjZXB0 aW9uIEludGVyZmFjZSAoU0RFSSkiCj4gPiAgICAgICBkZXBlbmRzIG9uIEFSTTY0Cj4gPiArICAg ICBzZWxlY3QgQUNQSV9BUEVJX0dIRVMKPiA+ICAgICAgIGhlbHAKPiA+ICAgICAgICAgVGhlIFNv ZnR3YXJlIERlbGVnYXRlZCBFeGNlcHRpb24gSW50ZXJmYWNlIChTREVJKSBpcyBhbiBBUk0KPiA+ ICAgICAgICAgc3RhbmRhcmQgZm9yIHJlZ2lzdGVyaW5nIGNhbGxiYWNrcyBmcm9tIHRoZSBwbGF0 Zm9ybSBmaXJtd2FyZQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZmlybXdhcmUvYXJtX3NkZWku YyBiL2RyaXZlcnMvZmlybXdhcmUvYXJtX3NkZWkuYwo+ID4gaW5kZXggYTdlNzYyYzM1MmY5Li4x ZTFhNTE1MTBlODMgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2Zpcm13YXJlL2FybV9zZGVpLmMK PiA+ICsrKyBiL2RyaXZlcnMvZmlybXdhcmUvYXJtX3NkZWkuYwo+ID4gQEAgLTEwNTksMTQgKzEw NTksMTQgQEAgc3RhdGljIGJvb2wgX19pbml0IHNkZWlfcHJlc2VudF9hY3BpKHZvaWQpCj4gPiAg ICAgICByZXR1cm4gdHJ1ZTsKPiA+ICB9Cj4gPgo+ID4gLXN0YXRpYyBpbnQgX19pbml0IHNkZWlf aW5pdCh2b2lkKQo+ID4gK3ZvaWQgX19pbml0IHNkZWlfaW5pdCh2b2lkKQo+ID4gIHsKPiA+ICAg ICAgIHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXY7Cj4gPiAgICAgICBpbnQgcmV0Owo+ID4K PiA+ICAgICAgIHJldCA9IHBsYXRmb3JtX2RyaXZlcl9yZWdpc3Rlcigmc2RlaV9kcml2ZXIpOwo+ ID4gICAgICAgaWYgKHJldCB8fCAhc2RlaV9wcmVzZW50X2FjcGkoKSkKPiA+IC0gICAgICAgICAg ICAgcmV0dXJuIHJldDsKPiA+ICsgICAgICAgICAgICAgcmV0dXJuOwo+ID4KPiA+ICAgICAgIHBk ZXYgPSBwbGF0Zm9ybV9kZXZpY2VfcmVnaXN0ZXJfc2ltcGxlKHNkZWlfZHJpdmVyLmRyaXZlci5u YW1lLAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMCwg TlVMTCwgMCk7Cj4gPiBAQCAtMTA3NiwxNyArMTA3Niw4IEBAIHN0YXRpYyBpbnQgX19pbml0IHNk ZWlfaW5pdCh2b2lkKQo+ID4gICAgICAgICAgICAgICBwcl9pbmZvKCJGYWlsZWQgdG8gcmVnaXN0 ZXIgQUNQSTpTREVJIHBsYXRmb3JtIGRldmljZSAlZFxuIiwKPiA+ICAgICAgICAgICAgICAgICAg ICAgICByZXQpOwo+ID4gICAgICAgfQo+ID4gLQo+ID4gLSAgICAgcmV0dXJuIHJldDsKPiA+ICB9 Cj4gPgo+ID4gLS8qCj4gPiAtICogT24gYW4gQUNQSSBzeXN0ZW0gU0RFSSBuZWVkcyB0byBiZSBy ZWFkeSBiZWZvcmUgSEVTVDpHSEVTIHRyaWVzIHRvIHJlZ2lzdGVyCj4gPiAtICogaXRzIGV2ZW50 cy4gQUNQSSBpcyBpbml0aWFsaXNlZCBmcm9tIGEgc3Vic3lzX2luaXRjYWxsKCksIEdIRVMgaXMg aW5pdGlhbGlzZWQKPiA+IC0gKiBieSBkZXZpY2VfaW5pdGNhbGwoKS4gV2Ugd2FudCB0byBiZSBj YWxsZWQgaW4gdGhlIG1pZGRsZS4KPiA+IC0gKi8KPiA+IC1zdWJzeXNfaW5pdGNhbGxfc3luYyhz ZGVpX2luaXQpOwo+ID4gLQo+ID4gIGludCBzZGVpX2V2ZW50X2hhbmRsZXIoc3RydWN0IHB0X3Jl Z3MgKnJlZ3MsCj4gPiAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3Qgc2RlaV9yZWdpc3RlcmVk X2V2ZW50ICphcmcpCj4gPiAgewo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvYWNwaS9hcGVpLmgg Yi9pbmNsdWRlL2FjcGkvYXBlaS5oCj4gPiBpbmRleCBlY2UwYThhZjJiYWUuLjRlNjBkZDczYzNi YiAxMDA2NDQKPiA+IC0tLSBhL2luY2x1ZGUvYWNwaS9hcGVpLmgKPiA+ICsrKyBiL2luY2x1ZGUv YWNwaS9hcGVpLmgKPiA+IEBAIC0yNywxNCArMjcsMTYgQEAgZXh0ZXJuIGludCBoZXN0X2Rpc2Fi bGU7Cj4gPiAgZXh0ZXJuIGludCBlcnN0X2Rpc2FibGU7Cj4gPiAgI2lmZGVmIENPTkZJR19BQ1BJ X0FQRUlfR0hFUwo+ID4gIGV4dGVybiBib29sIGdoZXNfZGlzYWJsZTsKPiA+ICt2b2lkIF9faW5p dCBnaGVzX2luaXQodm9pZCk7Cj4gPiAgI2Vsc2UKPiA+ICAjZGVmaW5lIGdoZXNfZGlzYWJsZSAx Cj4gPiArc3RhdGljIGlubGluZSB2b2lkIGdoZXNfaW5pdCh2b2lkKSB7IH0KPiA+ICAjZW5kaWYK PiA+Cj4gPiAgI2lmZGVmIENPTkZJR19BQ1BJX0FQRUkKPiA+ICB2b2lkIF9faW5pdCBhY3BpX2hl c3RfaW5pdCh2b2lkKTsKPiA+ICAjZWxzZQo+ID4gLXN0YXRpYyBpbmxpbmUgdm9pZCBhY3BpX2hl c3RfaW5pdCh2b2lkKSB7IHJldHVybjsgfQo+ID4gK3N0YXRpYyBpbmxpbmUgdm9pZCBhY3BpX2hl c3RfaW5pdCh2b2lkKSB7IH0KPiA+ICAjZW5kaWYKPiA+Cj4gPiAgaW50IGVyc3Rfd3JpdGUoY29u c3Qgc3RydWN0IGNwZXJfcmVjb3JkX2hlYWRlciAqcmVjb3JkKTsKPiA+IGRpZmYgLS1naXQgYS9p bmNsdWRlL2xpbnV4L2FybV9zZGVpLmggYi9pbmNsdWRlL2xpbnV4L2FybV9zZGVpLmgKPiA+IGlu ZGV4IDBhMjQxYzVjOTExZC4uMTRkYzQ2MWIwZTgyIDEwMDY0NAo+ID4gLS0tIGEvaW5jbHVkZS9s aW51eC9hcm1fc2RlaS5oCj4gPiArKysgYi9pbmNsdWRlL2xpbnV4L2FybV9zZGVpLmgKPiA+IEBA IC00Niw5ICs0NiwxMSBAQCBpbnQgc2RlaV91bnJlZ2lzdGVyX2doZXMoc3RydWN0IGdoZXMgKmdo ZXMpOwo+ID4gIC8qIEZvciB1c2UgYnkgYXJjaCBjb2RlIHdoZW4gQ1BVIGhvdHBsdWcgbm90aWZp ZXJzIGFyZSBub3QgYXBwcm9wcmlhdGUuICovCj4gPiAgaW50IHNkZWlfbWFza19sb2NhbF9jcHUo dm9pZCk7Cj4gPiAgaW50IHNkZWlfdW5tYXNrX2xvY2FsX2NwdSh2b2lkKTsKPiA+ICt2b2lkIF9f aW5pdCBzZGVpX2luaXQodm9pZCk7Cj4gPiAgI2Vsc2UKPiA+ICBzdGF0aWMgaW5saW5lIGludCBz ZGVpX21hc2tfbG9jYWxfY3B1KHZvaWQpIHsgcmV0dXJuIDA7IH0KPiA+ICBzdGF0aWMgaW5saW5l IGludCBzZGVpX3VubWFza19sb2NhbF9jcHUodm9pZCkgeyByZXR1cm4gMDsgfQo+ID4gK3N0YXRp YyBpbmxpbmUgdm9pZCBzZGVpX2luaXQodm9pZCkgeyB9Cj4gPiAgI2VuZGlmIC8qIENPTkZJR19B Uk1fU0RFX0lOVEVSRkFDRSAqLwo+ID4KPiA+Cj4KPiBIaSBmb2xrcywKPgo+IEkgYW0gd29uZGVy aW5nIGlmIHlvdSBoYXZlIGFueSBjb21tZW50cyBvbiB0aGlzIHNlcmllcyBvZiBwYXRjaGVzPwoK SSd2ZSBhcHBsaWVkIGJvdGggcGF0Y2hlcyBhcyA1LjE4IG1hdGVyaWFsLCB0aGFua3MhCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6464C43219 for ; Mon, 14 Feb 2022 20:53:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230014AbiBNUxt convert rfc822-to-8bit (ORCPT ); Mon, 14 Feb 2022 15:53:49 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:54740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229990AbiBNUxo (ORCPT ); Mon, 14 Feb 2022 15:53:44 -0500 Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7202C13EAF; Mon, 14 Feb 2022 12:53:24 -0800 (PST) Received: by mail-yb1-f182.google.com with SMTP id e140so30664090ybh.9; Mon, 14 Feb 2022 12:53:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=b8cKkTln7w4zXU0UO1PkVXPeyp+Klu0mk/faMVTZgzg=; b=iqrIJmn2Ta4G4teQ4hRZOBA4oRr0/9IHsOPaHysakAfbnNcQeKRqlaiLBu5I5eFojC LtIxh2KQkH9/P6Xpxnze/2mmF7ACqL5WjcMcawyEXL7KmxW1y5HGaadwdWPJ5OwkAmOn w5Ev8N7BToYGvb1FhjssET/Q0ZMJkhKsPfpmYU62uPNH1x2R9xxyM0DgEiBMhizwSWZs iK4TE43NmxNbTF83qlAxGmw0uGB8Th8/RMfvcOMbPy/07lM8Rs6v8hLhuN6wgE+U9tUI GY5FaCR4hp+OrVmZyDMJ/nvnh8fGwrlw4DmiqPX5DINh+VK8Eiu1tU8QLjjnskfe4lQU 3y8Q== X-Gm-Message-State: AOAM5305njuBgCw56ho9qditc4nI5bFFtlEIlOPWMnH+ddOuh6n6QU93 Ne9ohFqnf1g/c+1LoB4pBmziZqpFRuWscKK4R2Ws7J9p X-Google-Smtp-Source: ABdhPJz8jEed3icSZdx1gNohQkjgudBNW2wXvGya8/3qZoAtHt79uGNZ5RyC91bTq9wRf6j9nH+ux+C44fuxZHUnTpI= X-Received: by 2002:a81:ac4f:: with SMTP id z15mr79288ywj.7.1644864698112; Mon, 14 Feb 2022 10:51:38 -0800 (PST) MIME-Version: 1.0 References: <20211126070422.73234-1-xueshuai@linux.alibaba.com> <20220122052618.1074-1-xueshuai@linux.alibaba.com> <362d7c9c-4c5e-94f5-8168-39c007465771@linux.alibaba.com> In-Reply-To: <362d7c9c-4c5e-94f5-8168-39c007465771@linux.alibaba.com> From: "Rafael J. Wysocki" Date: Mon, 14 Feb 2022 19:51:27 +0100 Message-ID: Subject: Re: [PATCH v7 1/2] ACPI: APEI: explicit init HEST and GHES in apci_init To: Shuai Xue Cc: Bjorn Helgaas , "Rafael J. Wysocki" , Borislav Petkov , Tony Luck , James Morse , Len Brown , "Rafael J. Wysocki" , Bjorn Helgaas , luanshi , zhuo.song@linux.alibaba.com, Linux Kernel Mailing List , ACPI Devel Maling List , Linux ARM , Linux PCI Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Feb 10, 2022 at 10:40 AM Shuai Xue wrote: > > 在 2022/1/22 PM1:26, Shuai Xue 写道: > > From commit e147133a42cb ("ACPI / APEI: Make hest.c manage the estatus > > memory pool") was merged, ghes_init() relies on acpi_hest_init() to manage > > the estatus memory pool. On the other hand, ghes_init() relies on > > sdei_init() to detect the SDEI version and (un)register events. The > > dependencies are as follows: > > > > ghes_init() => acpi_hest_init() => acpi_bus_init() => acpi_init() > > ghes_init() => sdei_init() > > > > HEST is not PCI-specific and initcall ordering is implicit and not > > well-defined within a level. > > > > Based on above, remove acpi_hest_init() from acpi_pci_root_init() and > > convert ghes_init() and sdei_init() from initcalls to explicit calls in the > > following order: > > > > acpi_hest_init() > > ghes_init() > > sdei_init() > > > > Signed-off-by: Shuai Xue > > --- > > drivers/acpi/apei/ghes.c | 19 ++++++++----------- > > drivers/acpi/bus.c | 2 ++ > > drivers/acpi/pci_root.c | 3 --- > > drivers/firmware/Kconfig | 1 + > > drivers/firmware/arm_sdei.c | 13 ++----------- > > include/acpi/apei.h | 4 +++- > > include/linux/arm_sdei.h | 2 ++ > > 7 files changed, 18 insertions(+), 26 deletions(-) > > > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > > index 0c5c9acc6254..aadc0a972f18 100644 > > --- a/drivers/acpi/apei/ghes.c > > +++ b/drivers/acpi/apei/ghes.c > > @@ -1457,33 +1457,35 @@ static struct platform_driver ghes_platform_driver = { > > .remove = ghes_remove, > > }; > > > > -static int __init ghes_init(void) > > +void __init ghes_init(void) > > { > > int rc; > > > > + sdei_init(); > > + > > if (acpi_disabled) > > - return -ENODEV; > > + return; > > > > switch (hest_disable) { > > case HEST_NOT_FOUND: > > - return -ENODEV; > > + return; > > case HEST_DISABLED: > > pr_info(GHES_PFX "HEST is not enabled!\n"); > > - return -EINVAL; > > + return; > > default: > > break; > > } > > > > if (ghes_disable) { > > pr_info(GHES_PFX "GHES is not enabled!\n"); > > - return -EINVAL; > > + return; > > } > > > > ghes_nmi_init_cxt(); > > > > rc = platform_driver_register(&ghes_platform_driver); > > if (rc) > > - goto err; > > + return; > > > > rc = apei_osc_setup(); > > if (rc == 0 && osc_sb_apei_support_acked) > > @@ -1494,9 +1496,4 @@ static int __init ghes_init(void) > > pr_info(GHES_PFX "APEI firmware first mode is enabled by APEI bit.\n"); > > else > > pr_info(GHES_PFX "Failed to enable APEI firmware first mode.\n"); > > - > > - return 0; > > -err: > > - return rc; > > } > > -device_initcall(ghes_init); > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > > index 07f604832fd6..3f403db20f69 100644 > > --- a/drivers/acpi/bus.c > > +++ b/drivers/acpi/bus.c > > @@ -1331,6 +1331,8 @@ static int __init acpi_init(void) > > > > pci_mmcfg_late_init(); > > acpi_iort_init(); > > + acpi_hest_init(); > > + ghes_init(); > > acpi_scan_init(); > > acpi_ec_init(); > > acpi_debugfs_init(); > > diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c > > index b76db99cced3..6f9e75d14808 100644 > > --- a/drivers/acpi/pci_root.c > > +++ b/drivers/acpi/pci_root.c > > @@ -22,8 +22,6 @@ > > #include > > #include > > #include > > -#include /* for acpi_hest_init() */ > > - > > #include "internal.h" > > > > #define ACPI_PCI_ROOT_CLASS "pci_bridge" > > @@ -943,7 +941,6 @@ struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root, > > > > void __init acpi_pci_root_init(void) > > { > > - acpi_hest_init(); > > if (acpi_pci_disabled) > > return; > > > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > > index 75cb91055c17..ad114d9cdf8e 100644 > > --- a/drivers/firmware/Kconfig > > +++ b/drivers/firmware/Kconfig > > @@ -40,6 +40,7 @@ config ARM_SCPI_POWER_DOMAIN > > config ARM_SDE_INTERFACE > > bool "ARM Software Delegated Exception Interface (SDEI)" > > depends on ARM64 > > + select ACPI_APEI_GHES > > help > > The Software Delegated Exception Interface (SDEI) is an ARM > > standard for registering callbacks from the platform firmware > > diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c > > index a7e762c352f9..1e1a51510e83 100644 > > --- a/drivers/firmware/arm_sdei.c > > +++ b/drivers/firmware/arm_sdei.c > > @@ -1059,14 +1059,14 @@ static bool __init sdei_present_acpi(void) > > return true; > > } > > > > -static int __init sdei_init(void) > > +void __init sdei_init(void) > > { > > struct platform_device *pdev; > > int ret; > > > > ret = platform_driver_register(&sdei_driver); > > if (ret || !sdei_present_acpi()) > > - return ret; > > + return; > > > > pdev = platform_device_register_simple(sdei_driver.driver.name, > > 0, NULL, 0); > > @@ -1076,17 +1076,8 @@ static int __init sdei_init(void) > > pr_info("Failed to register ACPI:SDEI platform device %d\n", > > ret); > > } > > - > > - return ret; > > } > > > > -/* > > - * On an ACPI system SDEI needs to be ready before HEST:GHES tries to register > > - * its events. ACPI is initialised from a subsys_initcall(), GHES is initialised > > - * by device_initcall(). We want to be called in the middle. > > - */ > > -subsys_initcall_sync(sdei_init); > > - > > int sdei_event_handler(struct pt_regs *regs, > > struct sdei_registered_event *arg) > > { > > diff --git a/include/acpi/apei.h b/include/acpi/apei.h > > index ece0a8af2bae..4e60dd73c3bb 100644 > > --- a/include/acpi/apei.h > > +++ b/include/acpi/apei.h > > @@ -27,14 +27,16 @@ extern int hest_disable; > > extern int erst_disable; > > #ifdef CONFIG_ACPI_APEI_GHES > > extern bool ghes_disable; > > +void __init ghes_init(void); > > #else > > #define ghes_disable 1 > > +static inline void ghes_init(void) { } > > #endif > > > > #ifdef CONFIG_ACPI_APEI > > void __init acpi_hest_init(void); > > #else > > -static inline void acpi_hest_init(void) { return; } > > +static inline void acpi_hest_init(void) { } > > #endif > > > > int erst_write(const struct cper_record_header *record); > > diff --git a/include/linux/arm_sdei.h b/include/linux/arm_sdei.h > > index 0a241c5c911d..14dc461b0e82 100644 > > --- a/include/linux/arm_sdei.h > > +++ b/include/linux/arm_sdei.h > > @@ -46,9 +46,11 @@ int sdei_unregister_ghes(struct ghes *ghes); > > /* For use by arch code when CPU hotplug notifiers are not appropriate. */ > > int sdei_mask_local_cpu(void); > > int sdei_unmask_local_cpu(void); > > +void __init sdei_init(void); > > #else > > static inline int sdei_mask_local_cpu(void) { return 0; } > > static inline int sdei_unmask_local_cpu(void) { return 0; } > > +static inline void sdei_init(void) { } > > #endif /* CONFIG_ARM_SDE_INTERFACE */ > > > > > > Hi folks, > > I am wondering if you have any comments on this series of patches? I've applied both patches as 5.18 material, thanks!