From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: MIME-Version: 1.0 Sender: rjwysocki@gmail.com In-Reply-To: <1506737526-94266-1-git-send-email-zhengqiang10@huawei.com> References: <1506737526-94266-1-git-send-email-zhengqiang10@huawei.com> From: "Rafael J. Wysocki" Date: Sun, 1 Oct 2017 02:45:11 +0200 Message-ID: Subject: Re: [PATCH V2] Bug fix for PME interrupt handler, add Root Status check To: Qiang Zheng Cc: Bjorn Helgaas , Linux PCI , Linux PM , Gabriele Paoloni , Linuxarm Content-Type: text/plain; charset="UTF-8" List-ID: On Sat, Sep 30, 2017 at 4:12 AM, Qiang Zheng wrote: > PCIe PME and hot plug share same interrupt number. In some special case, > Link down event cause hot plug interrupt, devices is not disconnected, > But read config will return 0xff. > > In that case, PME work function will run and not return Because > Root Status PME bit always 1 and can not be cleared. > > This patch add Root Status check in PME interrupt handler, > Just do same as pciehp isr Slot status check. > > Signed-off-by: Qiang Zheng > --- > drivers/pci/pcie/pme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c > index fafdb16..2ff2e57 100644 > --- a/drivers/pci/pcie/pme.c > +++ b/drivers/pci/pcie/pme.c > @@ -273,7 +273,7 @@ static irqreturn_t pcie_pme_irq(int irq, void *context) > spin_lock_irqsave(&data->lock, flags); > pcie_capability_read_dword(port, PCI_EXP_RTSTA, &rtsta); > > - if (!(rtsta & PCI_EXP_RTSTA_PME)) { > + if (rtsta == U32_MAX || !(rtsta & PCI_EXP_RTSTA_PME)) { > spin_unlock_irqrestore(&data->lock, flags); > return IRQ_NONE; > } > -- Reviewed-by: Rafael J. Wysocki