From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Baokun Li <libaokun1@huawei.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Wei Yongjun <weiyongjun1@huawei.com>,
Yue Haibing <yuehaibing@huawei.com>,
yangjihong1@huawei.com, yu kuai <yukuai3@huawei.com>
Subject: Re: [PATCH -next] ACPI: sysfs: fix doc warnings in device_sysfs.c
Date: Mon, 14 Jun 2021 17:26:33 +0200 [thread overview]
Message-ID: <CAJZ5v0ivf6xN0pd4Ub6YuKCwDUpXLcEZywdT+JPKa=1qTOH-iA@mail.gmail.com> (raw)
In-Reply-To: <20210610113501.3439670-1-libaokun1@huawei.com>
On Thu, Jun 10, 2021 at 1:25 PM Baokun Li <libaokun1@huawei.com> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/acpi/device_sysfs.c:278: warning: Function parameter or
> member 'dev' not described in 'acpi_device_uevent_modalias'
> drivers/acpi/device_sysfs.c:278: warning: Function parameter or
> member 'env' not described in 'acpi_device_uevent_modalias'
> drivers/acpi/device_sysfs.c:323: warning: Function parameter or
> member 'dev' not described in 'acpi_device_modalias'
> drivers/acpi/device_sysfs.c:323: warning: Function parameter or
> member 'buf' not described in 'acpi_device_modalias'
> drivers/acpi/device_sysfs.c:323: warning: Function parameter or
> member 'size' not described in 'acpi_device_modalias'
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
> drivers/acpi/device_sysfs.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
> index fa2c1c93072c..3b08efa88ba5 100644
> --- a/drivers/acpi/device_sysfs.c
> +++ b/drivers/acpi/device_sysfs.c
> @@ -268,7 +268,8 @@ int __acpi_device_uevent_modalias(struct acpi_device *adev,
>
> /**
> * acpi_device_uevent_modalias - uevent modalias for ACPI-enumerated devices.
> - *
> + * @dev: Struct device.
> + * @env: Uevent kobject.
This doesn't appear to be accurate.
@env doesn't point to a kobject.
> * Create the uevent modalias field for ACPI-enumerated devices.
> *
> * Because other buses do not support ACPI HIDs & CIDs, e.g. for a device with
> @@ -313,7 +314,9 @@ static int __acpi_device_modalias(struct acpi_device *adev, char *buf, int size)
>
> /**
> * acpi_device_modalias - modalias sysfs attribute for ACPI-enumerated devices.
> - *
> + * @dev: Struct device.
> + * @buf: The buffer.
> + * @size: Size of the buffer.
> * Create the modalias sysfs attribute for ACPI-enumerated devices.
> *
> * Because other buses do not support ACPI HIDs & CIDs, e.g. for a device with
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-06-14 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 11:35 [PATCH -next] ACPI: sysfs: fix doc warnings in device_sysfs.c Baokun Li
2021-06-14 15:26 ` Rafael J. Wysocki [this message]
2021-06-15 3:50 ` libaokun (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0ivf6xN0pd4Ub6YuKCwDUpXLcEZywdT+JPKa=1qTOH-iA@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=lenb@kernel.org \
--cc=libaokun1@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=weiyongjun1@huawei.com \
--cc=yangjihong1@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.