From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Chandan Rajendra <chandan@linux.ibm.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Sinan Kaya <Okaya@kernel.org>,
"moderated list:INTEL ASoC DRIVERS" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>,
Jie Yang <yang.jie@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>,
open list <linux-kernel@vger.kernel.org>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Chandan Rajendra <chandan@linux.vnet.ibm.com>,
Ted Ts'o <tytso@google.com>
Subject: Re: [alsa-devel] [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Date: Thu, 3 Jan 2019 10:52:28 +0100 [thread overview]
Message-ID: <CAJZ5v0j=i_YN7szXLV8cKLp2XmoqUTQR6EJhRJhWFJzenhzM9Q@mail.gmail.com> (raw)
In-Reply-To: <5797826.UxqLOWUXRU@localhost.localdomain>
On Thu, Jan 3, 2019 at 5:08 AM Chandan Rajendra <chandan@linux.ibm.com> wrote:
>
> On Thursday, January 3, 2019 5:20:27 AM IST Pierre-Louis Bossart wrote:
> >
> > On 1/2/19 4:58 PM, Sinan Kaya wrote:
> > > On Wed, Jan 2, 2019 at 10:50 PM Pierre-Louis Bossart
> > > <pierre-louis.bossart@linux.intel.com> wrote:
> > >>
> > >>> This is pointing to a kconfig issue on ia64 arch.
> > >>>
> > >>> arch/ia64/Kconfig:128:error: recursive dependency detected!
> > >>> arch/ia64/Kconfig:128: choice <choice> contains symbol IA64_HP_SIM
> > >>> arch/ia64/Kconfig:202: symbol IA64_HP_SIM is part of choice PM
> > >>>
> > >>> IA64_HP_SIM is both a choice and is selected.
> > >>>
> > >>> I did allyesconfig and disabled PCI afterwards to find all the issues
> > >>> on this patchset.
> > >> Are you saying there's a newer series that fixes this issue for both
> > >> allyesconfig and allmodconfig?
> > >>
> > >> if yes, then we're good.
> > >
> > > No, I haven't fixed ia64 kconfig issue. That's somebody else's job. I
> > > used allyesconfig to find out all compilation issues on x86 arch to
> > > come up with this patchset.
> >
> > Nothing makes me cringe more than "somebody else's job" statements. In
> > this case, there is obviously a correlation with your ACPI changes since
> > the circular dependency happens because of the ACPI symbol.
> >
> > arch/ia64/Kconfig:126:error: recursive dependency detected!
> > arch/ia64/Kconfig:126: choice <choice> contains symbol IA64_HP_SIM
> > arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice PM
> > kernel/power/Kconfig:144: symbol PM is selected by PM_SLEEP
> > kernel/power/Kconfig:104: symbol PM_SLEEP depends on HIBERNATE_CALLBACKS
> > kernel/power/Kconfig:31: symbol HIBERNATE_CALLBACKS is selected by
> > HIBERNATION
> > kernel/power/Kconfig:34: symbol HIBERNATION depends on SWAP
> > init/Kconfig:250: symbol SWAP depends on BLOCK
> > block/Kconfig:5: symbol BLOCK is selected by UBIFS_FS
> > fs/ubifs/Kconfig:1: symbol UBIFS_FS depends on MISC_FILESYSTEMS
> > fs/Kconfig:220: symbol MISC_FILESYSTEMS is selected by ACPI_APEI
> > drivers/acpi/apei/Kconfig:8: symbol ACPI_APEI depends on ACPI
> > drivers/acpi/Kconfig:9: symbol ACPI depends on ARCH_SUPPORTS_ACPI
> > <<<< LOOK HERE
> > drivers/acpi/Kconfig:6: symbol ARCH_SUPPORTS_ACPI is selected by
> > IA64_HP_SIM
> > arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice <choice>
> >
> > At any rate, a 3 mn git bisect tells me the circular dependency is
> > exposed by this change:
> >
> > f3fd6cd74fedf99b6060f75df00943fda13b65f2 is the first bad commit
> > commit f3fd6cd74fedf99b6060f75df00943fda13b65f2
> > Author: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> > Date: Sat Dec 8 12:21:38 2018 +0530
> >
> > fscrypt: remove filesystem specific build config option
> >
> > In order to have a common code base for fscrypt "post read" processing
> > for all filesystems which support encryption, this commit removes
> > filesystem specific build config option (e.g.
> > CONFIG_EXT4_FS_ENCRYPTION)
> > and replaces it with a build option (i.e. CONFIG_FS_ENCRYPTION) whose
> > value affects all the filesystems making use of fscrypt.
> >
> > Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> >
>
> FWIW, The patch at https://patchwork.kernel.org/patch/10725883/ fixes this
> problem by removing "select BLOCK if FS_ENCRYPTION" from fs/ubifs/Kconfig.
OK
Pierre-Louis, can you check if this patch makes the issue go away for
you, please?
next prev parent reply other threads:[~2019-01-03 9:52 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190102181038.4418-1-okaya@kernel.org>
2019-01-02 18:10 ` [PATCH v5 01/11] ACPI / LPSS: Make PCI dependency explicit Sinan Kaya
2019-01-02 18:10 ` Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 02/11] ata: pata_acpi: " Sinan Kaya
2019-01-02 18:10 ` Sinan Kaya
2019-01-07 11:12 ` Rafael J. Wysocki
2019-01-07 11:12 ` Rafael J. Wysocki
[not found] ` <CGME20190107141740eucas1p15f2975c3d87e7a8fce9daeaea41525d4@eucas1p1.samsung.com>
2019-01-07 14:17 ` Bartlomiej Zolnierkiewicz
2019-01-07 14:17 ` Bartlomiej Zolnierkiewicz
2019-01-07 15:41 ` Jens Axboe
2019-01-07 15:41 ` Jens Axboe
2019-01-07 17:52 ` Rafael J. Wysocki
2019-01-07 17:52 ` Rafael J. Wysocki
2019-01-02 18:10 ` [PATCH v5 03/11] vga-switcheroo: make " Sinan Kaya
2019-01-02 18:10 ` Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 04/11] platform/x86: intel_ips: " Sinan Kaya
2019-01-02 18:10 ` Sinan Kaya
2019-01-04 14:13 ` Andy Shevchenko
2019-01-02 18:10 ` [PATCH v5 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
2019-01-02 18:10 ` Sinan Kaya
2019-01-04 14:20 ` Andy Shevchenko
2019-01-04 14:20 ` Andy Shevchenko
2019-01-04 15:07 ` Sinan Kaya
2019-01-04 15:07 ` Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 06/11] platform/x86: apple-gmux: " Sinan Kaya
2019-01-02 18:10 ` Sinan Kaya
2019-01-02 18:45 ` Lukas Wunner
2019-01-02 18:45 ` Lukas Wunner
2019-01-04 14:12 ` Andy Shevchenko
2019-01-04 14:20 ` Andy Shevchenko
2019-01-02 18:10 ` [PATCH v5 07/11] drivers: thermal: int3406_thermal: " Sinan Kaya
2019-01-02 18:10 ` Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 08/11] ASoC: Intel: atom: " Sinan Kaya
2019-01-02 18:10 ` Sinan Kaya
2019-01-02 20:33 ` [alsa-devel] " Pierre-Louis Bossart
2019-01-02 22:01 ` Rafael J. Wysocki
2019-01-02 22:01 ` [alsa-devel] " Rafael J. Wysocki
2019-01-02 22:09 ` Sinan Kaya
2019-01-02 22:50 ` Pierre-Louis Bossart
2019-01-02 22:58 ` Sinan Kaya
2019-01-02 23:50 ` Pierre-Louis Bossart
2019-01-03 3:28 ` Sinan Kaya
2019-01-03 4:08 ` Chandan Rajendra
2019-01-03 9:52 ` Rafael J. Wysocki [this message]
2019-01-03 16:28 ` Pierre-Louis Bossart
2019-01-03 16:28 ` [alsa-devel] " Pierre-Louis Bossart
2019-01-04 10:55 ` Chandan Rajendra
2019-01-03 12:33 ` Mark Brown
2019-01-03 12:33 ` Mark Brown
2019-01-03 12:43 ` Rafael J. Wysocki
2019-01-03 12:43 ` Rafael J. Wysocki
2019-01-02 18:10 ` [PATCH v5 09/11] mmc: sdhci-acpi: " Sinan Kaya
2019-01-02 18:10 ` Sinan Kaya
2019-01-03 14:49 ` Adrian Hunter
2019-01-03 14:49 ` Adrian Hunter
2019-01-03 14:57 ` Sinan Kaya
2019-01-03 14:57 ` Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 10/11] x86/intel/lpss: " Sinan Kaya
2019-01-02 18:10 ` Sinan Kaya
2019-01-11 18:36 ` [tip:x86/urgent] " tip-bot for Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 11/11] drivers: thermal: int340x_thermal: " Sinan Kaya
2019-01-02 18:10 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0j=i_YN7szXLV8cKLp2XmoqUTQR6EJhRJhWFJzenhzM9Q@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=Okaya@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=chandan@linux.ibm.com \
--cc=chandan@linux.vnet.ibm.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=tytso@google.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.