From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF34DC17442 for ; Wed, 13 Nov 2019 10:20:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7CBB206B6 for ; Wed, 13 Nov 2019 10:20:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573640452; bh=aFsBOvHVyME8LY3ePTW/JWDZQv8QeWFSB0xthmKTJ4c=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=lulxUlH/NwngnYTpiiqwB94141L+VFmtfLjWdkS41gQU73r7umhrqoQA3sn6O9bbb Qss5JQsAUaa5FR0ToY0nVERNnxiOPvtYcLBs4/tTWXuupLz5lIpoDFf+ZgHfViGccd 33yzNjAMgeetbloBidU6Ox4nUz9zUHaYxwTHfx68= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726340AbfKMKUw (ORCPT ); Wed, 13 Nov 2019 05:20:52 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:35383 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726107AbfKMKUv (ORCPT ); Wed, 13 Nov 2019 05:20:51 -0500 Received: by mail-ot1-f65.google.com with SMTP id z6so1157246otb.2; Wed, 13 Nov 2019 02:20:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7Lvja61wwJEkxFUoNesZ7CUJfOp6AZA3UJFpr6tZxyM=; b=Vahx1NVOfVngUdWpiVbr8W7QMs1jlP9JWvUBvMyttiC9/GvubEkW0+uiJUPe9tZxwG 7dINTQlveyGH9wxuZ1ecFRwDc237Wo/kq9KHsACePsL+VXOi80zOxGOYPDJrq3w2WPe8 HlW9zN2uwxv3Lz6GteEbLf8Bt2Vb/dT89PFnBXulIA58i1/ek/GU0pLpyixsYlVEcKoo o7siEm6oPxQ0V4QHjnMTrt7F+FI9mI7B/bvqHT7L3m6K9fjm9FDVP0KDG6bcZQuegrCW RplF6Td/GKT+rMwra1pqHLn2pjK3GVH2IBu86ZCs14ohBPUMuqLq9hGKwSh9G5dim9rp +/yQ== X-Gm-Message-State: APjAAAXU3eaX7kiIe7J/PjQV5xBoodCGZlbWmqQvVW3dlQQ/DuhMfV8Y UEsO+dz5CnV+gR1njp4OLmVgpbN9FmpezhmuIfY= X-Google-Smtp-Source: APXvYqx7+iaSr/YFYkN/OL/jLYa0u92ocpHWjpBLM/QT3evJcxb2dZgQ4dGsiKKKGXO464GduvcJf5QQBQnKxv9uLdE= X-Received: by 2002:a9d:7d01:: with SMTP id v1mr2015836otn.167.1573640449727; Wed, 13 Nov 2019 02:20:49 -0800 (PST) MIME-Version: 1.0 References: <20191113023559.62295-1-saravanak@google.com> <20191113023559.62295-2-saravanak@google.com> In-Reply-To: <20191113023559.62295-2-saravanak@google.com> From: "Rafael J. Wysocki" Date: Wed, 13 Nov 2019 11:20:38 +0100 Message-ID: Subject: Re: [PATCH v1] driver core: Clarify documentation for fwnode_operations.add_links() To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , "Rafael J. Wysocki" , Len Brown , "Cc: Android Kernel" , Linux Kernel Mailing List , ACPI Devel Maling List Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Nov 13, 2019 at 3:36 AM Saravana Kannan wrote: > > The wording was a bit ambiguous. So update it to make it clear. > > Signed-off-by: Saravana Kannan Looks better with this change IMO: Reviewed-by: Rafael J. Wysocki > --- > include/linux/fwnode.h | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h > index 766ff9bb5876..23df37f85398 100644 > --- a/include/linux/fwnode.h > +++ b/include/linux/fwnode.h > @@ -94,15 +94,16 @@ struct fwnode_reference_args { > * available suppliers. > * > * Return 0 if device links have been successfully created to all > - * the suppliers this device needs to create device links to or if > - * the supplier information is not known. > + * the known suppliers of this device or if the supplier > + * information is not known. > * > - * Return -ENODEV if and only if the suppliers needed for probing > - * the device are not yet available to create device links to. > + * Return -ENODEV if the suppliers needed for probing this device > + * have not been registered yet (because device links can only be > + * created to devices registered with the driver core). > * > - * Return -EAGAIN if there are suppliers that need to be linked to > - * that are not yet available but none of those suppliers are > - * necessary for probing this device. > + * Return -EAGAIN if some of the suppliers of this device have not > + * been registered yet, but none of those suppliers are necessary > + * for probing the device. > */ > struct fwnode_operations { > struct fwnode_handle *(*get)(struct fwnode_handle *fwnode); > -- > 2.24.0.rc1.363.gb1bccd3e3d-goog >