Re: [PATCH] ACPI: tables: Add custom DSDT file as makefile prerequisite

From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	patches@opensource.cirrus.com
Subject: Re: [PATCH] ACPI: tables: Add custom DSDT file as makefile prerequisite
Date: Wed, 23 Jun 2021 19:32:58 +0200	[thread overview]
Message-ID: <CAJZ5v0jBk9LnimOPRgVOof-DJp4rqfto31+nFv8gzmsQ1jUB=A@mail.gmail.com> (raw)
In-Reply-To: <20210621152433.29716-1-rf@opensource.cirrus.com>

On Mon, Jun 21, 2021 at 5:24 PM Richard Fitzgerald
<rf@opensource.cirrus.com> wrote:
>
> A custom DSDT file is mostly used during development or debugging,
> and in that case it is quite likely to want to rebuild the kernel
> after changing ONLY the content of the DSDT.
>
> This patch adds the custom DSDT as a prerequisite to tables.o
> to ensure a rebuild if the DSDT file is updated. Make will merge
> the prerequisites from multiple rules for the same target.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
> ---
>  drivers/acpi/Makefile | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
> index efb0d1f64019..ceb1aed4b1fc 100644
> --- a/drivers/acpi/Makefile
> +++ b/drivers/acpi/Makefile
> @@ -8,6 +8,11 @@ ccflags-$(CONFIG_ACPI_DEBUG)   += -DACPI_DEBUG_OUTPUT
>  #
>  # ACPI Boot-Time Table Parsing
>  #
> +ifeq ($(CONFIG_ACPI_CUSTOM_DSDT),y)
> +tables.o: $(src)/../../include/$(subst $\",,$(CONFIG_ACPI_CUSTOM_DSDT_FILE)) ;
> +
> +endif
> +
>  obj-$(CONFIG_ACPI)             += tables.o
>  obj-$(CONFIG_X86)              += blacklist.o
>
> --

Applied as 5.14 material, thanks!