From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6D4BC433E1 for ; Wed, 26 Aug 2020 16:42:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9189B206FA for ; Wed, 26 Aug 2020 16:42:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598460127; bh=K0KRjosCNihhIUjy2CzAbSeunhdWGQrDEtxgSqHeoew=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=NaERnEFO6bGudC+mdeQPWn66aCPmfgGNPsTBoh8MOVR1DYsFd8HAwJUZi7W/dxVj6 Wlsct1/pjKbPmrJPgqhI7/ymbxewbPgZyPA1lhLSIe3bGm2kcj6/Gf5KST0Kb08O+6 dXU5MLJ+41XXgh1aocvDErkLiCAgNh5iEks/2ZKU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727973AbgHZQmF (ORCPT ); Wed, 26 Aug 2020 12:42:05 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:43431 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726788AbgHZQl4 (ORCPT ); Wed, 26 Aug 2020 12:41:56 -0400 Received: by mail-oi1-f195.google.com with SMTP id j21so2056131oii.10; Wed, 26 Aug 2020 09:41:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wsy5zXuBQviVStdVeCGrMTAX227JSl/kynJ+bRrUqhw=; b=uL0EDsf6hJ5sYmTPNDda8Fn3aZoHQUNP/ul1Zg2uDqq8fYYbtzvot0ih3lIrn/Y9pB g82NPkvOgM3zldlh9M67dEQi3MaMJjxny7+jZYgmcuZmtPOwzoKqFdmbyiZoSkTBRdgJ ykan7vd4zD6+4pUMcAad6pefnvPiPMVNMChZC0WFZoPLukictI+qb8OIVNDQiNN7zc3K 3JHxX2lW86AO8oXWpdVvsF4iGom1xgGZ1l4XedbGEQbfw7GFLnzkYuF6yjyZ5KWyMTO0 lzB04jzWn0AcdB2+iixkegKEBzH/fysOj+H3WFszyvWxpthM+9wEz0gETrlZ5+5EBWpL gs3w== X-Gm-Message-State: AOAM531YtMLODrgjU0sIfxFAWcXIwqop//BQHCZd16o1H1k/82iDZqH8 JYjcsPTY3dhjMAn2R/vAUE6We+cGhbOSWinDqw8= X-Google-Smtp-Source: ABdhPJy2nXYl0RJfHQH7KCX/v6XWxgIJw5+i8hypA0vKnYTy4GFLpfksuMvG0V355VFbpomGojLtzxqFcnWQisTKKjo= X-Received: by 2002:aca:3e8b:: with SMTP id l133mr1553553oia.110.1598460115467; Wed, 26 Aug 2020 09:41:55 -0700 (PDT) MIME-Version: 1.0 References: <20200826120421.44356-1-guilhem@barpilot.io> <8fa7622dacc03f2fbd67e810f53389e3ede544e8.camel@intel.com> <72fab2376722c6169549669016933217d3da34a0.camel@gmail.com> In-Reply-To: <72fab2376722c6169549669016933217d3da34a0.camel@gmail.com> From: "Rafael J. Wysocki" Date: Wed, 26 Aug 2020 18:41:44 +0200 Message-ID: Subject: Re: [PATCH] intel_idle: Add ICL support To: Artem Bityutskiy Cc: Guilhem Lettron , Zhang Rui , "Rafael J. Wysocki" , Jacob Pan , Len Brown , Linux PM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 26, 2020 at 6:19 PM Artem Bityutskiy wrote: > > Indeed, when I compare them: > > acpi_idle (without the patch): Does this come from the Guilhem's data? It's intel_idle in both cases, but in the "without the patch" case it uses ACPI. > CPU%c1 CPU%c6 CPU%c7 CoreTmp PkgTmp GFX%rc6 Pkg%pc2 Pkg%pc3 Pkg%pc6 Pkg%pc7 Pkg%pc8 Pkg%pc9 Pk%pc10 PkgWatt > 29.48 0.00 60.71 58 58 97.96 16.96 0.00 0.00 0.00 0.00 0.00 0.00 6.08 and I get the same data here, but > intel_idle (with the patch): > > CPU%c1 CPU%c6 CPU%c7 CoreTmp PkgTmp GFX%rc6 Pkg%pc2 Pkg%pc3 Pkg%pc6 Pkg%pc7 Pkg%pc8 Pkg%pc9 Pk%pc10 PkgWatt > 56 56 96.64 300 68.29 48.58 0.00 0.00 0.00 0.00 0.00 0.00 7.38 0.00 you seem to have columns wrong here. I get something like this CPU%c1 CPU%c6 CPU%c7 CoreTmp PkgTmp GFX%rc6 GFXMHz Totl%C0 Any%C0 GFX%C0 CPUGFX% Pkg%pc2 Pkg%pc3 Pkg%pc6 Pkg%pc7 Pkg%pc8 Pkg%pc9 Pk%pc10 16.07 26.24 49.10 56 56 96.64 300 68.29 48.58 3.08 2.10 30.36 0.04 0.00 0.00 0.00 0.00 0.00 so still no PC10 residency (and it would be rather strange to get PC10 residency without any PC6 or higher residency). The 7.38 is the PkgWatt number AFAICS. > With intel_idle we reach PC10, without it we only go as deep as PC2 - huge difference. Not really. We don't get any PC10 residency in both cases. > I really wonder why the BIOS does not expose deeper C-states... It does expose C10. > And if it does not, is this for a reason? And how windows works then? It can only expose 3 C-states and it chose to expose C1, C7s and C10. > May be there is a BIOS update that fixes this problem? May be Windows > user get it quickly because stuff like this is often well-integrated in > Windows? Would you please check if there is newer BIOS? I doubt it. Cheers!