From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH V7 07/11] pci, acpi: Handle ACPI companion assignment. Date: Thu, 12 May 2016 13:27:23 +0200 Message-ID: References: <1462893601-8937-1-git-send-email-tn@semihalf.com> <1462893601-8937-8-git-send-email-tn@semihalf.com> <20160511101101.GA16101@red-moon> <20160511224314.GD28812@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:35843 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932372AbcELL1a (ORCPT ); Thu, 12 May 2016 07:27:30 -0400 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Jayachandran C Cc: Bjorn Helgaas , "Rafael J. Wysocki" , Lorenzo Pieralisi , Tomasz Nowicki , Arnd Bergmann , Will Deacon , Catalin Marinas , Hanjun Guo , Sinan Kaya , robert.richter@caviumnetworks.com, Marcin Wojtas , Liviu.Dudau@arm.com, David Daney , Wangyijing , Suravee Suthikulanit , Mark Salter , Linux PCI , "linux-arm-kernel@lists.infradead.org" , ACPI Devel Maling List , Linux Kernel Mailing List , "linaro-acpi@lists.linaro.org" On Thu, May 12, 2016 at 12:43 PM, Jayachandran C wrote: > On Thu, May 12, 2016 at 4:13 AM, Bjorn Helgaas wrote: >> On Wed, May 11, 2016 at 10:30:51PM +0200, Rafael J. Wysocki wrote: >>> On Wed, May 11, 2016 at 12:11 PM, Lorenzo Pieralisi >>> wrote: >>> > On Tue, May 10, 2016 at 08:37:00PM +0200, Rafael J. Wysocki wrote: >>> >> On Tue, May 10, 2016 at 5:19 PM, Tomasz Nowicki wrote: [cut] > > If we are moving the ACPI/PCI code from drivers/acpi to > arch/arm64/ , there is an issue in having the header file > ecam.h in drivers/pci > > The current include of "../pci/ecam.h" is slightly ugly (Arnd > and David had already noted this), but including the driver > header from arch code would be even worse. > > I can either merge ecam.h into include/linux/pci.h > or move it to a new file include/linux/pci-ecam.h, any > suggestion on which is preferable? My preference would be pci-ecam.h as we did a similar thing for pci-dma.h, for example, but basically this is up to Bjorn. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932499AbcELL1g (ORCPT ); Thu, 12 May 2016 07:27:36 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35843 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932372AbcELL1a (ORCPT ); Thu, 12 May 2016 07:27:30 -0400 MIME-Version: 1.0 In-Reply-To: References: <1462893601-8937-1-git-send-email-tn@semihalf.com> <1462893601-8937-8-git-send-email-tn@semihalf.com> <20160511101101.GA16101@red-moon> <20160511224314.GD28812@localhost> Date: Thu, 12 May 2016 13:27:23 +0200 X-Google-Sender-Auth: dJKiAWwSnAJFBgMcqv9rMnRwpmg Message-ID: Subject: Re: [PATCH V7 07/11] pci, acpi: Handle ACPI companion assignment. From: "Rafael J. Wysocki" To: Jayachandran C Cc: Bjorn Helgaas , "Rafael J. Wysocki" , Lorenzo Pieralisi , Tomasz Nowicki , Arnd Bergmann , Will Deacon , Catalin Marinas , Hanjun Guo , Sinan Kaya , robert.richter@caviumnetworks.com, Marcin Wojtas , Liviu.Dudau@arm.com, David Daney , Wangyijing , Suravee Suthikulanit , Mark Salter , Linux PCI , "linux-arm-kernel@lists.infradead.org" , ACPI Devel Maling List , Linux Kernel Mailing List , "linaro-acpi@lists.linaro.org" , Jon Masters , Andrea Gallo , Duc Dang , jeremy.linton@arm.com, liudongdong3@huawei.com, Christopher Covington Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2016 at 12:43 PM, Jayachandran C wrote: > On Thu, May 12, 2016 at 4:13 AM, Bjorn Helgaas wrote: >> On Wed, May 11, 2016 at 10:30:51PM +0200, Rafael J. Wysocki wrote: >>> On Wed, May 11, 2016 at 12:11 PM, Lorenzo Pieralisi >>> wrote: >>> > On Tue, May 10, 2016 at 08:37:00PM +0200, Rafael J. Wysocki wrote: >>> >> On Tue, May 10, 2016 at 5:19 PM, Tomasz Nowicki wrote: [cut] > > If we are moving the ACPI/PCI code from drivers/acpi to > arch/arm64/ , there is an issue in having the header file > ecam.h in drivers/pci > > The current include of "../pci/ecam.h" is slightly ugly (Arnd > and David had already noted this), but including the driver > header from arch code would be even worse. > > I can either merge ecam.h into include/linux/pci.h > or move it to a new file include/linux/pci-ecam.h, any > suggestion on which is preferable? My preference would be pci-ecam.h as we did a similar thing for pci-dma.h, for example, but basically this is up to Bjorn. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: MIME-Version: 1.0 Sender: rjwysocki@gmail.com In-Reply-To: References: <1462893601-8937-1-git-send-email-tn@semihalf.com> <1462893601-8937-8-git-send-email-tn@semihalf.com> <20160511101101.GA16101@red-moon> <20160511224314.GD28812@localhost> Date: Thu, 12 May 2016 13:27:23 +0200 Message-ID: Subject: Re: [PATCH V7 07/11] pci, acpi: Handle ACPI companion assignment. From: "Rafael J. Wysocki" To: Jayachandran C Cc: Bjorn Helgaas , "Rafael J. Wysocki" , Lorenzo Pieralisi , Tomasz Nowicki , Arnd Bergmann , Will Deacon , Catalin Marinas , Hanjun Guo , Sinan Kaya , robert.richter@caviumnetworks.com, Marcin Wojtas , Liviu.Dudau@arm.com, David Daney , Wangyijing , Suravee Suthikulanit , Mark Salter , Linux PCI , "linux-arm-kernel@lists.infradead.org" , ACPI Devel Maling List , Linux Kernel Mailing List , "linaro-acpi@lists.linaro.org" , Jon Masters , Andrea Gallo , Duc Dang , jeremy.linton@arm.com, liudongdong3@huawei.com, Christopher Covington Content-Type: text/plain; charset=UTF-8 List-ID: On Thu, May 12, 2016 at 12:43 PM, Jayachandran C wrote: > On Thu, May 12, 2016 at 4:13 AM, Bjorn Helgaas wrote: >> On Wed, May 11, 2016 at 10:30:51PM +0200, Rafael J. Wysocki wrote: >>> On Wed, May 11, 2016 at 12:11 PM, Lorenzo Pieralisi >>> wrote: >>> > On Tue, May 10, 2016 at 08:37:00PM +0200, Rafael J. Wysocki wrote: >>> >> On Tue, May 10, 2016 at 5:19 PM, Tomasz Nowicki wrote: [cut] > > If we are moving the ACPI/PCI code from drivers/acpi to > arch/arm64/ , there is an issue in having the header file > ecam.h in drivers/pci > > The current include of "../pci/ecam.h" is slightly ugly (Arnd > and David had already noted this), but including the driver > header from arch code would be even worse. > > I can either merge ecam.h into include/linux/pci.h > or move it to a new file include/linux/pci-ecam.h, any > suggestion on which is preferable? My preference would be pci-ecam.h as we did a similar thing for pci-dma.h, for example, but basically this is up to Bjorn. From mboxrd@z Thu Jan 1 00:00:00 1970 From: rafael@kernel.org (Rafael J. Wysocki) Date: Thu, 12 May 2016 13:27:23 +0200 Subject: [PATCH V7 07/11] pci, acpi: Handle ACPI companion assignment. In-Reply-To: References: <1462893601-8937-1-git-send-email-tn@semihalf.com> <1462893601-8937-8-git-send-email-tn@semihalf.com> <20160511101101.GA16101@red-moon> <20160511224314.GD28812@localhost> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, May 12, 2016 at 12:43 PM, Jayachandran C wrote: > On Thu, May 12, 2016 at 4:13 AM, Bjorn Helgaas wrote: >> On Wed, May 11, 2016 at 10:30:51PM +0200, Rafael J. Wysocki wrote: >>> On Wed, May 11, 2016 at 12:11 PM, Lorenzo Pieralisi >>> wrote: >>> > On Tue, May 10, 2016 at 08:37:00PM +0200, Rafael J. Wysocki wrote: >>> >> On Tue, May 10, 2016 at 5:19 PM, Tomasz Nowicki wrote: [cut] > > If we are moving the ACPI/PCI code from drivers/acpi to > arch/arm64/ , there is an issue in having the header file > ecam.h in drivers/pci > > The current include of "../pci/ecam.h" is slightly ugly (Arnd > and David had already noted this), but including the driver > header from arch code would be even worse. > > I can either merge ecam.h into include/linux/pci.h > or move it to a new file include/linux/pci-ecam.h, any > suggestion on which is preferable? My preference would be pci-ecam.h as we did a similar thing for pci-dma.h, for example, but basically this is up to Bjorn.