From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932911AbcJUMr0 (ORCPT ); Fri, 21 Oct 2016 08:47:26 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:35083 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753916AbcJUMrZ (ORCPT ); Fri, 21 Oct 2016 08:47:25 -0400 MIME-Version: 1.0 In-Reply-To: <1475652794-4486-2-git-send-email-daniel.lezcano@linaro.org> References: <1475652794-4486-1-git-send-email-daniel.lezcano@linaro.org> <1475652794-4486-2-git-send-email-daniel.lezcano@linaro.org> From: "Rafael J. Wysocki" Date: Fri, 21 Oct 2016 14:47:22 +0200 X-Google-Sender-Auth: zXAIbbUyxE6fXi2H4oOMkQEOxrE Message-ID: Subject: Re: [PATCH 2/2] cpuidle: governors: Move the files to the upper directory To: Daniel Lezcano Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Linux PM Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 5, 2016 at 9:33 AM, Daniel Lezcano wrote: > Currently the different governors are stored in the subdir > 'governors'. That is not a problem. > > However, that forces to declare some private structure in the > include/linux/cpuidle.h header because these governor files > don't have access to the private 'cpuidle.h' located in > drivers/cpuidle. > > Instead of having the governors in the separate directory, move > them along with the drivers and prefix them with 'governor-', > that allows to do a proper cleanup in the cpuidle headers. While I'm not particularly against this change, I'm sort of wondering about the reason. What in particular would be wrong with doing #include "../cpuidle.h" in a governor .c file? Thanks, Rafael