From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] ACPI / tables: Return error from table parse handler Date: Thu, 19 May 2016 23:17:58 +0200 Message-ID: References: <1463676667-17945-1-git-send-email-mbrugger@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:32902 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753523AbcESVSA (ORCPT ); Thu, 19 May 2016 17:18:00 -0400 In-Reply-To: <1463676667-17945-1-git-send-email-mbrugger@suse.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Matthias Brugger Cc: "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Linux Kernel Mailing List On Thu, May 19, 2016 at 6:51 PM, Matthias Brugger wrote: > The handler called in acpi_table_parse may return an error. > This patch returns this error instead of ignoring it. And does it address any particular practical problem or is it just a code cleanup? > Signed-off-by: Matthias Brugger > --- > drivers/acpi/tables.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c > index a372f9e..fb5cd80 100644 > --- a/drivers/acpi/tables.c > +++ b/drivers/acpi/tables.c > @@ -394,6 +394,7 @@ int __init acpi_table_parse(char *id, acpi_tbl_table_handler handler) > { > struct acpi_table_header *table = NULL; > acpi_size tbl_size; > + int ret; > > if (acpi_disabled) > return -ENODEV; > @@ -407,9 +408,9 @@ int __init acpi_table_parse(char *id, acpi_tbl_table_handler handler) > acpi_get_table_with_size(id, 0, &table, &tbl_size); > > if (table) { > - handler(table); > + ret = handler(table); > early_acpi_os_unmap_memory(table, tbl_size); > - return 0; > + return ret; > } else > return -ENODEV; > } > --