From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C53A3C4332F for ; Fri, 17 Dec 2021 17:19:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239801AbhLQRTl (ORCPT ); Fri, 17 Dec 2021 12:19:41 -0500 Received: from mail-ot1-f42.google.com ([209.85.210.42]:36472 "EHLO mail-ot1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239802AbhLQRTa (ORCPT ); Fri, 17 Dec 2021 12:19:30 -0500 Received: by mail-ot1-f42.google.com with SMTP id w6-20020a9d77c6000000b0055e804fa524so3732980otl.3; Fri, 17 Dec 2021 09:19:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0Zx+iGaRJx7HOeobGJtBFJYWR+l1UjgQTuzqvPExFxA=; b=OBKyvldax38jIlnpPKhTu9pbhs2ZETjR7ogsPt3bO3Ymd46sSl57RxVPjCgmT1mEKX UNUOxcwoR9PU2lRjIAK6AveJ+Bi+xipAk03oCKATotrUZRVqTcQUz9PQdYhbxJ6bf9QB qj1SRf6RXsL60ShJXqgXDPWsDM68mF8NJdVItTw7wApSRFnntebdVnAiHHgJdP4cN18k ihVHiIlB2ntJ8wpPWZZXFhJCrjaWz1pTGP59aVbJkOA0YEpSq1Nb0sK0TdAM1xJj+ksV CqjhxdVnN7PAFB/MEon1I83NUkWkNLoYzxM0i79GP0ygm0uIijztHk73/57kgnurlJr9 3U9w== X-Gm-Message-State: AOAM5328tmSprvYRfpn48pOrg6ranNKvtWyz+WDx9TOTHXqYaQGTzs9s dbnUo5ic3im3fTL8jHhyKbRDrE12u37i4G+1jS8= X-Google-Smtp-Source: ABdhPJztoPqn/1Su9cfXcuaCyeozUoTqwJGGdS30ToTcoGqzV+VCNtcC4Lcb+2ReZtjWo+NLFWB5n59F2HXnfpyLmtU= X-Received: by 2002:a05:6830:348f:: with SMTP id c15mr2958544otu.254.1639761569499; Fri, 17 Dec 2021 09:19:29 -0800 (PST) MIME-Version: 1.0 References: <20211217115708.882525-1-tanureal@opensource.cirrus.com> <20211217115708.882525-9-tanureal@opensource.cirrus.com> In-Reply-To: <20211217115708.882525-9-tanureal@opensource.cirrus.com> From: "Rafael J. Wysocki" Date: Fri, 17 Dec 2021 18:19:18 +0100 Message-ID: Subject: Re: [PATCH v6 08/10] ACPI / scan: Create platform device for CLSA0100 and CSC3551 ACPI nodes To: Lucas Tanure , Hans de Goede Cc: "Rafael J . Wysocki" , Len Brown , Mark Gross , Liam Girdwood , Jaroslav Kysela , Mark Brown , Takashi Iwai , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , ACPI Devel Maling List , patches@opensource.cirrus.com, Platform Driver , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Dec 17, 2021 at 12:57 PM Lucas Tanure wrote: > > The ACPI device with CLSA0100 or CSC3551 is a sound card > with multiple instances of CS35L41 connectec by I2C to "connected" I suppose? > the main CPU. > > We add an ID to the i2c_multi_instantiate_ids list to enumerate > all I2C slaves correctly. > > Signed-off-by: Lucas Tanure This requires an ACK from Hans. If you receive one, please feel free to add my ACK to it too. Thanks! > --- > drivers/acpi/scan.c | 3 +++ > drivers/platform/x86/i2c-multi-instantiate.c | 11 +++++++++++ > 2 files changed, 14 insertions(+) > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > index b7a6b982226e..8740cfa11f59 100644 > --- a/drivers/acpi/scan.c > +++ b/drivers/acpi/scan.c > @@ -1712,8 +1712,11 @@ static bool acpi_device_enumeration_by_parent(struct acpi_device *device) > static const struct acpi_device_id i2c_multi_instantiate_ids[] = { > {"BSG1160", }, > {"BSG2150", }, > + {"CSC3551", }, > {"INT33FE", }, > {"INT3515", }, > + /* Non-conforming _HID for Cirrus Logic already released */ > + {"CLSA0100", }, > {} > }; > > diff --git a/drivers/platform/x86/i2c-multi-instantiate.c b/drivers/platform/x86/i2c-multi-instantiate.c > index 4956a1df5b90..a889789b966c 100644 > --- a/drivers/platform/x86/i2c-multi-instantiate.c > +++ b/drivers/platform/x86/i2c-multi-instantiate.c > @@ -147,6 +147,14 @@ static const struct i2c_inst_data int3515_data[] = { > {} > }; > > +static const struct i2c_inst_data cs35l41_hda[] = { > + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, > + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, > + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, > + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, > + {} > +}; > + > /* > * Note new device-ids must also be added to i2c_multi_instantiate_ids in > * drivers/acpi/scan.c: acpi_device_enumeration_by_parent(). > @@ -154,7 +162,10 @@ static const struct i2c_inst_data int3515_data[] = { > static const struct acpi_device_id i2c_multi_inst_acpi_ids[] = { > { "BSG1160", (unsigned long)bsg1160_data }, > { "BSG2150", (unsigned long)bsg2150_data }, > + { "CSC3551", (unsigned long)cs35l41_hda }, > { "INT3515", (unsigned long)int3515_data }, > + /* Non-conforming _HID for Cirrus Logic already released */ > + { "CLSA0100", (unsigned long)cs35l41_hda }, > { } > }; > MODULE_DEVICE_TABLE(acpi, i2c_multi_inst_acpi_ids); > -- > 2.34.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2AE7C433F5 for ; Fri, 17 Dec 2021 17:20:45 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A97582831; Fri, 17 Dec 2021 18:19:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A97582831 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1639761643; bh=dGZd1VFfh18BGluzxw8/TrTukrhW7Gh3qHbGM2uadp4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=R2qtI8UHF/RWSa2ZftKtp9nHR8p5KaD8rHN4cW9HGdSb4TLKFI2j3VG46XoFOmxs/ PuIuCx8CxVh9gYy1G9ZjBVFGNNy/hklBL67MWwwVpNyAEeeVC4uTvaRGphS9LNJm92 GqlmaMv7/Zg81qPNWPazg/x9xJB9TAgMM8mmCZDI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E1FC7F8047B; Fri, 17 Dec 2021 18:19:38 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B3978F8047C; Fri, 17 Dec 2021 18:19:35 +0100 (CET) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 111DEF80311 for ; Fri, 17 Dec 2021 18:19:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 111DEF80311 Received: by mail-ot1-f45.google.com with SMTP id 35-20020a9d08a6000000b00579cd5e605eso3772000otf.0 for ; Fri, 17 Dec 2021 09:19:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0Zx+iGaRJx7HOeobGJtBFJYWR+l1UjgQTuzqvPExFxA=; b=QGcck8xEBsgBJa1cbBw8EYLKjhrm2lr+9nGH1i8CoDVmalwHZua7Gza65qEoVkfgh0 GYrXbtf77FaQlSH1F4oolTkSYbJgAi/OmE/BPJmExJzoyrGRX4vbe06c4mgG1kgKFcPA 80VR0gdDYs+X95UYcwGyF6ktgADI8FhuRpVS/3Fc9mi8lgXoI6PYlqRfxx+uOqMQScUs VLeC3cHO+HLFsEtDGbtasIip7PR4jXvweZbUdihsqJGECMqRVgs3q97ATOeg8g40W2Xi S/AtJJvuTH+f9LurBcOP5QZXTEiLHWIXnMtENLVr9YW4DYdX8mvzDPpS5K/1E1iVq9nQ q2BQ== X-Gm-Message-State: AOAM530T/Xw5l7TEtO/1Hu00TNFVZJsP1xD2S0Kx5E0R5NAmkVmWiEVh xSx8SKIq7hT85bkXisH/VLfxDeqTr2fatJWF0WM= X-Google-Smtp-Source: ABdhPJztoPqn/1Su9cfXcuaCyeozUoTqwJGGdS30ToTcoGqzV+VCNtcC4Lcb+2ReZtjWo+NLFWB5n59F2HXnfpyLmtU= X-Received: by 2002:a05:6830:348f:: with SMTP id c15mr2958544otu.254.1639761569499; Fri, 17 Dec 2021 09:19:29 -0800 (PST) MIME-Version: 1.0 References: <20211217115708.882525-1-tanureal@opensource.cirrus.com> <20211217115708.882525-9-tanureal@opensource.cirrus.com> In-Reply-To: <20211217115708.882525-9-tanureal@opensource.cirrus.com> From: "Rafael J. Wysocki" Date: Fri, 17 Dec 2021 18:19:18 +0100 Message-ID: Subject: Re: [PATCH v6 08/10] ACPI / scan: Create platform device for CLSA0100 and CSC3551 ACPI nodes To: Lucas Tanure , Hans de Goede Content-Type: text/plain; charset="UTF-8" Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , "Rafael J . Wysocki" , patches@opensource.cirrus.com, Takashi Iwai , Liam Girdwood , Mark Gross , ACPI Devel Maling List , Mark Brown , Platform Driver , Linux Kernel Mailing List , Len Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Dec 17, 2021 at 12:57 PM Lucas Tanure wrote: > > The ACPI device with CLSA0100 or CSC3551 is a sound card > with multiple instances of CS35L41 connectec by I2C to "connected" I suppose? > the main CPU. > > We add an ID to the i2c_multi_instantiate_ids list to enumerate > all I2C slaves correctly. > > Signed-off-by: Lucas Tanure This requires an ACK from Hans. If you receive one, please feel free to add my ACK to it too. Thanks! > --- > drivers/acpi/scan.c | 3 +++ > drivers/platform/x86/i2c-multi-instantiate.c | 11 +++++++++++ > 2 files changed, 14 insertions(+) > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > index b7a6b982226e..8740cfa11f59 100644 > --- a/drivers/acpi/scan.c > +++ b/drivers/acpi/scan.c > @@ -1712,8 +1712,11 @@ static bool acpi_device_enumeration_by_parent(struct acpi_device *device) > static const struct acpi_device_id i2c_multi_instantiate_ids[] = { > {"BSG1160", }, > {"BSG2150", }, > + {"CSC3551", }, > {"INT33FE", }, > {"INT3515", }, > + /* Non-conforming _HID for Cirrus Logic already released */ > + {"CLSA0100", }, > {} > }; > > diff --git a/drivers/platform/x86/i2c-multi-instantiate.c b/drivers/platform/x86/i2c-multi-instantiate.c > index 4956a1df5b90..a889789b966c 100644 > --- a/drivers/platform/x86/i2c-multi-instantiate.c > +++ b/drivers/platform/x86/i2c-multi-instantiate.c > @@ -147,6 +147,14 @@ static const struct i2c_inst_data int3515_data[] = { > {} > }; > > +static const struct i2c_inst_data cs35l41_hda[] = { > + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, > + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, > + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, > + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, > + {} > +}; > + > /* > * Note new device-ids must also be added to i2c_multi_instantiate_ids in > * drivers/acpi/scan.c: acpi_device_enumeration_by_parent(). > @@ -154,7 +162,10 @@ static const struct i2c_inst_data int3515_data[] = { > static const struct acpi_device_id i2c_multi_inst_acpi_ids[] = { > { "BSG1160", (unsigned long)bsg1160_data }, > { "BSG2150", (unsigned long)bsg2150_data }, > + { "CSC3551", (unsigned long)cs35l41_hda }, > { "INT3515", (unsigned long)int3515_data }, > + /* Non-conforming _HID for Cirrus Logic already released */ > + { "CLSA0100", (unsigned long)cs35l41_hda }, > { } > }; > MODULE_DEVICE_TABLE(acpi, i2c_multi_inst_acpi_ids); > -- > 2.34.1 >