From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EF2AC433E1 for ; Mon, 25 May 2020 09:01:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 220A320787 for ; Mon, 25 May 2020 09:01:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590397281; bh=3VN/bUa/MBDwV2iu4hE1Z9d4H5IUUEl7ICGohpy9POU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=tP7lwUQKoxRbBG56JW8kctJhZKpuKWx7n0ZsMN22VuFxdyGcPjENh26y8uaAX0iKS zMaJKjtIrcnn1q0kzrnKI5qn7eXSkU35vJFIElzJR97oz6IY3dp2+NXug7SvaCEgU1 FJTKEq4tkI2bdYLrR47bbvGh7MmvTlNQxOZ89mIM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389217AbgEYJBU (ORCPT ); Mon, 25 May 2020 05:01:20 -0400 Received: from mail-oo1-f66.google.com ([209.85.161.66]:44450 "EHLO mail-oo1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388182AbgEYJBU (ORCPT ); Mon, 25 May 2020 05:01:20 -0400 Received: by mail-oo1-f66.google.com with SMTP id u40so503020ooi.11; Mon, 25 May 2020 02:01:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8vWyA0zi2Dx/7wa6PSD2ADmwVek1tPCdMhKzL6eGG4k=; b=G/RYR+5/V62BiIHj2kXuC7wbWGVi9mHAn+pX2OUjiYnR6BJng7jqwU4lHh6GyCiqjx vypo81n+FIcHwIt+dEoCRcDVB33M15/1Bv2xGPKF4LEuO8KnfIIeLFWxkQ244kwX+FTj +O/t1/5I18qJx8vrIhLJpTeybsRbBQnu3LGCy0/JjOHaDs5PS7ibNZ6BH+Xdb+++H6hw 8r/pgyO50+6ZqVtO0CklDj+JoFhxeoPccGgJIK6Lig8l6I1QZ9TlPafyIe40jYETMh+Q HAmGba/z0GBfkypjjR5+d4okdNsHE2tL37LHPLiLHrU4SToZc1YilL0xj4AP7n/oeLPx P5Fw== X-Gm-Message-State: AOAM530Y3rv1AGhHxzcy1iY5vPTLhw+ma2+Lh5sGJlKPDlIlxOAFtoSD feN071WWN46dcqI2hOt3U4ul59xPR3KALNDdiWg= X-Google-Smtp-Source: ABdhPJyzwX2iVrT6Qd3l9Fgc1FvAqYA6sYZDs1ME68NNegl3tYP9ebp9y13iR7l/9ojM1/K+7pi6N5fpXNoNobI++a0= X-Received: by 2002:a4a:e759:: with SMTP id n25mr12329240oov.75.1590397279123; Mon, 25 May 2020 02:01:19 -0700 (PDT) MIME-Version: 1.0 References: <1590043466-11325-1-git-send-email-sumeet.r.pawnikar@intel.com> In-Reply-To: <1590043466-11325-1-git-send-email-sumeet.r.pawnikar@intel.com> From: "Rafael J. Wysocki" Date: Mon, 25 May 2020 11:01:02 +0200 Message-ID: Subject: Re: [PATCH] powercap: remove unused local MSR define To: Sumeet Pawnikar Cc: "Zhang, Rui" , "Rafael J. Wysocki" , Linux PM , Linux Kernel Mailing List , "Shevchenko, Andriy" , Srinivas Pandruvada Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 21, 2020 at 8:38 AM Sumeet Pawnikar wrote: > > Remove unused PLATFORM_POWER_LIMIT MSR local definition from file > intel_rapl_common.c. This was missed while splitting old RAPL code > intel_rapl.c file into two new files intel_rapl_msr.c and > intel_rapl_common.c as per the commit 3382388d7148 > ("intel_rapl: abstract RAPL common code"). Currently, this #define > entry is being used only in intel_rapl_msr.c file and local definition > present in this file. > > Signed-off-by: Sumeet Pawnikar > Reviewed-by: Andy Shevchenko > --- > drivers/powercap/intel_rapl_common.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c > index eb328655bc01..5527a7c76309 100644 > --- a/drivers/powercap/intel_rapl_common.c > +++ b/drivers/powercap/intel_rapl_common.c > @@ -26,9 +26,6 @@ > #include > #include > > -/* Local defines */ > -#define MSR_PLATFORM_POWER_LIMIT 0x0000065C > - > /* bitmasks for RAPL MSRs, used by primitive access functions */ > #define ENERGY_STATUS_MASK 0xffffffff > > -- Applied as 5.8 material, thanks!