All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Zhang Qilong <zhangqilong3@huawei.com>,
	Linux-PM mailing list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] PM: Add documentation for pm_runtime_resume_and_get()
Date: Thu, 8 Apr 2021 18:00:27 +0200	[thread overview]
Message-ID: <CAJZ5v0jjhF=Xpk_WrAFXkcCh44tnqdy16uBxrPLsRcWO6VX3Ow@mail.gmail.com> (raw)
In-Reply-To: <20210408152209.GA1299604@rowland.harvard.edu>

On Thu, Apr 8, 2021 at 5:22 PM Alan Stern <stern@rowland.harvard.edu> wrote:
>
> Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to
> deal with usage counter") added a new runtime-PM API function without
> adding any documentation for it.

Well, there is a kerneldoc comment which counts as documentation, so
I'd rather say "without updating the documentation in runtime_pm.rst".

> This patch adds the missing documentation.

But otherwise fair enough.

> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> CC: Zhang Qilong <zhangqilong3@huawei.com>
> Fixes: dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
>
> ---
>
>
> [as1954]
>
>
>  Documentation/power/runtime_pm.rst |    4 ++++
>  1 file changed, 4 insertions(+)
>
> Index: usb-devel/Documentation/power/runtime_pm.rst
> ===================================================================
> --- usb-devel.orig/Documentation/power/runtime_pm.rst
> +++ usb-devel/Documentation/power/runtime_pm.rst
> @@ -339,6 +339,10 @@ drivers/base/power/runtime.c and include
>        checked additionally, and -EACCES means that 'power.disable_depth' is
>        different from 0
>
> +  `int pm_runtime_resume_and_get(struct device *dev);`
> +    - run pm_runtime_resume(dev) and if successful, increment the device's
> +      usage counter; return the result of pm_runtime_resume
> +
>    `int pm_request_idle(struct device *dev);`
>      - submit a request to execute the subsystem-level idle callback for the
>        device (the request is represented by a work item in pm_wq); returns 0 on

  reply	other threads:[~2021-04-08 16:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 15:22 [PATCH] PM: Add documentation for pm_runtime_resume_and_get() Alan Stern
2021-04-08 16:00 ` Rafael J. Wysocki [this message]
2021-04-08 16:12   ` Alan Stern
2021-04-08 17:46     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJZ5v0jjhF=Xpk_WrAFXkcCh44tnqdy16uBxrPLsRcWO6VX3Ow@mail.gmail.com' \
    --to=rafael@kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=stern@rowland.harvard.edu \
    --cc=zhangqilong3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.