From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CADE0C432C3 for ; Thu, 21 Nov 2019 11:08:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A305A20708 for ; Thu, 21 Nov 2019 11:08:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574334525; bh=2u05u5yvdV7LFv0UI+rCC49B8G8AxDejzvqEqBPmuUA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=O/HGE5F2lilsu8dl3y8PBjn+NNEHVLRv50rVyJ3wJERVxigc1jjDqbY6Yv26tVTMA 808BWxzSUlT1qCGDUzExehnBzKDf/dK6rtxalVjbB9EXzPrueZcp/Qu7rI3yUfOkrQ 8zTIYunriij+VzhAeBK3UnFdjPaMBcOg3hvKuH3M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727088AbfKULIo (ORCPT ); Thu, 21 Nov 2019 06:08:44 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:45296 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726343AbfKULIo (ORCPT ); Thu, 21 Nov 2019 06:08:44 -0500 Received: by mail-oi1-f194.google.com with SMTP id 14so2763941oir.12; Thu, 21 Nov 2019 03:08:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J3Cy3tfrJiIUlL+D9Jr0kFLFrHhJQwh4Hdb4cuVFpa8=; b=t7izMp7L9m/mc+anZp95DTBPCpW00kdy7F08hqeD+CGRnja1NdfKf05/DPU3sk1eiX 95bD/kg33gi6jU3uBcDk8T63IlASiPOsto3+B4N0peXSJxpLgB0/Ewb7NMnsOLfZFSK5 SSs3K2dluw0O+F9ZkA4VJYo6HC7DtsniL9H3DEFngXLe/GkUUseyMdimjAYIjsN5y7Bl 3W6oBgNF3AxYL9aZ0i7aGzLEjOK+XPUPTem7vS5yqpSoy5lxELXCFEDhiz+BH7o1E9OB HtmzbsQ3O/V18GP0XVsdvuQ3daRYh5cqw5FGWNOaSPDZnlXBWI1AZHz5/1CqJmj1whu4 7e8A== X-Gm-Message-State: APjAAAUjdM2BHdEJLbRv1zRTm6QwvVBU72iAJiPpqiFoKLD53eAXVX/f 5/PfBJ3RA9uf3tazvyVQz2bbnpHLak01agRCSL4= X-Google-Smtp-Source: APXvYqxlqz4qNEUm0jTv4bAaBARGWgCnBqt/66UTTeVhGXft7P2C40EC7WWo0izyYaTsvvvl2QWLzkuMrcwnoaF2ur8= X-Received: by 2002:a05:6808:901:: with SMTP id w1mr7358488oih.57.1574334523139; Thu, 21 Nov 2019 03:08:43 -0800 (PST) MIME-Version: 1.0 References: <20191120115127.GD11621@lahna.fi.intel.com> <20191120120913.GE11621@lahna.fi.intel.com> <20191120151542.GH11621@lahna.fi.intel.com> <20191120155301.GL11621@lahna.fi.intel.com> <20191120162306.GM11621@lahna.fi.intel.com> <20191121101423.GQ11621@lahna.fi.intel.com> In-Reply-To: From: "Rafael J. Wysocki" Date: Thu, 21 Nov 2019 12:08:31 +0100 Message-ID: Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges To: Mika Westerberg Cc: Karol Herbst , "Rafael J. Wysocki" , Bjorn Helgaas , LKML , Lyude Paul , "Rafael J . Wysocki" , Linux PCI , Linux PM , dri-devel , nouveau , Dave Airlie , Mario Limonciello Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 21, 2019 at 12:03 PM Rafael J. Wysocki wrote: > > On Thu, Nov 21, 2019 at 11:14 AM Mika Westerberg > wrote: > > > > On Wed, Nov 20, 2019 at 10:36:31PM +0100, Karol Herbst wrote: > > > with the branch and patch applied: > > > https://gist.githubusercontent.com/karolherbst/03c4c8141b0fa292d781badfa186479e/raw/5c62640afbc57d6e69ea924c338bd2836e770d02/gistfile1.txt > > > > Thanks for testing. Too bad it did not help :( I suppose there is no > > change if you increase the delay to say 1s? > > Well, look at the original patch in this thread. > > What it does is to prevent the device (GPU in this particular case) > from going into a PCI low-power state before invoking AML to power it > down (the AML is still invoked after this patch AFAICS), so why would > that have anything to do with the delays? > > The only reason would be the AML running too early, but that doesn't > seem likely. IMO more likely is that the AML does something which > cannot be done to a device in a PCI low-power state. BTW, I'm wondering if anyone has tried to skip the AML instead of skipping the PCI PM in this case (as of 5.4-rc that would be a similar patch to skip the invocations of __pci_start/complete_power_transition() in pci_set_power_state() for the affected device). From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges Date: Thu, 21 Nov 2019 12:08:31 +0100 Message-ID: References: <20191120115127.GD11621@lahna.fi.intel.com> <20191120120913.GE11621@lahna.fi.intel.com> <20191120151542.GH11621@lahna.fi.intel.com> <20191120155301.GL11621@lahna.fi.intel.com> <20191120162306.GM11621@lahna.fi.intel.com> <20191121101423.GQ11621@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Mika Westerberg Cc: "Rafael J. Wysocki" , Linux PCI , Linux PM , "Rafael J . Wysocki" , LKML , dri-devel , Mario Limonciello , Bjorn Helgaas , nouveau List-Id: nouveau.vger.kernel.org T24gVGh1LCBOb3YgMjEsIDIwMTkgYXQgMTI6MDMgUE0gUmFmYWVsIEouIFd5c29ja2kgPHJhZmFl bEBrZXJuZWwub3JnPiB3cm90ZToKPgo+IE9uIFRodSwgTm92IDIxLCAyMDE5IGF0IDExOjE0IEFN IE1pa2EgV2VzdGVyYmVyZwo+IDxtaWthLndlc3RlcmJlcmdAaW50ZWwuY29tPiB3cm90ZToKPiA+ Cj4gPiBPbiBXZWQsIE5vdiAyMCwgMjAxOSBhdCAxMDozNjozMVBNICswMTAwLCBLYXJvbCBIZXJi c3Qgd3JvdGU6Cj4gPiA+IHdpdGggdGhlIGJyYW5jaCBhbmQgcGF0Y2ggYXBwbGllZDoKPiA+ID4g aHR0cHM6Ly9naXN0LmdpdGh1YnVzZXJjb250ZW50LmNvbS9rYXJvbGhlcmJzdC8wM2M0YzgxNDFi MGZhMjkyZDc4MWJhZGZhMTg2NDc5ZS9yYXcvNWM2MjY0MGFmYmM1N2Q2ZTY5ZWE5MjRjMzM4YmQy ODM2ZTc3MGQwMi9naXN0ZmlsZTEudHh0Cj4gPgo+ID4gVGhhbmtzIGZvciB0ZXN0aW5nLiBUb28g YmFkIGl0IGRpZCBub3QgaGVscCA6KCBJIHN1cHBvc2UgdGhlcmUgaXMgbm8KPiA+IGNoYW5nZSBp ZiB5b3UgaW5jcmVhc2UgdGhlIGRlbGF5IHRvIHNheSAxcz8KPgo+IFdlbGwsIGxvb2sgYXQgdGhl IG9yaWdpbmFsIHBhdGNoIGluIHRoaXMgdGhyZWFkLgo+Cj4gV2hhdCBpdCBkb2VzIGlzIHRvIHBy ZXZlbnQgdGhlIGRldmljZSAoR1BVIGluIHRoaXMgcGFydGljdWxhciBjYXNlKQo+IGZyb20gZ29p bmcgaW50byBhIFBDSSBsb3ctcG93ZXIgc3RhdGUgYmVmb3JlIGludm9raW5nIEFNTCB0byBwb3dl ciBpdAo+IGRvd24gKHRoZSBBTUwgaXMgc3RpbGwgaW52b2tlZCBhZnRlciB0aGlzIHBhdGNoIEFG QUlDUyksIHNvIHdoeSB3b3VsZAo+IHRoYXQgaGF2ZSBhbnl0aGluZyB0byBkbyB3aXRoIHRoZSBk ZWxheXM/Cj4KPiBUaGUgb25seSByZWFzb24gd291bGQgYmUgdGhlIEFNTCBydW5uaW5nIHRvbyBl YXJseSwgYnV0IHRoYXQgZG9lc24ndAo+IHNlZW0gbGlrZWx5LiAgSU1PIG1vcmUgbGlrZWx5IGlz IHRoYXQgdGhlIEFNTCBkb2VzIHNvbWV0aGluZyB3aGljaAo+IGNhbm5vdCBiZSBkb25lIHRvIGEg ZGV2aWNlIGluIGEgUENJIGxvdy1wb3dlciBzdGF0ZS4KCkJUVywgSSdtIHdvbmRlcmluZyBpZiBh bnlvbmUgaGFzIHRyaWVkIHRvIHNraXAgdGhlIEFNTCBpbnN0ZWFkIG9mCnNraXBwaW5nIHRoZSBQ Q0kgUE0gaW4gdGhpcyBjYXNlIChhcyBvZiA1LjQtcmMgdGhhdCB3b3VsZCBiZSBhIHNpbWlsYXIK cGF0Y2ggdG8gc2tpcCB0aGUgaW52b2NhdGlvbnMgb2YKX19wY2lfc3RhcnQvY29tcGxldGVfcG93 ZXJfdHJhbnNpdGlvbigpIGluIHBjaV9zZXRfcG93ZXJfc3RhdGUoKSBmb3IKdGhlIGFmZmVjdGVk IGRldmljZSkuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Ck5vdXZlYXUgbWFpbGluZyBsaXN0Ck5vdXZlYXVAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vbm91dmVhdQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E705AC432C0 for ; Thu, 21 Nov 2019 11:08:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1AE920656 for ; Thu, 21 Nov 2019 11:08:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1AE920656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0F4F26EDB5; Thu, 21 Nov 2019 11:08:46 +0000 (UTC) Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by gabe.freedesktop.org (Postfix) with ESMTPS id 292226E098; Thu, 21 Nov 2019 11:08:44 +0000 (UTC) Received: by mail-oi1-f193.google.com with SMTP id o12so2778813oic.9; Thu, 21 Nov 2019 03:08:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J3Cy3tfrJiIUlL+D9Jr0kFLFrHhJQwh4Hdb4cuVFpa8=; b=erHjzxwS4JsNP7EcyDNXF1kNzW+1aFjhfXFDOjyE9y+7cv7xqOWIryP7dilG03aYPm gAAcZwC9C0O91xXmEdxyyGS993Y9QhmYni4tolqwWrHK2jNiDNHuCxn82POVzxupv+U1 mZYiWn1XxYtB86tGHGKbiYFgvzhBZBZgqcSovBEnPyeSs5gScNMaVvkyotXeTRY8ibd6 JdTODlvCaJafiIzTxOADF35hqNY1NRp8vHbG9ItJ58930ci2ErRXbtbScFwkIGANOf55 0f8qHP165n4SE1cPvllCoAv1CDFz96vAoH64rgP/yZgMwwCv2M/qbDEmoeOhjbWPeiiG VB9w== X-Gm-Message-State: APjAAAWC0ENf1OFPQQWyovLWgVWq7WdcxupxjFiRmN5wt0b8LFBp33+i W0EAl0DBU/OcGFTQwqtpY3SBfu4Qkcor33TnhgY975Vh X-Google-Smtp-Source: APXvYqxlqz4qNEUm0jTv4bAaBARGWgCnBqt/66UTTeVhGXft7P2C40EC7WWo0izyYaTsvvvl2QWLzkuMrcwnoaF2ur8= X-Received: by 2002:a05:6808:901:: with SMTP id w1mr7358488oih.57.1574334523139; Thu, 21 Nov 2019 03:08:43 -0800 (PST) MIME-Version: 1.0 References: <20191120115127.GD11621@lahna.fi.intel.com> <20191120120913.GE11621@lahna.fi.intel.com> <20191120151542.GH11621@lahna.fi.intel.com> <20191120155301.GL11621@lahna.fi.intel.com> <20191120162306.GM11621@lahna.fi.intel.com> <20191121101423.GQ11621@lahna.fi.intel.com> In-Reply-To: From: "Rafael J. Wysocki" Date: Thu, 21 Nov 2019 12:08:31 +0100 Message-ID: Subject: Re: [PATCH v4] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges To: Mika Westerberg X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karol Herbst , "Rafael J. Wysocki" , Linux PCI , Linux PM , "Rafael J . Wysocki" , LKML , dri-devel , Mario Limonciello , Bjorn Helgaas , nouveau Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191121110831.fhUuq8dszP2EeNiP5hGHHshreQ3MMs3flqVmGFMFobY@z> T24gVGh1LCBOb3YgMjEsIDIwMTkgYXQgMTI6MDMgUE0gUmFmYWVsIEouIFd5c29ja2kgPHJhZmFl bEBrZXJuZWwub3JnPiB3cm90ZToKPgo+IE9uIFRodSwgTm92IDIxLCAyMDE5IGF0IDExOjE0IEFN IE1pa2EgV2VzdGVyYmVyZwo+IDxtaWthLndlc3RlcmJlcmdAaW50ZWwuY29tPiB3cm90ZToKPiA+ Cj4gPiBPbiBXZWQsIE5vdiAyMCwgMjAxOSBhdCAxMDozNjozMVBNICswMTAwLCBLYXJvbCBIZXJi c3Qgd3JvdGU6Cj4gPiA+IHdpdGggdGhlIGJyYW5jaCBhbmQgcGF0Y2ggYXBwbGllZDoKPiA+ID4g aHR0cHM6Ly9naXN0LmdpdGh1YnVzZXJjb250ZW50LmNvbS9rYXJvbGhlcmJzdC8wM2M0YzgxNDFi MGZhMjkyZDc4MWJhZGZhMTg2NDc5ZS9yYXcvNWM2MjY0MGFmYmM1N2Q2ZTY5ZWE5MjRjMzM4YmQy ODM2ZTc3MGQwMi9naXN0ZmlsZTEudHh0Cj4gPgo+ID4gVGhhbmtzIGZvciB0ZXN0aW5nLiBUb28g YmFkIGl0IGRpZCBub3QgaGVscCA6KCBJIHN1cHBvc2UgdGhlcmUgaXMgbm8KPiA+IGNoYW5nZSBp ZiB5b3UgaW5jcmVhc2UgdGhlIGRlbGF5IHRvIHNheSAxcz8KPgo+IFdlbGwsIGxvb2sgYXQgdGhl IG9yaWdpbmFsIHBhdGNoIGluIHRoaXMgdGhyZWFkLgo+Cj4gV2hhdCBpdCBkb2VzIGlzIHRvIHBy ZXZlbnQgdGhlIGRldmljZSAoR1BVIGluIHRoaXMgcGFydGljdWxhciBjYXNlKQo+IGZyb20gZ29p bmcgaW50byBhIFBDSSBsb3ctcG93ZXIgc3RhdGUgYmVmb3JlIGludm9raW5nIEFNTCB0byBwb3dl ciBpdAo+IGRvd24gKHRoZSBBTUwgaXMgc3RpbGwgaW52b2tlZCBhZnRlciB0aGlzIHBhdGNoIEFG QUlDUyksIHNvIHdoeSB3b3VsZAo+IHRoYXQgaGF2ZSBhbnl0aGluZyB0byBkbyB3aXRoIHRoZSBk ZWxheXM/Cj4KPiBUaGUgb25seSByZWFzb24gd291bGQgYmUgdGhlIEFNTCBydW5uaW5nIHRvbyBl YXJseSwgYnV0IHRoYXQgZG9lc24ndAo+IHNlZW0gbGlrZWx5LiAgSU1PIG1vcmUgbGlrZWx5IGlz IHRoYXQgdGhlIEFNTCBkb2VzIHNvbWV0aGluZyB3aGljaAo+IGNhbm5vdCBiZSBkb25lIHRvIGEg ZGV2aWNlIGluIGEgUENJIGxvdy1wb3dlciBzdGF0ZS4KCkJUVywgSSdtIHdvbmRlcmluZyBpZiBh bnlvbmUgaGFzIHRyaWVkIHRvIHNraXAgdGhlIEFNTCBpbnN0ZWFkIG9mCnNraXBwaW5nIHRoZSBQ Q0kgUE0gaW4gdGhpcyBjYXNlIChhcyBvZiA1LjQtcmMgdGhhdCB3b3VsZCBiZSBhIHNpbWlsYXIK cGF0Y2ggdG8gc2tpcCB0aGUgaW52b2NhdGlvbnMgb2YKX19wY2lfc3RhcnQvY29tcGxldGVfcG93 ZXJfdHJhbnNpdGlvbigpIGluIHBjaV9zZXRfcG93ZXJfc3RhdGUoKSBmb3IKdGhlIGFmZmVjdGVk IGRldmljZSkuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==