Re: Help me fix a regression caused by 56b9918490 (PM: sleep: Simplify suspend-to-idle control flow)

["Rafael J. Wysocki" <rafael@kernel.org>]

On Mon, Nov 25, 2019 at 7:27 PM Kenneth R. Crudup <kenny@panix.com> wrote:
>
>
> On Mon, 25 Nov 2019, Rafael J. Wysocki wrote:
>
> > > I'll send you a patch to try for that.
>
> > Appended (untested).
>
> This is promising! I've only tested a handful of suspend cycles, but so far:
>
> - Charging events don't wake it up
> - It suspends with the charger connected
> - Suspend current draw consistently gets to the lowest idle point
> - It always comes back from suspend, even after connecting a charger when suspended
>
> ... IOW, everything just seems to work, and better than before. I just
> remembered why I had to use "ec_no_wakeup" (pre suspend-rework) in the first
> place- this is a convertible and accelerometer events would take the laptop
> out of (and immediately back into) suspend and your rework fixed that but then
> I had the issues listed in my original E-mail.
>
> I'll keep testing it (and the best way to get something to break is to proclaim
> it's "fixed" :), but for now I'm pretty happy with the patch.

Well, so with this patch the problem is at least not reproducible
readily it seems?