From: "Rafael J. Wysocki" <email@example.com> To: Francisco Jerez <firstname.lastname@example.org> Cc: "Rafael J. Wysocki" <email@example.com>, "Rafael J. Wysocki" <firstname.lastname@example.org>, Linux PM <email@example.com>, LKML <firstname.lastname@example.org>, Amit Kucheria <email@example.com>, "Pandruvada, Srinivas" <firstname.lastname@example.org>, Rodrigo Vivi <email@example.com>, Peter Zijlstra <firstname.lastname@example.org> Subject: Re: [PATCH 00/28] PM: QoS: Get rid of unuseful code and rework CPU latency QoS interface Date: Mon, 24 Feb 2020 01:29:10 +0100 [thread overview] Message-ID: <CAJZ5v0jqp7aEh43kUvxyMWxbnEUjUZZ31iHk_oxDdvGM6RTdMw@mail.gmail.com> (raw) In-Reply-To: <email@example.com> On Fri, Feb 21, 2020 at 11:10 PM Francisco Jerez <firstname.lastname@example.org> wrote: > > "Rafael J. Wysocki" <email@example.com> writes: > > > On Thu, Feb 13, 2020 at 9:09 AM Francisco Jerez <firstname.lastname@example.org> wrote: > >> > >> "Rafael J. Wysocki" <email@example.com> writes: > >> > >> > On Thu, Feb 13, 2020 at 1:16 AM Rafael J. Wysocki <firstname.lastname@example.org> wrote: > >> >> > >> >> On Thu, Feb 13, 2020 at 12:31 AM Francisco Jerez <email@example.com> wrote: > >> >> > > > > > [cut] > > > >> > > >> > And BTW, posting patches as RFC is fine even if they have not been > >> > tested. At least you let people know that you work on something this > >> > way, so if they work on changes in the same area, they may take that > >> > into consideration. > >> > > >> > >> Sure, that was going to be the first RFC. > >> > >> > Also if there are objections to your proposal, you may save quite a > >> > bit of time by sending it early. > >> > > >> > It is unfortunate that this series has clashed with the changes that > >> > you were about to propose, but in this particular case in my view it > >> > is better to clean up things and start over. > >> > > >> > >> Luckily it doesn't clash with the second RFC I was meaning to send, > >> maybe we should just skip the first? > > > > Yes, please. > > > >> Or maybe it's valuable as a curiosity anyway? > > > > No, let's just focus on the latest one. > > > > Thanks! > > We don't seem to have reached much of an agreement on the general > direction of RFC2, so I can't really get started with it. Here is RFC1 > for the record: > > https://github.com/curro/linux/commits/intel_pstate-lp-hwp-v10.8-alt Appreciate the link, but that hasn't been posted to linux-pm yet, so there's not much to discuss. And when you post it, please rebase it on top of linux-next. > Specifically the following patch conflicts with this series: > > https://github.com/curro/linux/commit/9a16f35531bbb76d38493da892ece088e31dc2e0 > > Series improves performance-per-watt of GfxBench gl_4 (AKA Car Chase) by > over 15% on my system with the branch above, actual FPS "only" improves > about 5.9% on ICL laptop due to it being very lightly TDP-bound with its > rather huge TDP. The performance of almost every graphics benchmark > I've tried improves significantly with it (a number of SynMark > test-cases are improved by around 40% in perf-per-watt, Egypt > perf-per-watt improves by about 25%). > > Hopefully we can come up with some alternative plan of action. It is very easy to replace the patch above with an alternative one on top of linux-next that will add CPU_RESPONSE_FREQUENCY QoS along the lines of the CPU latency QoS implementation in there without the need restore to global QoS classes. IOW, you don't really need the code that goes away in linux-next to implement what you need. Thanks!
next prev parent reply other threads:[~2020-02-24 0:29 UTC|newest] Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-11 22:51 Rafael J. Wysocki 2020-02-11 22:52 ` [PATCH 01/28] PM: QoS: Drop debugfs interface Rafael J. Wysocki 2020-02-11 22:58 ` [PATCH 02/28] PM: QoS: Drop pm_qos_update_request_timeout() Rafael J. Wysocki 2020-02-11 22:58 ` [PATCH 03/28] PM: QoS: Drop the PM_QOS_SUM QoS type Rafael J. Wysocki 2020-02-11 22:58 ` [PATCH 04/28] PM: QoS: Clean up pm_qos_update_target() and pm_qos_update_flags() Rafael J. Wysocki 2020-02-11 22:58 ` [PATCH 05/28] PM: QoS: Clean up pm_qos_read_value() and pm_qos_get/set_value() Rafael J. Wysocki 2020-02-11 22:59 ` [PATCH 06/28] PM: QoS: Drop iterations over global QoS classes Rafael J. Wysocki 2020-02-11 23:00 ` [PATCH 07/28] PM: QoS: Clean up misc device file operations Rafael J. Wysocki 2020-02-11 23:01 ` [PATCH 08/28] PM: QoS: Redefine struct pm_qos_request and drop struct pm_qos_object Rafael J. Wysocki 2020-02-11 23:02 ` [PATCH 09/28] PM: QoS: Drop PM_QOS_CPU_DMA_LATENCY notifier chain Rafael J. Wysocki 2020-02-11 23:04 ` [PATCH 10/28] PM: QoS: Rename things related to the CPU latency QoS Rafael J. Wysocki 2020-02-12 10:34 ` Rafael J. Wysocki 2020-02-12 19:13 ` Greg Kroah-Hartman 2020-02-11 23:06 ` [PATCH 11/28] PM: QoS: Simplify definitions of CPU latency QoS trace events Rafael J. Wysocki 2020-02-11 23:07 ` [PATCH 12/28] PM: QoS: Adjust pm_qos_request() signature and reorder pm_qos.h Rafael J. Wysocki 2020-02-11 23:07 ` [PATCH 13/28] PM: QoS: Add CPU latency QoS API wrappers Rafael J. Wysocki 2020-02-11 23:08 ` [PATCH 14/28] cpuidle: Call cpu_latency_qos_limit() instead of pm_qos_request() Rafael J. Wysocki 2020-02-11 23:10 ` [PATCH 15/28] x86: platform: iosf_mbi: Call cpu_latency_qos_*() instead of pm_qos_*() Rafael J. Wysocki 2020-02-12 10:14 ` Andy Shevchenko 2020-02-11 23:12 ` [PATCH 16/28] drm: i915: " Rafael J. Wysocki 2020-02-11 23:12 ` [Intel-gfx] " Rafael J. Wysocki 2020-02-12 10:32 ` Rafael J. Wysocki 2020-02-12 10:32 ` [Intel-gfx] " Rafael J. Wysocki 2020-02-14 7:42 ` Jani Nikula 2020-02-14 7:42 ` [Intel-gfx] " Jani Nikula 2020-02-11 23:13 ` [PATCH 17/28] drivers: hsi: " Rafael J. Wysocki 2020-02-13 21:06 ` Sebastian Reichel 2020-02-11 23:17 ` [PATCH 18/28] drivers: media: " Rafael J. Wysocki 2020-02-12 5:37 ` Mauro Carvalho Chehab 2020-02-11 23:21 ` [PATCH 19/28] drivers: mmc: " Rafael J. Wysocki 2020-02-11 23:24 ` [PATCH 20/28] drivers: net: " Rafael J. Wysocki 2020-02-11 23:48 ` Jeff Kirsher 2020-02-12 5:49 ` Kalle Valo 2020-02-11 23:26 ` [PATCH 21/28] drivers: spi: " Rafael J. Wysocki 2020-02-11 23:26 ` Rafael J. Wysocki 2020-02-11 23:27 ` [PATCH 22/28] drivers: tty: " Rafael J. Wysocki 2020-02-12 10:35 ` Rafael J. Wysocki 2020-02-12 19:13 ` Greg Kroah-Hartman 2020-02-11 23:28 ` [PATCH 23/28] drivers: usb: " Rafael J. Wysocki 2020-02-12 18:38 ` Greg KH 2020-02-18 8:03 ` Peter Chen 2020-02-18 8:08 ` Greg KH 2020-02-18 8:11 ` Peter Chen 2020-02-19 1:09 ` Peter Chen 2020-02-11 23:34 ` [PATCH 24/28] sound: " Rafael J. Wysocki 2020-02-11 23:34 ` [alsa-devel] " Rafael J. Wysocki 2020-02-12 10:08 ` Mark Brown 2020-02-12 10:08 ` [alsa-devel] " Mark Brown 2020-02-12 10:16 ` Rafael J. Wysocki 2020-02-12 10:16 ` [alsa-devel] " Rafael J. Wysocki 2020-02-12 10:21 ` Takashi Iwai 2020-02-12 10:21 ` [alsa-devel] " Takashi Iwai 2020-02-12 10:18 ` Mark Brown 2020-02-12 10:18 ` [alsa-devel] " Mark Brown 2020-02-11 23:35 ` [PATCH 25/28] PM: QoS: Drop PM_QOS_CPU_DMA_LATENCY and rename related functions Rafael J. Wysocki 2020-02-11 23:35 ` [PATCH 26/28] PM: QoS: Update file information comments Rafael J. Wysocki 2020-02-11 23:36 ` [PATCH 27/28] Documentation: PM: QoS: Update to reflect previous code changes Rafael J. Wysocki 2020-02-11 23:37 ` [PATCH 28/28] PM: QoS: Make CPU latency QoS depend on CONFIG_CPU_IDLE Rafael J. Wysocki 2020-02-12 8:37 ` [PATCH 00/28] PM: QoS: Get rid of unuseful code and rework CPU latency QoS interface Ulf Hansson 2020-02-12 9:17 ` Rafael J. Wysocki 2020-02-12 9:39 ` Rafael J. Wysocki 2020-02-12 23:32 ` Francisco Jerez 2020-02-13 0:16 ` Rafael J. Wysocki 2020-02-13 0:37 ` Rafael J. Wysocki 2020-02-13 8:10 ` Francisco Jerez 2020-02-13 11:38 ` Rafael J. Wysocki 2020-02-21 22:10 ` Francisco Jerez 2020-02-24 0:29 ` Rafael J. Wysocki [this message] 2020-02-24 21:06 ` Francisco Jerez 2020-02-13 8:07 ` Francisco Jerez 2020-02-13 11:34 ` Rafael J. Wysocki 2020-02-13 16:35 ` Rafael J. Wysocki 2020-02-14 0:15 ` Francisco Jerez 2020-02-14 10:42 ` Rafael J. Wysocki 2020-02-14 20:32 ` Francisco Jerez 2020-02-24 10:39 ` Rafael J. Wysocki 2020-02-24 21:16 ` Francisco Jerez 2020-02-14 0:14 ` Francisco Jerez 2020-02-13 7:10 ` Amit Kucheria 2020-02-13 10:17 ` Rafael J. Wysocki 2020-02-13 10:22 ` Rafael J. Wysocki 2020-02-13 10:49 ` Amit Kucheria 2020-02-13 11:36 ` Rafael J. Wysocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAJZ5v0jqp7aEh43kUvxyMWxbnEUjUZZ31iHk_oxDdvGM6RTdMw@mail.gmail.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 00/28] PM: QoS: Get rid of unuseful code and rework CPU latency QoS interface' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.