From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Alexander Monakov <amonakov@ispras.ru>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH] intel_idle: mention assumption that wbinvd is not needed
Date: Mon, 12 Oct 2020 13:32:05 +0200 [thread overview]
Message-ID: <CAJZ5v0jzebmUJ8zYzCU1W08POdE7=+Uu5DGGjJaZLsp06+=YAw@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.20.13.2010121410490.15808@monopod.intra.ispras.ru>
On Mon, Oct 12, 2020 at 1:14 PM Alexander Monakov <amonakov@ispras.ru> wrote:
>
> On Mon, 12 Oct 2020, Rafael J. Wysocki wrote:
>
> > > @@ -20,7 +20,11 @@
> > > * All CPUs have same idle states as boot CPU
> > > *
> > > * Chipset BM_STS (bus master status) bit is a NOP
> > > - * for preventing entry into deep C-stats
> > > + * for preventing entry into deep C-states
> > > + *
> > > + * CPU will flush caches as needed when entering a C-state via MWAIT
> >
> > I would rephrase this to mention that the above actually is an assumption.
>
> This comment block is by itself a list of assumptions.
Ah, OK
> It begins with heading
> "Design Assumptions" and then lists two assumptions. This patch adds a third
> one.
>
> With that clarified, do you still need me to change this hunk?
No need.
prev parent reply other threads:[~2020-10-12 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 22:18 [PATCH] intel_idle: mention assumption that wbinvd is not needed Alexander Monakov
2020-10-12 10:55 ` Rafael J. Wysocki
2020-10-12 11:14 ` Alexander Monakov
2020-10-12 11:32 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0jzebmUJ8zYzCU1W08POdE7=+Uu5DGGjJaZLsp06+=YAw@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=amonakov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.