From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AEA0C11F64 for ; Thu, 1 Jul 2021 10:53:10 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A38E4613DA for ; Thu, 1 Jul 2021 10:53:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A38E4613DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4A6A183258; Thu, 1 Jul 2021 12:53:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pq4hac64"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BF9698328B; Thu, 1 Jul 2021 12:53:05 +0200 (CEST) Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 54F7F83207 for ; Thu, 1 Jul 2021 12:53:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mibodhi@gmail.com Received: by mail-yb1-xb2d.google.com with SMTP id p22so10117921yba.7 for ; Thu, 01 Jul 2021 03:53:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=B2fqXpfx7pwZxcWYq+6C73Ftg8QhL/QZQK67kOjdlx0=; b=pq4hac64h94R53oSoHubvcMae6JID7Qr2iR8mGKaT1SHPc/jmL/O1dSgtzQH7NFNE4 vI1bmCg0+sVuqSN5KhGJrSTd8+SSyMZMreb1Ifl5VjntX2kLF1TG71ISsK31F+t95U1s w4oRilDcXwRQGkdw+FBNMH9O18rT1mxWSBIjACSUlWrMUCtIFAT+wEDzYvz30iuaeQGr 7TdeUEVp3PQsKj66bvbMvK6NcQTnaygL6+ei+/086+n3sUta9gPeN10gbCxuJlqNWg14 ij9RIr3u5xdsIAoSBfFx/vGP+6W2f0Bw+5cyfB198HdGNGV4v9a4otnRR6ISU3X/4R/V BQ8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B2fqXpfx7pwZxcWYq+6C73Ftg8QhL/QZQK67kOjdlx0=; b=po/sLki0H/9kw5c36CvWec+Zdh8B4niA1WbIFFrUowCRylrcvy8JeKCMAtNN9SSaLz 6tYXBVa8vxO5Gx2tIdSqHBwqQlCYA98vmWbplXcLwkchU23jP661pBEC4y63+1sXgdKg mlI+23sbisLHgQdrYr8Hq7pX2lx0Nv2bd1jeglyeV8K4cFdWgGIxR4tU0BXvjqFB1m4w bPePzbZWkLcU8bEZYbkaz30KcJMfLupjlM7mw8OCmTJuoNlkr7+yXWDsc3tJ2iik0dOw L3aZFYleicsgPGNgRWwAFZWs5U3I6VCJCzLlpPMPb0rDUHi6RZcO3Ipql878yNUZsXua aiVw== X-Gm-Message-State: AOAM531Xl/np7Y9NOLTRiOsunzulfCDVIpTMGUhrw87fGwvHABd+emtQ rLLaMEciBHID3Uq5W5dpTH1Bc4cJ6akCPVw7cWQ= X-Google-Smtp-Source: ABdhPJy1OHDW6ltqhyD4tJlEX/YQimsThMj6pBqti/vRL/7xU7mSsGW3D8k8xUweqAZFxJR9Vdl46LMA80A06PDHn5c= X-Received: by 2002:a25:db45:: with SMTP id g66mr35142475ybf.351.1625136781130; Thu, 01 Jul 2021 03:53:01 -0700 (PDT) MIME-Version: 1.0 References: <20210701042625.18815-1-mibodhi@gmail.com> <20210701042625.18815-4-mibodhi@gmail.com> <41f44aa6-0af8-6ddb-cf5c-2b4ced65b7d9@denx.de> <73d89073-9066-ff80-15d5-93bc0a7a4e27@denx.de> In-Reply-To: <73d89073-9066-ff80-15d5-93bc0a7a4e27@denx.de> From: "Tony (bodhi)" Date: Thu, 1 Jul 2021 03:56:36 -0700 Message-ID: Subject: Re: [PATCH 3/4] NSA310S : Use Ethernet PHY name from device tree To: Stefan Roese Cc: U-Boot Mailing List , Tom Rini , Chris Packham Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Stefan, On Thu, Jul 1, 2021 at 1:22 AM Stefan Roese wrote: > > Hi Tony, > > On 01.07.21 10:19, Stefan Roese wrote: > > On 01.07.21 06:26, Tony Dinh wrote: > >> In DM Ethernet, the old "egiga0" name is no longer valid, so replace it > >> with Ethernet PHY name from device tree. > >> > >> Signed-off-by: Tony Dinh > >> --- > >> > >> board/zyxel/nsa310s/nsa310s.c | 15 +++++++-------- > >> 1 file changed, 7 insertions(+), 8 deletions(-) > >> > >> diff --git a/board/zyxel/nsa310s/nsa310s.c > >> b/board/zyxel/nsa310s/nsa310s.c > >> index cd4a7723b1..29aded1910 100644 > >> --- a/board/zyxel/nsa310s/nsa310s.c > >> +++ b/board/zyxel/nsa310s/nsa310s.c > >> @@ -1,5 +1,6 @@ > >> // SPDX-License-Identifier: GPL-2.0+ > >> /* > >> + * Copyright (C) 2021 Tony Dinh > > > > AFAIU, just changing a few lines, as this patch does, does not justify > > to add a copyright notice to this file. > > I just noticed that you already are present in the copyright notice > below. I suggest to change this in a way, so that your name only > occurs once, like: > > * Copyright (C) 2015, 2021 Tony Dinh > > Does this make sense? Definitely! I will correct the copyright for this patch and also the copyright in patch 4/4 using this convention. > > Thanks, > Stefan > > >> * Copyright (C) 2015 > >> * Gerald Kerma > >> * Tony Dinh > >> @@ -81,22 +82,18 @@ int board_init(void) > >> return 0; > >> } > >> +#define PHY_ADR 1 > > > > You should be able to read this PHY address from the device-tree now. > > No need to define this here again. I don't know yet how to extract this info from the device tree nodes (I am familiar with this in Linux kernel, but at first glance it seems like u-boot fdt library is different). So if it is OK, perhaps I could send in another patch for this correction after this DM conversion is done. Thanks, Tony