From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BE17C00140 for ; Fri, 29 Jul 2022 01:39:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 94AE4841DD; Fri, 29 Jul 2022 03:39:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="o2g5Qw/f"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4110E841B7; Fri, 29 Jul 2022 03:39:56 +0200 (CEST) Received: from mail-vs1-xe30.google.com (mail-vs1-xe30.google.com [IPv6:2607:f8b0:4864:20::e30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C24AE841DD for ; Fri, 29 Jul 2022 03:39:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mibodhi@gmail.com Received: by mail-vs1-xe30.google.com with SMTP id 129so3216453vsq.8 for ; Thu, 28 Jul 2022 18:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pgy9z16v65kTWTv947KHkws1q7JwfUAN+DETw5RnyHM=; b=o2g5Qw/fnWaHusSY4tLml2oBIbIwsSlorf6Q1I8EYz1ViCYehQ2PYBHYcBTswKEdu7 6sU8UtuLJYKiWvafc9EXEDJ3wbPoOItZht4HmBPJB8ITTkjhGHh+RjrKMBK/teeG/diw 8QWfrBNxQ4M/4347UblswmYg/Q1cIQLtpUs1R1wGB84TBQOE/PAf49jRC9gOP38D7V2L Owf6tNG2tMyw2FHz9Ew9FLkmizx6jgaa2dlJD+m2R/Mu+ixmuVTlM7HTapKMDEHlEZ5n rcK7BcCDqlvnqDIxdVcwKX68WtVfcgG5FhhvIY1nxK8CRsf9bmRvgihMxchRm8RgiHRt z/rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pgy9z16v65kTWTv947KHkws1q7JwfUAN+DETw5RnyHM=; b=a+aNw7cYCY3IGfXUC9iRJtuYQ21KzRNEucQoA1zeZfPOW0d9Xkg1lFwlbeYh2n+uKL DkMZ/5QtDkmeZMCEHSLTkGMwg2MCaSXm9AnGfuCOmIIu+18JhN36cSPsJ4hQjeUu7kod TJZaRqeYGk3OQMFuFDJp18Sd5fiQSpwQPIo3Z1fbjintVXFI0h//kGlJIx5DC+Y7jKfa rGNgK7qeGmns0rTd9apdzdnwsN5fsIPr/Ou51zTHRtZ/4MjVDV76JPE/oUkA0Gl3ocZo 8xdIK3jfI4w7Hd+cnnTwLQ+iXp/El27dGahQygD9hzcwkpMyjyzU0WFhFw0VKfehgIRe nIqw== X-Gm-Message-State: AJIora+CEFaPeYOhjJXTEAlorMJagdrQ+4JumFOttbPnwbubRP2T4o0f jYOBB7v7wDe5f34xaEdTa87pDu7sYWldGX30vas= X-Google-Smtp-Source: AGRyM1sGuJXg9ROI816lctEn3LVnTGSJ7hDJ0SOpK8R3TKeBitREeqBAFSJZMj4vu6+gdb/oRku9CopUSPx8fTfm1yI= X-Received: by 2002:a67:ec88:0:b0:357:83f:e0f3 with SMTP id h8-20020a67ec88000000b00357083fe0f3mr492490vsp.76.1659058792407; Thu, 28 Jul 2022 18:39:52 -0700 (PDT) MIME-Version: 1.0 References: <20220725115615.420-1-pali@kernel.org> In-Reply-To: <20220725115615.420-1-pali@kernel.org> From: Tony Dinh Date: Thu, 28 Jul 2022 18:39:41 -0700 Message-ID: Subject: Re: [PATCH 0/8] arm: mvebu: Add Armada 38x pin muxing support To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Stefan Roese , Marek Behun , Simon Glass , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Pali, After correcting my MPP configuration in board_early_init, I ran the test again with this patch series. Everything works (upon u-boot startup) : Ethernet, SPI, SATA and USB. Board: Synology DS116, Armada 385 (out-of-tree u-boot) Tested-by: Tony Dinh Thanks, Tony On Mon, Jul 25, 2022 at 4:56 AM Pali Roh=C3=A1r wrote: > > This patch series add support for configuring pin muxing on Armada 38x > via device tree properties used by Linux kernel. It extends also mvebu > gpio driver to properly set pin function to gpio prior assigning pins > and enable gpio and pinmux support on Turris Omnia. > > Pali Roh=C3=A1r (8): > pinctrl: Add new function pinctrl_generic_set_state_prefix() > mvebu: pinctrl: Add Armada 38x driver > arm: mvebu: Add gpio-ranges into Armada 38x device tree file > pinctrl: Add third argument label for pinctrl_gpio_request() function > gpio: mvebu_gpio: Add .request and .rfree methods for Armada 38x > gpio: mvebu_gpio: Read number of gpios from DT > gpio: mvebu_gpio: Set bank name to mvebu%d > arm: mvebu: turris_omnia: Enable a38x pinctrl and gpio support > > arch/arm/dts/armada-38x.dtsi | 2 + > configs/turris_omnia_defconfig | 4 +- > drivers/gpio/mvebu_gpio.c | 11 +- > drivers/pinctrl/mvebu/Kconfig | 7 + > drivers/pinctrl/mvebu/Makefile | 1 + > drivers/pinctrl/mvebu/pinctrl-armada-38x.c | 589 +++++++++++++++++++++ > drivers/pinctrl/pinctrl-generic.c | 100 +++- > drivers/pinctrl/pinctrl-uclass.c | 3 +- > include/dm/pinctrl.h | 5 +- > 9 files changed, 699 insertions(+), 23 deletions(-) > create mode 100644 drivers/pinctrl/mvebu/pinctrl-armada-38x.c > > -- > 2.20.1 >