From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FA3BC433F5 for ; Fri, 14 Jan 2022 00:50:40 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 477A1832E6; Fri, 14 Jan 2022 01:50:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="HTijKEAr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 350128319A; Fri, 14 Jan 2022 01:50:36 +0100 (CET) Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C12688319A for ; Fri, 14 Jan 2022 01:50:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mibodhi@gmail.com Received: by mail-yb1-xb36.google.com with SMTP id v186so20005437ybg.1 for ; Thu, 13 Jan 2022 16:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KJsWQ/YZ/WeVpOrCvzUMRNfGS0i2JCFBZnuZPTkkz1w=; b=HTijKEArATYS5EOKwNFbBTVxm1FwPlBFpipTmIDU0/oHUWNV9/AsmcCu67ZNc5BYzz XnqMiLSb7Z9/r5WaEhDEUuYQd3szkaZAonH4qjcHt4SjIBbWuDI2dInWQyyRUv6kYuNp H0K7VUHpro1HLpR2WhPlxybBhyF3grDRZFJxDZLjSXXDgz88kGaiu/AcV6TenEQjYkZW XTrteCuMRkfk2rk8iEPpBuwqnlDD5C9V0Me6GRugttOFbw2N5KEH7vDlYmoKjP2iQwEo nOoHjRnz0SbQz8wO/d0V3XQ3iQyH+xjxtGGLGI1YUvV7TgWXAa4lBYA3YtKTXhpp7Pld A/kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KJsWQ/YZ/WeVpOrCvzUMRNfGS0i2JCFBZnuZPTkkz1w=; b=W1dm8cCsGvG67vdIKsM4QHH1lfXwBJjWjnM350bjkfQ9HToWmG+UZicsmq1HS+JJR4 z4Rca35/eu9TEnRy5n/FUkDCOBIAYI9qbpewWiqwrrx0Qvru6LzwaKkGr3OjLg+ODkV2 AajHay4aoKFr/mcWqdmBBBJC2QqimH0xPUknwm5J8eE/MrQM0Fcwa8QOPu9UVOqYXGHN J9ksHyGVzjg+C2sA1xKOFtMOg5bYh10SbmkHLjLV7wyX3vzth2+Ds2l4mDDyS430Jeoq ls7dl/cFylxPj0a+5QdNFMhRFAZHGH9WVkmeSr5iCMDmYNtg/sJNHOuDGIkjsjec0wPh kQ9w== X-Gm-Message-State: AOAM531WuMpjU+4vWQFwDiB2bZTffaNKk0+vQwVurxWhedmSpq2H6HXe CVP0R31T4/RzHU8F1y4iACIAzk6u6aSgxeJlH7Y= X-Google-Smtp-Source: ABdhPJycSuIijJTSdIrxMo+kfBhdNvhRvOn+Y39KUA7BLtw9f2xQeuN+eUn8IIcOkNzs2VqAKh/dp04V0Bfux92iQSY= X-Received: by 2002:a25:7ac5:: with SMTP id v188mr9667851ybc.246.1642121431608; Thu, 13 Jan 2022 16:50:31 -0800 (PST) MIME-Version: 1.0 References: <20211223072649.13237-1-mibodhi@gmail.com> <20211223072649.13237-5-mibodhi@gmail.com> <8eb39c1f-9523-5017-af45-3d3bba07c443@denx.de> <20220113133627.GK9207@bill-the-cat> In-Reply-To: <20220113133627.GK9207@bill-the-cat> From: Tony Dinh Date: Thu, 13 Jan 2022 16:50:20 -0800 Message-ID: Subject: Re: [PATCH v2 4/8] arm: kirkwood: Pogoplug-V4 : Add board include configs file To: Tom Rini Cc: Stefan Roese , U-Boot Mailing List , =?UTF-8?Q?Marek_Beh=EF=BF=BDn?= , =?UTF-8?B?UGFsaSBSb2jvv71y?= , David Purdy Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Thu, Jan 13, 2022 at 5:36 AM Tom Rini wrote: > > On Thu, Jan 13, 2022 at 02:32:00PM +0100, Stefan Roese wrote: > > On 12/23/21 08:26, Tony Dinh wrote: > > > Add include configs file for Pogoplug V4 board > > > > > > Signed-off-by: Tony Dinh > > > --- > > > > > > (no changes since v1) > > > > > > include/configs/pogo_v4.h | 94 +++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 94 insertions(+) > > > create mode 100644 include/configs/pogo_v4.h > > > > > > diff --git a/include/configs/pogo_v4.h b/include/configs/pogo_v4.h > > > new file mode 100644 > > > index 0000000000..b449986e8c > > > --- /dev/null > > > +++ b/include/configs/pogo_v4.h > > > @@ -0,0 +1,94 @@ > > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > > +/* > > > + * Copyright (C) 2014-2021 Tony Dinh > > > + * > > > + * Based on > > > + * Copyright (C) 2012 > > > + * David Purdy > > > + * > > > + * Based on Kirkwood support: > > > + * (C) Copyright 2009 > > > + * Marvell Semiconductor > > > + * Written-by: Prafulla Wadaskar > > > + */ > > > + > > > +#ifndef _CONFIG_POGO_V4_H > > > +#define _CONFIG_POGO_V4_H > > > + > > > +/* > > > + * Machine type definition and ID > > > + */ > > > +#define MACH_TYPE_POGO_V4 3960 > > > +#define CONFIG_MACH_TYPE MACH_TYPE_POGO_V4 > > > > Are you really using the pretty old CONFIG_MACH_TYPE to boot Linux > > on this device? > > > > > + > > > +/* > > > + * High Level Configuration Options (easy to change) > > > + */ > > > +#define CONFIG_FEROCEON_88FR131 /* #define CPU Core subversion */ > > > +#define CONFIG_KW88F6192 /* SOC Name */ > > > > At least CONFIG_FEROCEON_88FR131 is available in Kconfig > > (arch/arm/mach-kirkwood/Kconfig), so there should be no need to add it > > via some header. > > > > Please double-check other macros in this header as well for availability > > in Kconfig. > > At this point you can now make CI do this for you as we have a test that > will fail if there's unmigrated symbols in your board header file. The > logic can also be copy/pasted out to a script to run by yourself too. I have not used CI before (not sure how). But I used a script copied from your post: https://lists.denx.de/pipermail/u-boot/2021-September/460085.html ./check-migrated-symbols.sh include/configs/pogo_v4.h That should be enough to see which ones to migrate, right? Thanks, Tony > -- > Tom