From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95EB2C6FD1F for ; Sat, 25 Mar 2023 19:28:09 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 46C9285F74; Sat, 25 Mar 2023 20:28:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="T9ZzJAas"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C42BC85F83; Sat, 25 Mar 2023 20:28:04 +0100 (CET) Received: from mail-vs1-xe2b.google.com (mail-vs1-xe2b.google.com [IPv6:2607:f8b0:4864:20::e2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8469985F74 for ; Sat, 25 Mar 2023 20:28:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mibodhi@gmail.com Received: by mail-vs1-xe2b.google.com with SMTP id e19so4236368vsu.4 for ; Sat, 25 Mar 2023 12:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679772480; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HzyMBA1/A1lexe7wCjsqoL4bkYztJ1L7NpKSZPucjYg=; b=T9ZzJAasAKJf9zzGDT3qJ4iQz1M6uUlDhAfWangByYzVdsA5qt40n8wDrWM1uKqCRg XT2LReOia9SR9+kOYKLbs7LmtJ2IsXVJie2dOSNAQOTkbVBsjNsw0sgTZDMUnk0m1T+T eJeePRFvy2GMSlPptZo7ZSOjMD4uBI6EZKWgYT77q7tSNC2Hd+LEuPeJALuBvi3stQmd aa7qwUtOXvEHb+82fFaLRylKY1vdRCUrqg+d5BomtshCl7vtW+GDlJX7nd65nr4eGuMG W3eDs1ZCxQSQVNJrOOCTEqzIePg+5D6sJAwehsLiWWXGgq7Y1oLW8cK9A6FEGg2GpbvK bnEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679772480; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HzyMBA1/A1lexe7wCjsqoL4bkYztJ1L7NpKSZPucjYg=; b=IlgwD1vtzrUjdSmNhuqI/0lo9wrW1px/87rp0BThLXbH3O1bqiuaqgz999kWUnSyq6 IPd6Rn44W2TU6pPgl3+TVOLNkT7H+00a6RNUeT8I2jpmrsmB12r8ungUIl1nU3X77xcy 49GEsuy8CLMCTvHl0Nc8w+ZtFC/qHbb2X82fAT/BJ1z/308iyiwnr9TDpaKCYvnVLoN4 M0OnHm6pgbILJ8rerii9pjo96vnON5Kude5/abKsM6JQBicqsFObHeMkUiYJlNiaZ126 wf5WCDqvWyy2Qz2ziLBqWJMV80myvWHMH1mTxALAmgOU2tsbD/VOH8bCHVfzqNF7UpEi pomA== X-Gm-Message-State: AAQBX9eFitsjFJZGa3xhEPkCFW3C7OhWRMdgmzEQ4/c1c6g7+Qukpvgl mEw6M15kHTn/UCD3sXnK6C6zBnK9DZZ8xLDXKDA= X-Google-Smtp-Source: AKy350YNiUr4/KkrbkuuuC2hjOhBW4hrBalzJ9E3zoHwCs3QLLZkxKsIgCv3oqcwcwJoixTukpHqUYjCqgsnpvliFOA= X-Received: by 2002:a67:d88c:0:b0:426:7730:1e6e with SMTP id f12-20020a67d88c000000b0042677301e6emr3347780vsj.0.1679772480274; Sat, 25 Mar 2023 12:28:00 -0700 (PDT) MIME-Version: 1.0 References: <20230304105036.19189-1-pali@kernel.org> <20230325133011.zaewcqvagua6y7dy@pali> In-Reply-To: <20230325133011.zaewcqvagua6y7dy@pali> From: Tony Dinh Date: Sat, 25 Mar 2023 12:27:48 -0700 Message-ID: Subject: Re: [PATCH RFC u-boot-mvebu 0/6] arm: mvebu: Fix boot mode detection To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Stefan Roese , Martin Rowe , Chris Packham , Baruch Siach , u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Pali, On Sat, Mar 25, 2023 at 6:30=E2=80=AFAM Pali Roh=C3=A1r w= rote: > > On Saturday 04 March 2023 11:50:30 Pali Roh=C3=A1r wrote: > > Improve code for checking strapping pins which specifies boot mode sour= ce. > > > > Martin, could you test if Clearfog can be still configured into UART > > booting mode via HW switches and if it still works correctly? First > > patch is reverting UART related commit for Clearfog which I think it no= t > > needed anymore. > > > > Also could you check if SATA booting is still working correctly? > > > > Tony, should address problems with SPI booting when it is configured to > > different configuration. In fourth commit I added all possible boot mod= e > > strapping pin configurations which are recognized by A385 bootrom (and > > not the only one described in the HW spec, which is incomplete). > > > > Stefan, do you have some AXP board with SATA boot source? Because I'm > > adding it for completeness in the last sixth patch. > > > > Pali Roh=C3=A1r (6): > > arm: mvebu: Remove A38x BOOT_FROM_UART_ALT 0x3f constant > > arm: mvebu: Remove A38x BOOT_FROM_SATA 0x22 constant > > arm: mvebu: Convert BOOT_FROM_* constants to function macros > > arm: mvebu: Define all options for A38x BOOT_FROM_* macros > > arm: mvebu: Define all BOOTROM_ERR_MODE_* macros > > arm: mvebu: Define all options for AXP BOOT_FROM_* macros > > > > arch/arm/mach-mvebu/cpu.c | 20 ++++++------- > > arch/arm/mach-mvebu/include/mach/soc.h | 41 ++++++++++++++++---------- > > 2 files changed, 35 insertions(+), 26 deletions(-) > > > > -- > > 2.20.1 > > > > Is something else needed to do with this patch series? > > Because the discussion in this patch thread just pointed to different > issues, not related this this patch series. For my part I'm OK. The boot mode detection works properly when the strapping pin is set to spi1. The issue comes after that. The spi0 versus spi1 in SPL is a different issue that I will need to investigate further. At the moment it falls back to BootROM, which is also very fast booting anyway. Thanks, Tony