From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDD4BC433DB for ; Wed, 17 Feb 2021 18:42:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A94660238 for ; Wed, 17 Feb 2021 18:42:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A94660238 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCRlw-000698-Qm for qemu-devel@archiver.kernel.org; Wed, 17 Feb 2021 13:42:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCRkg-0004gT-Uz for qemu-devel@nongnu.org; Wed, 17 Feb 2021 13:40:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lCRkf-0003Po-5v for qemu-devel@nongnu.org; Wed, 17 Feb 2021 13:40:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613587239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uDWw0jQxUaND0XQQb+ruknf/iQkbe8UrGU4K4Aidiok=; b=io5xCiLLHedb9AjUairplze8o3qUpJK0ZI8a5E/1n7YT1zN0VM6etnxQ/Zfc2C/tnyMclJ 66NOGMAjU5KZeiirKQJy3NTRqqF1ai9j1FnQ6aH7gFF+kcKlzMTo0z/co2ITv7D+yQxB2b lf7SxdP0LjEEKEZafxMSD43k2Ck+ZzM= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-269-yBbFOYGXPcKEWgs-IWlQ5g-1; Wed, 17 Feb 2021 13:40:37 -0500 X-MC-Unique: yBbFOYGXPcKEWgs-IWlQ5g-1 Received: by mail-qv1-f71.google.com with SMTP id h10so10567611qvf.19 for ; Wed, 17 Feb 2021 10:40:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=uDWw0jQxUaND0XQQb+ruknf/iQkbe8UrGU4K4Aidiok=; b=iAKhEzilh0IkWXloAwJq7Zz32g0YVBYqEBKIfgVYOXnEdhk5rBMlGWBUE2Lgs2Yfot lyscX8IILGvFjHqGnXjLN9vf4/TiINHlYzACcjohp3/zgWcxEKNkdELWcQcvrsAuVmqI Zdsqd51M8Gaap5Ol0rrhwQ12OO6faNudDlClSxOKh93PAsMIdA/C4ChCwjPYY/55DmvZ 9MRI68bOh4BNVd0a365dNjv71hQ/ltOudKiLqpTUFz5loNV1TXqwAknYKvz+BNaNwRsw OrKa4Ss75LAdNVS8Kvnb3dxWLhpYWZqSVtz4v6DrVCKsHzB14TqhidLAheVRIXCtDJVo XvmA== X-Gm-Message-State: AOAM531gmGAdq5xkgiyaCvjpwOhjtnCRbhAFjotC0koMB4li4xd2AjmN hOjqZ5/47isQtoVF7Tws/nsyuagJcruuMVR4X3wgBKfF27HdpEhLjod39hDG2BYqJhEU5aUNn9B gwkNn5CYRBRnafwSyJUNTfY8B0+2OdYA= X-Received: by 2002:a37:2e05:: with SMTP id u5mr538560qkh.131.1613587237204; Wed, 17 Feb 2021 10:40:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJyGUDYUVA0SZApfqGc6/hfgUglNySaTDFF/HhqxPB9CKcUAmJFYRu3rpyPkpsYUWMA6H2SFMWIeD0v4RagCDqc= X-Received: by 2002:a37:2e05:: with SMTP id u5mr538545qkh.131.1613587237028; Wed, 17 Feb 2021 10:40:37 -0800 (PST) MIME-Version: 1.0 References: <20210209153757.1653598-1-eperezma@redhat.com> <20210209153757.1653598-5-eperezma@redhat.com> <20210217130108.GF269203@stefanha-x1.localdomain> In-Reply-To: <20210217130108.GF269203@stefanha-x1.localdomain> From: Eugenio Perez Martin Date: Wed, 17 Feb 2021 19:40:01 +0100 Message-ID: Subject: Re: [RFC v2 4/7] vhost: Add VhostShadowVirtqueue To: Stefan Hajnoczi Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eperezma@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Miller , Parav Pandit , "Michael S. Tsirkin" , Jason Wang , Juan Quintela , qemu-level , Markus Armbruster , Harpreet Singh Anand , Xiao W Wang , Eli Cohen , virtualization@lists.linux-foundation.org, Michael Lilja , Jim Harford , Stefano Garzarella Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Feb 17, 2021 at 2:01 PM Stefan Hajnoczi wrote= : > > On Tue, Feb 09, 2021 at 04:37:54PM +0100, Eugenio P=C3=A9rez wrote: > > +/* > > + * Creates vhost shadow virtqueue, and instruct vhost device to use th= e shadow > > + * methods and file descriptors. > > + */ > > +VhostShadowVirtqueue *vhost_shadow_vq_new(struct vhost_dev *dev, int i= dx) > > +{ > > + g_autofree VhostShadowVirtqueue *svq =3D g_new0(VhostShadowVirtque= ue, 1); > > + int r; > > + > > + r =3D event_notifier_init(&svq->kick_notifier, 0); > > + if (r !=3D 0) { > > + error_report("Couldn't create kick event notifier: %s", > > + strerror(errno)); > > + goto err_init_kick_notifier; > > + } > > + > > + r =3D event_notifier_init(&svq->call_notifier, 0); > > + if (r !=3D 0) { > > + error_report("Couldn't create call event notifier: %s", > > + strerror(errno)); > > + goto err_init_call_notifier; > > + } > > + > > + return svq; > > Use-after-free due to g_autofree. I think this should be: > > return g_steal_pointer(&svq) > > https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html#g-ste= al-pointer What a miss, thanks for pointing it out!