From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23063C8300F for ; Mon, 30 Nov 2020 07:56:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D84D20709 for ; Mon, 30 Nov 2020 07:56:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XEl7iqI3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727505AbgK3H4X (ORCPT ); Mon, 30 Nov 2020 02:56:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:58323 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726858AbgK3H4X (ORCPT ); Mon, 30 Nov 2020 02:56:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606722896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cfYEN4na3C3FMqwMo6LNjQ8k4ZCO0qa7qNB5nkxkM6o=; b=XEl7iqI3DAeA8AKUnM4dGpQ+oBDQzvSUExnupTNieRh/8JSJhihdjqSnEZkmOzYsPdOiPf tN2IG2w04FGFNJ8eGeMDYbfZFWQfbpqZDVOBsWkSA9fUuth0uyWI7kCAShDXqE4k4K7xZa 5MFex9szYZ6VUJLKUOLgkLgaKrjvlAw= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-559-jzcMcfbPMjO3P68tJ2E7NQ-1; Mon, 30 Nov 2020 02:54:54 -0500 X-MC-Unique: jzcMcfbPMjO3P68tJ2E7NQ-1 Received: by mail-qk1-f197.google.com with SMTP id 202so8997864qkl.9 for ; Sun, 29 Nov 2020 23:54:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cfYEN4na3C3FMqwMo6LNjQ8k4ZCO0qa7qNB5nkxkM6o=; b=IQ5KuhLDbhdE4ynKsfO4qkRcf5teadKiyW6276errdnkEhp+5zMy+RmrZqZqANXvRo oI4PqN2vF0H9Dr4v5mBoDIQwi7YCk/PwujYFfbeOnj//ejI8/dzv9QFeEJ+F5S/39cXu g/L5zpVe0y4wWZD6Tq8Csgol1vYnoJkXQxWN7YU62XTc2ATG6RGmSk8DjtxbI2etnEkI 1ErkIiMJa6POY3KWqFh9JNxYEcViqRgb+UleFZOuPr2gzpzxZvT2laGZD7HBbCuLcmt0 guIcjU2TRdTUu1j06EdynFYqJusZjspLv+whJlfiPJ9/z5OhmlxezLbjHI3RDLGzTRuV A3zg== X-Gm-Message-State: AOAM533SQ2nmDYLXHrBZEGzof6n5fwY1esIos0h++mjIdVDU7jlqPVP6 9sV82VeVVsLVNRO0MohHfR1F3SHIwTuhxqxsMd6JNSReoEOQNJcAHSga/TjonLsmukQsKs0F3g/ i/L1M1CTS66gN5jo2OdekLt1sDRZh X-Received: by 2002:a05:620a:132d:: with SMTP id p13mr21768019qkj.233.1606722894178; Sun, 29 Nov 2020 23:54:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJyuzkTzTp2p3vGrFooseaaNhC8uI+tyCQrxfu6y0WFvPSKipLD0ddM5+y6Pgg0Pf6Qwpznddv7mfYMwakFsfAA= X-Received: by 2002:a05:620a:132d:: with SMTP id p13mr21768001qkj.233.1606722893979; Sun, 29 Nov 2020 23:54:53 -0800 (PST) MIME-Version: 1.0 References: <20201120185105.279030-1-eperezma@redhat.com> <20201120185105.279030-24-eperezma@redhat.com> <20201127152901.cbfu7rmewbxventr@steredhat> In-Reply-To: <20201127152901.cbfu7rmewbxventr@steredhat> From: Eugenio Perez Martin Date: Mon, 30 Nov 2020 08:54:18 +0100 Message-ID: Subject: Re: [RFC PATCH 23/27] vhost: unmap qemu's shadow virtqueues on sw live migration To: Stefano Garzarella Cc: qemu-level , Lars Ganrot , virtualization@lists.linux-foundation.org, Salil Mehta , "Michael S. Tsirkin" , Liran Alon , Rob Miller , Max Gurtovoy , Alex Barba , Stefan Hajnoczi , Jim Harford , Jason Wang , Harpreet Singh Anand , Christophe Fontaine , vm , Daniel Daly , Michael Lilja , Nitin Shrivastav , Lee Ballard , Dmytro Kazantsev , Juan Quintela , kvm list , Howard Cai , Xiao W Wang , Sean Mooney , Parav Pandit , Eli Cohen , Siwei Liu , Stephen Finucane Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Nov 27, 2020 at 4:29 PM Stefano Garzarella wr= ote: > > On Fri, Nov 20, 2020 at 07:51:01PM +0100, Eugenio P=C3=83=C2=A9rez wrote: > >Since vhost does not need to access it, it has no sense to keep it > >mapped. > > > >Signed-off-by: Eugenio P=C3=83=C2=A9rez > >--- > > hw/virtio/vhost.c | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c > >index f640d4edf0..eebfac4455 100644 > >--- a/hw/virtio/vhost.c > >+++ b/hw/virtio/vhost.c > >@@ -1124,6 +1124,7 @@ static int vhost_sw_live_migration_start(struct vh= ost_dev *dev) > > > > dev->sw_lm_shadow_vq[idx] =3D vhost_sw_lm_shadow_vq(dev, idx); > > event_notifier_set_handler(&vq->masked_notifier, vhost_handle_c= all); > >+ vhost_virtqueue_memory_unmap(dev, &dev->vqs[idx], true); > > IIUC vhost_virtqueue_memory_unmap() is already called at the end of > vhost_virtqueue_stop(), so we can skip this call, right? > You are totally right Stefano, thanks for the catch! > > > > vhost_vring_write_addr(dev->sw_lm_shadow_vq[idx], &addr); > > r =3D dev->vhost_ops->vhost_set_vring_addr(dev, &addr); > >-- 2.18.4 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6A92C63777 for ; Mon, 30 Nov 2020 07:56:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26B9620679 for ; Mon, 30 Nov 2020 07:56:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XEl7iqI3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26B9620679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kje2q-0005iJ-Lz for qemu-devel@archiver.kernel.org; Mon, 30 Nov 2020 02:56:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kje1W-0005Bm-4r for qemu-devel@nongnu.org; Mon, 30 Nov 2020 02:55:02 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:23363) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kje1T-000365-EJ for qemu-devel@nongnu.org; Mon, 30 Nov 2020 02:55:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606722896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cfYEN4na3C3FMqwMo6LNjQ8k4ZCO0qa7qNB5nkxkM6o=; b=XEl7iqI3DAeA8AKUnM4dGpQ+oBDQzvSUExnupTNieRh/8JSJhihdjqSnEZkmOzYsPdOiPf tN2IG2w04FGFNJ8eGeMDYbfZFWQfbpqZDVOBsWkSA9fUuth0uyWI7kCAShDXqE4k4K7xZa 5MFex9szYZ6VUJLKUOLgkLgaKrjvlAw= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-442-uO27YCBVP_OjUdJv2xdGPw-1; Mon, 30 Nov 2020 02:54:54 -0500 X-MC-Unique: uO27YCBVP_OjUdJv2xdGPw-1 Received: by mail-qk1-f199.google.com with SMTP id w189so8974984qkd.6 for ; Sun, 29 Nov 2020 23:54:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cfYEN4na3C3FMqwMo6LNjQ8k4ZCO0qa7qNB5nkxkM6o=; b=MxSEtbvqhBn5YVrvrkw5GdX0bNqXSEnyFcWbBRF0yg0/Mg8ngZJHup7ZHiN0kSS3b/ XqyPxSq9z7B4oTcVtBu0xdg9DfXhSK3wIdShpz/3OwNkbzIJ3xEK2cGQrObKGgwTZmoK HQJZ5fbellVyC01sjAXvf/T0LczPpOcIzDxBPZwaKHEAEcb1JtVei+Tg7UjNKvV/+CxH UiTkcok5Ouq0N0HzdnElBslbyGZh7urzSISzvN+fLirk93Bo+qW82m8qgtdbyTGh/yau KhJZJ8yr1PQ1ku0Ar6FIeNzE5jvzAKpGuzL6eGcsWqoSjkEesv+vZMK2DlZ+Lf4ZCNEN 2FKA== X-Gm-Message-State: AOAM531GOClL5JnmSG/uv/Cq7OlMfi+xAu5p4MKj83kf85sKL7xxB5MP nfxBvT9n50G+2+7nCEd+Q+vNmHvHkHSeMa6Pn0NB7Txz64Q54/0DmAuYeIJsaycSs8LJprNi0PH uxWWtI4wSMFi0cEm+s+Eyo5qguk0N46I= X-Received: by 2002:a05:620a:132d:: with SMTP id p13mr21768042qkj.233.1606722894181; Sun, 29 Nov 2020 23:54:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJyuzkTzTp2p3vGrFooseaaNhC8uI+tyCQrxfu6y0WFvPSKipLD0ddM5+y6Pgg0Pf6Qwpznddv7mfYMwakFsfAA= X-Received: by 2002:a05:620a:132d:: with SMTP id p13mr21768001qkj.233.1606722893979; Sun, 29 Nov 2020 23:54:53 -0800 (PST) MIME-Version: 1.0 References: <20201120185105.279030-1-eperezma@redhat.com> <20201120185105.279030-24-eperezma@redhat.com> <20201127152901.cbfu7rmewbxventr@steredhat> In-Reply-To: <20201127152901.cbfu7rmewbxventr@steredhat> From: Eugenio Perez Martin Date: Mon, 30 Nov 2020 08:54:18 +0100 Message-ID: Subject: Re: [RFC PATCH 23/27] vhost: unmap qemu's shadow virtqueues on sw live migration To: Stefano Garzarella Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eperezma@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=63.128.21.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.496, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm list , "Michael S. Tsirkin" , Jason Wang , qemu-level , Daniel Daly , virtualization@lists.linux-foundation.org, Liran Alon , Eli Cohen , Nitin Shrivastav , Alex Barba , Christophe Fontaine , Juan Quintela , Lee Ballard , Lars Ganrot , Rob Miller , Howard Cai , Parav Pandit , vm , Salil Mehta , Stephen Finucane , Xiao W Wang , Sean Mooney , Stefan Hajnoczi , Jim Harford , Dmytro Kazantsev , Siwei Liu , Harpreet Singh Anand , Michael Lilja , Max Gurtovoy Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Nov 27, 2020 at 4:29 PM Stefano Garzarella wr= ote: > > On Fri, Nov 20, 2020 at 07:51:01PM +0100, Eugenio P=C3=83=C2=A9rez wrote: > >Since vhost does not need to access it, it has no sense to keep it > >mapped. > > > >Signed-off-by: Eugenio P=C3=83=C2=A9rez > >--- > > hw/virtio/vhost.c | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c > >index f640d4edf0..eebfac4455 100644 > >--- a/hw/virtio/vhost.c > >+++ b/hw/virtio/vhost.c > >@@ -1124,6 +1124,7 @@ static int vhost_sw_live_migration_start(struct vh= ost_dev *dev) > > > > dev->sw_lm_shadow_vq[idx] =3D vhost_sw_lm_shadow_vq(dev, idx); > > event_notifier_set_handler(&vq->masked_notifier, vhost_handle_c= all); > >+ vhost_virtqueue_memory_unmap(dev, &dev->vqs[idx], true); > > IIUC vhost_virtqueue_memory_unmap() is already called at the end of > vhost_virtqueue_stop(), so we can skip this call, right? > You are totally right Stefano, thanks for the catch! > > > > vhost_vring_write_addr(dev->sw_lm_shadow_vq[idx], &addr); > > r =3D dev->vhost_ops->vhost_set_vring_addr(dev, &addr); > >-- 2.18.4 > > >