From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 088F4C433F5 for ; Thu, 10 Mar 2022 18:22:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244529AbiCJSXs (ORCPT ); Thu, 10 Mar 2022 13:23:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239692AbiCJSXp (ORCPT ); Thu, 10 Mar 2022 13:23:45 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C9723A1BDB for ; Thu, 10 Mar 2022 10:22:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646936564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OUsx2B8DPPUnwo9W++AgxGnDV4EWGqmUAKP5ASwmHJw=; b=e04M4KuE9QNb1oJ8wJD3M1aLsWwFDcvTjBdCOniBiwu1rZ6u7LYIRvO5fXyhKdKF+owNAQ e49PYtoP0v59XZio80gjwMz88VUnxs/NJ3AKqGQ8HDWA+ea4MZAxJuU4g5ywJpLw0iMedD tB+tez/biycDLZ2rldAksG+Pe5kfsTk= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-114-WSnFUnwIOrymj9hj4Tr0Dg-1; Thu, 10 Mar 2022 13:22:42 -0500 X-MC-Unique: WSnFUnwIOrymj9hj4Tr0Dg-1 Received: by mail-qk1-f200.google.com with SMTP id s12-20020a05620a030c00b0064971887744so4442452qkm.8 for ; Thu, 10 Mar 2022 10:22:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OUsx2B8DPPUnwo9W++AgxGnDV4EWGqmUAKP5ASwmHJw=; b=4PttnQhNbfTAJKyNIsZbyb61fMUVISf3Eh3V0m7uilYt8KJX/kSqSJhgVgtU3yvJaQ Rn8QiHDkfl0YCjDqcDAuiK4pGO+8NWnzdbHOBTNV6haRlYd3nZAmuIjOye07cXIHCSAf o/06ubktGQDZqfVCVQ7FQrgff9PlFhFDuIrSo3NPiZHBvi0+xEdDd/D3O2kGGvDahbZO E0fRhcOWeTcYf3nTBiLVAITuh8rmEqIE9TXDAJ39HrNjty7O1EBvk7NUiV47wk9rultQ FnvrW7MlbxvGo25T0VHNa3YrbPk3oB2RXSUVt2FggfbGce8Q/7duq+l02UEesNniriLB 3nmQ== X-Gm-Message-State: AOAM531cFZiou7Q9rb2SesdyBbt672/6vdLWokHXGES5Zu4yFBTCxHAd qt+LV70pQyi6pD93Ppbkno/zbhVnFRo9H3zyPp9bovT05533FsvJ4UZzfKmA93cfq0NnP7lq5Fw vfATtCJqhZ6DzKJFgCACFR7cG2NXqz2E8xlxvxc6+ X-Received: by 2002:a05:6214:e43:b0:435:a753:2434 with SMTP id o3-20020a0562140e4300b00435a7532434mr5025303qvc.40.1646936562482; Thu, 10 Mar 2022 10:22:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJwPfaHMXlT/QhUUEEw33PgTEhfdzxWFogWNltCegaSsdnJWLI/ODTwtUN7FkKmpLxGT5JhbfCFHsm4LVrsmAUs= X-Received: by 2002:a05:6214:e43:b0:435:a753:2434 with SMTP id o3-20020a0562140e4300b00435a7532434mr5025288qvc.40.1646936562306; Thu, 10 Mar 2022 10:22:42 -0800 (PST) MIME-Version: 1.0 References: <20201216064818.48239-1-jasowang@redhat.com> <20220224212314.1326-1-gdawar@xilinx.com> <20220224212314.1326-19-gdawar@xilinx.com> In-Reply-To: <20220224212314.1326-19-gdawar@xilinx.com> From: Eugenio Perez Martin Date: Thu, 10 Mar 2022 19:22:06 +0100 Message-ID: Subject: Re: [RFC PATCH v2 18/19] vdpa_sim: filter destination mac address To: Gautam Dawar Cc: Gautam Dawar , Martin Petrus Hubertus Habets , Harpreet Singh Anand , Tanuj Murlidhar Kamde , Jason Wang , "Michael S. Tsirkin" , Zhu Lingshan , Stefano Garzarella , Xie Yongji , Eli Cohen , Si-Wei Liu , Parav Pandit , Longpeng , virtualization , linux-kernel@vger.kernel.org, kvm list , netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 24, 2022 at 10:29 PM Gautam Dawar wrote: > > This patch implements a simple unicast filter for vDPA simulator. > > Signed-off-by: Jason Wang > Signed-off-by: Gautam Dawar > --- > drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 49 ++++++++++++++++++---------- > 1 file changed, 31 insertions(+), 18 deletions(-) > > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c > index 05d552cb7f94..ed5ade4ae570 100644 > --- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c > @@ -47,13 +47,28 @@ static void vdpasim_net_complete(struct vdpasim_virtqueue *vq, size_t len) > local_bh_enable(); > } > > +static bool receive_filter(struct vdpasim *vdpasim, size_t len) > +{ > + bool modern = vdpasim->features & (1ULL << VIRTIO_F_VERSION_1); > + size_t hdr_len = modern ? sizeof(struct virtio_net_hdr_v1) : > + sizeof(struct virtio_net_hdr); > + > + if (len < ETH_ALEN + hdr_len) > + return false; > + > + if (!strncmp(vdpasim->buffer + hdr_len, > + vdpasim->config.mac, ETH_ALEN)) > + return true; > + > + return false; > +} > + > static void vdpasim_net_work(struct work_struct *work) > { > struct vdpasim *vdpasim = container_of(work, struct vdpasim, work); > struct vdpasim_virtqueue *txq = &vdpasim->vqs[1]; > struct vdpasim_virtqueue *rxq = &vdpasim->vqs[0]; > ssize_t read, write; > - size_t total_write; > int pkts = 0; > int err; > > @@ -66,36 +81,34 @@ static void vdpasim_net_work(struct work_struct *work) > goto out; > > while (true) { > - total_write = 0; > err = vringh_getdesc_iotlb(&txq->vring, &txq->out_iov, NULL, > &txq->head, GFP_ATOMIC); > if (err <= 0) > break; > > + read = vringh_iov_pull_iotlb(&txq->vring, &txq->out_iov, > + vdpasim->buffer, > + PAGE_SIZE); > + > + if (!receive_filter(vdpasim, read)) { > + vdpasim_complete(txq, 0); vdpasim_net_complete? Thanks! > + continue; > + } > + > err = vringh_getdesc_iotlb(&rxq->vring, NULL, &rxq->in_iov, > &rxq->head, GFP_ATOMIC); > if (err <= 0) { > - vringh_complete_iotlb(&txq->vring, txq->head, 0); > + vdpasim_net_complete(txq, 0); > break; > } > > - while (true) { > - read = vringh_iov_pull_iotlb(&txq->vring, &txq->out_iov, > - vdpasim->buffer, > - PAGE_SIZE); > - if (read <= 0) > - break; > - > - write = vringh_iov_push_iotlb(&rxq->vring, &rxq->in_iov, > - vdpasim->buffer, read); > - if (write <= 0) > - break; > - > - total_write += write; > - } > + write = vringh_iov_push_iotlb(&rxq->vring, &rxq->in_iov, > + vdpasim->buffer, read); > + if (write <= 0) > + break; > > vdpasim_net_complete(txq, 0); > - vdpasim_net_complete(rxq, total_write); > + vdpasim_net_complete(rxq, write); > > if (++pkts > 4) { > schedule_work(&vdpasim->work); > -- > 2.25.0 >