From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FC97C433FE for ; Tue, 12 Oct 2021 13:19:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1988760296 for ; Tue, 12 Oct 2021 13:19:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1988760296 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:51698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maHgh-0007Zg-7U for qemu-devel@archiver.kernel.org; Tue, 12 Oct 2021 09:19:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maHY2-0003Vc-4W for qemu-devel@nongnu.org; Tue, 12 Oct 2021 09:10:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22110) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maHXz-0004ke-Gs for qemu-devel@nongnu.org; Tue, 12 Oct 2021 09:10:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634044220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o6KMfTRk5RczZ0PnbZWRpl29bQ0RqbCziFmmN6NJ82o=; b=EILyXqJS63DyRSbUY8g/DnzJLDE8gSfPH+zsyyYQ4UZGb0X2FtxB4dNlBMxrHSrG/FxLZ/ KJh3YmpCgVOnT5NpklrcCtJRQli9Jbwpnw8v4sVYYoBeuy/lztPSvcX2pdydVBhs8Pw5GZ UM5eOJVC56Fdesy82uENURbjh2UcvKE= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-507-3Lnsa0ekO-u9hQqE8n8wGA-1; Tue, 12 Oct 2021 09:10:19 -0400 X-MC-Unique: 3Lnsa0ekO-u9hQqE8n8wGA-1 Received: by mail-qv1-f69.google.com with SMTP id o90-20020a0c85e3000000b0038310a20003so16878739qva.1 for ; Tue, 12 Oct 2021 06:10:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=o6KMfTRk5RczZ0PnbZWRpl29bQ0RqbCziFmmN6NJ82o=; b=PiP7HdrAct372YQ8EQ2VOScjpKMZ9r3qz41rgnk26sVO7Snxh6VLYueoggsceotQ+r 0+c+jINwrGTlLPmGn+7HAL8RRkrkDVhDkV8SUR+yeXnsWL/msg5BcThFp1no52BOstuu FtZXx6KgSTLYKbS0WzApJTWadGspuIr9WMVPgd0jaXfp/XAsxkxXNmsdkhuNv2wTOw6S 8+iwdiXPzjlpK5r91dsTb8tHav45odxLs6fb1wBd32hPnEfIWfIhNV0d9tYTVM4hXYoa PfAW9aFK6AnCWon1mQibZzKkj2UuD08ChJoEIgEzDsoNCope/hgEb81Gf/JkjVIzfmxx dbrQ== X-Gm-Message-State: AOAM533bogHUZcQX51OAMuS8b4RHCDC0UnP/8A1p6mzdOEcU5tbYTbf/ p6B6PO0pLr28n84CZmuSCaRbUkEKrwzoAfQ6AHeMgJstuAliip+CwwIACdS0WydM/tecQmXz6oX t5EmzOomOaKZofVgj+6YhUbr+PiOLos4= X-Received: by 2002:aed:3022:: with SMTP id 31mr22561696qte.322.1634044218925; Tue, 12 Oct 2021 06:10:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNxmzHkshQj2x8o+3V+WUaVI2Z7lwZHyXTDABQJ2zgQeU0KhXcyBYd0W5H71MB8rtZ3HXbmnojhgx5A9898i0= X-Received: by 2002:aed:3022:: with SMTP id 31mr22561649qte.322.1634044218588; Tue, 12 Oct 2021 06:10:18 -0700 (PDT) MIME-Version: 1.0 References: <20211001070603.307037-1-eperezma@redhat.com> <20211001070603.307037-9-eperezma@redhat.com> <8735p6hlae.fsf@dusky.pond.sub.org> In-Reply-To: <8735p6hlae.fsf@dusky.pond.sub.org> From: Eugenio Perez Martin Date: Tue, 12 Oct 2021 15:09:42 +0200 Message-ID: Subject: Re: [RFC PATCH v4 08/20] vhost: Route guest->host notification through shadow virtqueue To: Markus Armbruster Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eperezma@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) DKIMWL_WL_HIGH=-0.049, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Parav Pandit , Juan Quintela , Jason Wang , "Michael S. Tsirkin" , qemu-level , virtualization , Harpreet Singh Anand , Xiao W Wang , Stefan Hajnoczi , Eli Cohen , Eric Blake , Michael Lilja , Stefano Garzarella Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Oct 12, 2021 at 7:20 AM Markus Armbruster wrote= : > > Eugenio P=C3=A9rez writes: > > > Shadow virtqueue notifications forwarding is disabled when vhost_dev > > stops, so code flow follows usual cleanup. > > > > Also, host notifiers must be disabled at SVQ start, and they will not > > start if SVQ has been enabled when device is stopped. This is trivial > > to address, but it is left out for simplicity at this moment. > > > > Signed-off-by: Eugenio P=C3=A9rez > > --- > > qapi/net.json | 2 +- > > hw/virtio/vhost-shadow-virtqueue.h | 8 ++ > > include/hw/virtio/vhost-vdpa.h | 4 + > > hw/virtio/vhost-shadow-virtqueue.c | 138 ++++++++++++++++++++++++++++- > > hw/virtio/vhost-vdpa.c | 116 +++++++++++++++++++++++- > > 5 files changed, 264 insertions(+), 4 deletions(-) > > > > diff --git a/qapi/net.json b/qapi/net.json > > index a2c30fd455..fe546b0e7c 100644 > > --- a/qapi/net.json > > +++ b/qapi/net.json > > @@ -88,7 +88,7 @@ > > # > > # @enable: true to use the alternate shadow VQ notifications > > # > > -# Returns: Always error, since SVQ is not implemented at the moment. > > +# Returns: Error if failure, or 'no error' for success. > > Delete the whole line, please. > I will do it. Thanks! > > # > > # Since: 6.2 > > # > [...] >