From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D00C433EF for ; Fri, 22 Jul 2022 07:13:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234239AbiGVHNh (ORCPT ); Fri, 22 Jul 2022 03:13:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234363AbiGVHNe (ORCPT ); Fri, 22 Jul 2022 03:13:34 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 43E9C904FB for ; Fri, 22 Jul 2022 00:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658474013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wsed93BuNRJkapkugRn/nwfX0SXje/qBsJN6NO73XG0=; b=EZhY34hSfqJY8iq9qlgmLM8gVWLfbldZZkKTvsTDmFwfL85hUDW5mX/CYitp5JK6ek4ktj fg83kr9+z3IvkUwgplh8XpcO25HO93lsWkCR6Wn0P9omKb5vNVd8B8ktvMPjaAt5tKMSuA kY1fWlCpi3wL3HQtUQ3LdkwgdhvEuak= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-59-nJF14z1HPKen0hkkn10CoQ-1; Fri, 22 Jul 2022 03:13:24 -0400 X-MC-Unique: nJF14z1HPKen0hkkn10CoQ-1 Received: by mail-qt1-f200.google.com with SMTP id cj19-20020a05622a259300b0031f01f3933cso2385349qtb.18 for ; Fri, 22 Jul 2022 00:13:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Wsed93BuNRJkapkugRn/nwfX0SXje/qBsJN6NO73XG0=; b=zqJw17+sFa2JgQ9fQQciiPg4aL41jrwY+q9uJxMi9Aap+Wj2IU+pGhUz0xFi0fNh6k Batjs4v+xvHnGo1Zd9Bxuyz67EuVp8ZCFRuWwPByNHtqQiYHAT/73nr+RPKpfFAWNdw4 HmcGfggMC8HP7je5hZu6j1uYXPcCGD0vYt/LOjhf7gF6abQOj8DouvUn9XhvtaB1NxfM Q6fD9fGnKFy765LXUnKCz8vJ/DvcFfN79vntJs6OUM6X66qothUlvfgcSw3Bepl+ACu1 mp7svoj0rYN2ODuMcKwcd8T9GokQGD8diV3wsSXMNbhOfrivT/xH4echyUf1JtjfESEa LCzw== X-Gm-Message-State: AJIora8MOEGjnFdaFPBdNrwyxDqRPCjzNoDDwU9nTCjktQVJr/BdhCnd 3XNFc2DSNJH9ktbNw90fbCd4ohGkc3j/kQQSxRJTOObAzAUJkx41nTSr+u9+j1cBQwSuVxiwJcc HFhhKdsLDNnoQikdLbAlU+xzz69csToKW+vEqtXH6 X-Received: by 2002:a0c:be91:0:b0:474:1d6:b1a4 with SMTP id n17-20020a0cbe91000000b0047401d6b1a4mr1734958qvi.108.1658474003806; Fri, 22 Jul 2022 00:13:23 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tEcyOOrz8ulXALLU3lOqBWBPAhsUJqLPMU34S78oArx1JQGAQejfV6MMkgWmFYInqi0IgRkgNkqkYPfZYae8I= X-Received: by 2002:a0c:be91:0:b0:474:1d6:b1a4 with SMTP id n17-20020a0cbe91000000b0047401d6b1a4mr1734938qvi.108.1658474003579; Fri, 22 Jul 2022 00:13:23 -0700 (PDT) MIME-Version: 1.0 References: <20220721084341.24183-1-qtxuning1999@sjtu.edu.cn> <20220721084341.24183-4-qtxuning1999@sjtu.edu.cn> In-Reply-To: <20220721084341.24183-4-qtxuning1999@sjtu.edu.cn> From: Eugenio Perez Martin Date: Fri, 22 Jul 2022 09:12:47 +0200 Message-ID: Subject: Re: [RFC 3/5] vhost_test: batch used buffer To: Guo Zhi Cc: Jason Wang , Stefano Garzarella , Michael Tsirkin , netdev , linux-kernel , kvm list , virtualization Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 21, 2022 at 10:44 AM Guo Zhi wrote: > > Only add to used ring when a batch a buffer have all been used. And if > in order feature negotiated, add randomness to the used buffer's order, > test the ability of vhost to reorder batched buffer. > > Signed-off-by: Guo Zhi > --- > drivers/vhost/test.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c > index bc8e7fb1e..1c9c40c11 100644 > --- a/drivers/vhost/test.c > +++ b/drivers/vhost/test.c > @@ -43,6 +43,9 @@ struct vhost_test { > static void handle_vq(struct vhost_test *n) > { > struct vhost_virtqueue *vq = &n->vqs[VHOST_TEST_VQ]; > + struct vring_used_elem *heads = kmalloc(sizeof(*heads) > + * vq->num, GFP_KERNEL); > + int batch_idx = 0; > unsigned out, in; > int head; > size_t len, total_len = 0; > @@ -84,11 +87,21 @@ static void handle_vq(struct vhost_test *n) > vq_err(vq, "Unexpected 0 len for TX\n"); > break; > } > - vhost_add_used_and_signal(&n->dev, vq, head, 0); > + heads[batch_idx].id = cpu_to_vhost32(vq, head); > + heads[batch_idx++].len = cpu_to_vhost32(vq, len); > total_len += len; > if (unlikely(vhost_exceeds_weight(vq, 0, total_len))) > break; > } > + if (batch_idx) { > + if (vhost_has_feature(vq, VIRTIO_F_IN_ORDER) && batch_idx >= 2) { Maybe to add a module parameter to test this? Instead of trusting in feature negotiation, "unorder_used=1" or something like that. vhost.c:vhost_add_used_and_signal_n should support receiving buffers in order or out of order whether F_IN_ORDER is negotiated or not. Thanks! > + vhost_add_used_and_signal_n(&n->dev, vq, &heads[batch_idx / 2], > + batch_idx - batch_idx / 2); > + vhost_add_used_and_signal_n(&n->dev, vq, heads, batch_idx / 2); > + } else { > + vhost_add_used_and_signal_n(&n->dev, vq, heads, batch_idx); > + } > + } > > mutex_unlock(&vq->mutex); > } > -- > 2.17.1 >