From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Garnier Subject: Re: [PATCH v3 23/27] x86/modules: Adapt module loading for PIE support Date: Wed, 23 May 2018 15:01:38 -0700 Message-ID: References: <20180523195421.180248-1-thgarnie@google.com> <20180523195421.180248-24-thgarnie@google.com> <168ebedb-7c27-d1f3-c2f9-223d44186a52@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Herbert Xu , "David S . Miller" , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Peter Zijlstra , Josh Poimboeuf , Greg KH , Philippe Ombredanne , Kate Stewart , Arnaldo Carvalho de Melo , Yonghong Song , Andrey Ryabinin , Kees Cook , Tom Lendacky , "Kirill A. Shutemov" , Andy Lutomirski , Dominik Brodowski , Borislav Petkov , Borislav Petkov , "Rafael J. Wysocki" , Len Brown , Pavel Machek Return-path: List-Post: List-Help: List-Unsubscribe: List-Subscribe: In-Reply-To: <168ebedb-7c27-d1f3-c2f9-223d44186a52@infradead.org> List-Id: linux-crypto.vger.kernel.org On Wed, May 23, 2018 at 2:27 PM Randy Dunlap wrote: > Hi, > (for several patches in this series:) > The commit message is confusing. See below. Thanks for the edits, I will change the different commit messages. > On 05/23/2018 12:54 PM, Thomas Garnier wrote: > > Adapt module loading to support PIE relocations. Generate dynamic GOT if > > a symbol requires it but no entry exist in the kernel GOT. > exists > > > > Position Independent Executable (PIE) support will allow to extended the > will allow us to extend the > > KASLR randomization range below the -2G memory limit. > Does that say "below th negative 2G memory limit"? > I don't get it. Yes, below 0xffffffff80000000 basically. I think I will just say that. > > > > Signed-off-by: Thomas Garnier > > --- > > arch/x86/Makefile | 4 + > > arch/x86/include/asm/module.h | 11 ++ > > arch/x86/include/asm/sections.h | 4 + > > arch/x86/kernel/module.c | 181 +++++++++++++++++++++++++++++++- > > arch/x86/kernel/module.lds | 3 + > > 5 files changed, 198 insertions(+), 5 deletions(-) > > create mode 100644 arch/x86/kernel/module.lds > Thanks, > -- > ~Randy -- Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Garnier Subject: Re: [PATCH v3 23/27] x86/modules: Adapt module loading for PIE support Date: Wed, 23 May 2018 15:01:38 -0700 Message-ID: References: <20180523195421.180248-1-thgarnie@google.com> <20180523195421.180248-24-thgarnie@google.com> <168ebedb-7c27-d1f3-c2f9-223d44186a52@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: List-Post: List-Help: List-Unsubscribe: List-Subscribe: In-Reply-To: <168ebedb-7c27-d1f3-c2f9-223d44186a52@infradead.org> To: Randy Dunlap Cc: Herbert Xu , "David S . Miller" , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Peter Zijlstra , Josh Poimboeuf , Greg KH , Philippe Ombredanne , Kate Stewart , Arnaldo Carvalho de Melo , Yonghong Song , Andrey Ryabinin , Kees Cook , Tom Lendacky , "Kirill A. Shutemov" , Andy Lutomirski , Dominik Brodowski , Borislav Petkov , Borislav Petkov , "Rafael J. Wysocki" , Len Brown , Pavel Machek List-Id: linux-sparse@vger.kernel.org On Wed, May 23, 2018 at 2:27 PM Randy Dunlap wrote: > Hi, > (for several patches in this series:) > The commit message is confusing. See below. Thanks for the edits, I will change the different commit messages. > On 05/23/2018 12:54 PM, Thomas Garnier wrote: > > Adapt module loading to support PIE relocations. Generate dynamic GOT if > > a symbol requires it but no entry exist in the kernel GOT. > exists > > > > Position Independent Executable (PIE) support will allow to extended the > will allow us to extend the > > KASLR randomization range below the -2G memory limit. > Does that say "below th negative 2G memory limit"? > I don't get it. Yes, below 0xffffffff80000000 basically. I think I will just say that. > > > > Signed-off-by: Thomas Garnier > > --- > > arch/x86/Makefile | 4 + > > arch/x86/include/asm/module.h | 11 ++ > > arch/x86/include/asm/sections.h | 4 + > > arch/x86/kernel/module.c | 181 +++++++++++++++++++++++++++++++- > > arch/x86/kernel/module.lds | 3 + > > 5 files changed, 198 insertions(+), 5 deletions(-) > > create mode 100644 arch/x86/kernel/module.lds > Thanks, > -- > ~Randy -- Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 MIME-Version: 1.0 References: <20180523195421.180248-1-thgarnie@google.com> <20180523195421.180248-24-thgarnie@google.com> <168ebedb-7c27-d1f3-c2f9-223d44186a52@infradead.org> In-Reply-To: <168ebedb-7c27-d1f3-c2f9-223d44186a52@infradead.org> From: Thomas Garnier Date: Wed, 23 May 2018 15:01:38 -0700 Message-ID: Subject: Re: [PATCH v3 23/27] x86/modules: Adapt module loading for PIE support Content-Type: text/plain; charset="UTF-8" To: Randy Dunlap Cc: Herbert Xu , "David S . Miller" , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Peter Zijlstra , Josh Poimboeuf , Greg KH , Philippe Ombredanne , Kate Stewart , Arnaldo Carvalho de Melo , Yonghong Song , Andrey Ryabinin , Kees Cook , Tom Lendacky , "Kirill A. Shutemov" , Andy Lutomirski , Dominik Brodowski , Borislav Petkov , Borislav Petkov , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Juergen Gross , Alok Kataria , Steven Rostedt , Jan Kiszka , Tejun Heo , Christoph Lameter , Dennis Zhou , Boris Ostrovsky , Alexey Dobriyan , Masami Hiramatsu , Cao jin , Francis Deslauriers , "Paul E . McKenney" , Nicolas Pitre , Andrew Morton , "Luis R . Rodriguez" , Arnd Bergmann , Christopher Li , Jason Baron , Mika Westerberg , Lukas Wunner , Dou Liyang , Sergey Senozhatsky , Petr Mladek , Masahiro Yamada , Ingo Molnar , Nicholas Piggin , "H . J . Lu" , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Joerg Roedel , David Woodhouse , Dave Hansen , Rik van Riel , Jia Zhang , Ricardo Neri , Jonathan Corbet , Jan Beulich , Matthias Kaehlcke , Baoquan He , =?UTF-8?B?SmFuIEggLiBTY2jDtm5oZXJy?= , Daniel Micay , the arch/x86 maintainers , Linux Crypto Mailing List , LKML , Linux PM list , virtualization@lists.linux-foundation.org, xen-devel , linux-arch , Sparse Mailing-list , kvm list , Linux Doc Mailing List , Kernel Hardening List-ID: On Wed, May 23, 2018 at 2:27 PM Randy Dunlap wrote: > Hi, > (for several patches in this series:) > The commit message is confusing. See below. Thanks for the edits, I will change the different commit messages. > On 05/23/2018 12:54 PM, Thomas Garnier wrote: > > Adapt module loading to support PIE relocations. Generate dynamic GOT if > > a symbol requires it but no entry exist in the kernel GOT. > exists > > > > Position Independent Executable (PIE) support will allow to extended the > will allow us to extend the > > KASLR randomization range below the -2G memory limit. > Does that say "below th negative 2G memory limit"? > I don't get it. Yes, below 0xffffffff80000000 basically. I think I will just say that. > > > > Signed-off-by: Thomas Garnier > > --- > > arch/x86/Makefile | 4 + > > arch/x86/include/asm/module.h | 11 ++ > > arch/x86/include/asm/sections.h | 4 + > > arch/x86/kernel/module.c | 181 +++++++++++++++++++++++++++++++- > > arch/x86/kernel/module.lds | 3 + > > 5 files changed, 198 insertions(+), 5 deletions(-) > > create mode 100644 arch/x86/kernel/module.lds > Thanks, > -- > ~Randy -- Thomas