From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Garnier Subject: Re: [PATCH v3 09/27] x86/acpi: Adapt assembly for PIE support Date: Tue, 29 May 2018 08:55:34 -0700 Message-ID: References: <20180523195421.180248-1-thgarnie@google.com> <20180523195421.180248-10-thgarnie@google.com> <20180524110306.GA20225@amd> <20180525091447.GC9666@amd> <20180529123114.GB21399@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Herbert Xu , "David S . Miller" , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Peter Zijlstra , Josh Poimboeuf , Greg KH , Philippe Ombredanne , Kate Stewart , Arnaldo Carvalho de Melo , Yonghong Song , Andrey Ryabinin , Kees Cook , Tom Lendacky , "Kirill A. Shutemov" , Andy Lutomirski , Dominik Brodowski , Borislav Petkov , Borislav Petkov , "Rafael J. Wysocki" , Len Brown , Juergen Gross Return-path: List-Post: List-Help: List-Unsubscribe: List-Subscribe: In-Reply-To: <20180529123114.GB21399@amd> List-Id: linux-crypto.vger.kernel.org On Tue, May 29, 2018 at 5:31 AM Pavel Machek wrote: > On Fri 2018-05-25 10:00:04, Thomas Garnier wrote: > > On Fri, May 25, 2018 at 2:14 AM Pavel Machek wrote: > > > > > On Thu 2018-05-24 09:35:42, Thomas Garnier wrote: > > > > On Thu, May 24, 2018 at 4:03 AM Pavel Machek wrote: > > > > > > > > > On Wed 2018-05-23 12:54:03, Thomas Garnier wrote: > > > > > > Change the assembly code to use only relative references of symbols > > for > > > > the > > > > > > kernel to be PIE compatible. > > > > > > > > > > > > Position Independent Executable (PIE) support will allow to > > extended the > > > > > > KASLR randomization range below the -2G memory limit. > > > > > > > > > What testing did this get? > > > > > > > > Tested boot, hibernation and performance on qemu and dedicated machine. > > > > > Well, this is suspend, not hibernation code. > > > > > So "sudo pm-suspend" or "echo mem > /sys/power/state" would be good > > > way to test this. > > > > Thanks, it worked. I added this to the testsuite I use for KASLR. > Thanks! > You can add my Acked-by:. Will do. Thanks for the review. > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Garnier Subject: Re: [PATCH v3 09/27] x86/acpi: Adapt assembly for PIE support Date: Tue, 29 May 2018 08:55:34 -0700 Message-ID: References: <20180523195421.180248-1-thgarnie@google.com> <20180523195421.180248-10-thgarnie@google.com> <20180524110306.GA20225@amd> <20180525091447.GC9666@amd> <20180529123114.GB21399@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: List-Post: List-Help: List-Unsubscribe: List-Subscribe: In-Reply-To: <20180529123114.GB21399@amd> To: Pavel Machek Cc: Herbert Xu , "David S . Miller" , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Peter Zijlstra , Josh Poimboeuf , Greg KH , Philippe Ombredanne , Kate Stewart , Arnaldo Carvalho de Melo , Yonghong Song , Andrey Ryabinin , Kees Cook , Tom Lendacky , "Kirill A. Shutemov" , Andy Lutomirski , Dominik Brodowski , Borislav Petkov , Borislav Petkov , "Rafael J. Wysocki" , Len Brown , Juergen Gross List-Id: linux-sparse@vger.kernel.org On Tue, May 29, 2018 at 5:31 AM Pavel Machek wrote: > On Fri 2018-05-25 10:00:04, Thomas Garnier wrote: > > On Fri, May 25, 2018 at 2:14 AM Pavel Machek wrote: > > > > > On Thu 2018-05-24 09:35:42, Thomas Garnier wrote: > > > > On Thu, May 24, 2018 at 4:03 AM Pavel Machek wrote: > > > > > > > > > On Wed 2018-05-23 12:54:03, Thomas Garnier wrote: > > > > > > Change the assembly code to use only relative references of symbols > > for > > > > the > > > > > > kernel to be PIE compatible. > > > > > > > > > > > > Position Independent Executable (PIE) support will allow to > > extended the > > > > > > KASLR randomization range below the -2G memory limit. > > > > > > > > > What testing did this get? > > > > > > > > Tested boot, hibernation and performance on qemu and dedicated machine. > > > > > Well, this is suspend, not hibernation code. > > > > > So "sudo pm-suspend" or "echo mem > /sys/power/state" would be good > > > way to test this. > > > > Thanks, it worked. I added this to the testsuite I use for KASLR. > Thanks! > You can add my Acked-by:. Will do. Thanks for the review. > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 MIME-Version: 1.0 References: <20180523195421.180248-1-thgarnie@google.com> <20180523195421.180248-10-thgarnie@google.com> <20180524110306.GA20225@amd> <20180525091447.GC9666@amd> <20180529123114.GB21399@amd> In-Reply-To: <20180529123114.GB21399@amd> From: Thomas Garnier Date: Tue, 29 May 2018 08:55:34 -0700 Message-ID: Subject: Re: [PATCH v3 09/27] x86/acpi: Adapt assembly for PIE support Content-Type: text/plain; charset="UTF-8" To: Pavel Machek Cc: Herbert Xu , "David S . Miller" , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Peter Zijlstra , Josh Poimboeuf , Greg KH , Philippe Ombredanne , Kate Stewart , Arnaldo Carvalho de Melo , Yonghong Song , Andrey Ryabinin , Kees Cook , Tom Lendacky , "Kirill A. Shutemov" , Andy Lutomirski , Dominik Brodowski , Borislav Petkov , Borislav Petkov , "Rafael J. Wysocki" , Len Brown , Juergen Gross , Alok Kataria , Steven Rostedt , Jan Kiszka , Tejun Heo , Christoph Lameter , Dennis Zhou , Boris Ostrovsky , Alexey Dobriyan , Masami Hiramatsu , Cao jin , Francis Deslauriers , "Paul E . McKenney" , Nicolas Pitre , Andrew Morton , Randy Dunlap , "Luis R . Rodriguez" , Arnd Bergmann , Christopher Li , Jason Baron , Mika Westerberg , Lukas Wunner , Dou Liyang , Sergey Senozhatsky , Petr Mladek , Masahiro Yamada , Ingo Molnar , Nicholas Piggin , "H . J . Lu" , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Joerg Roedel , David Woodhouse , Dave Hansen , Rik van Riel , Jia Zhang , Ricardo Neri , Jonathan Corbet , Jan Beulich , Matthias Kaehlcke , Baoquan He , =?UTF-8?B?SmFuIEggLiBTY2jDtm5oZXJy?= , Daniel Micay , the arch/x86 maintainers , Linux Crypto Mailing List , LKML , Linux PM list , virtualization@lists.linux-foundation.org, xen-devel , linux-arch , Sparse Mailing-list , kvm list , Linux Doc Mailing List , Kernel Hardening List-ID: On Tue, May 29, 2018 at 5:31 AM Pavel Machek wrote: > On Fri 2018-05-25 10:00:04, Thomas Garnier wrote: > > On Fri, May 25, 2018 at 2:14 AM Pavel Machek wrote: > > > > > On Thu 2018-05-24 09:35:42, Thomas Garnier wrote: > > > > On Thu, May 24, 2018 at 4:03 AM Pavel Machek wrote: > > > > > > > > > On Wed 2018-05-23 12:54:03, Thomas Garnier wrote: > > > > > > Change the assembly code to use only relative references of symbols > > for > > > > the > > > > > > kernel to be PIE compatible. > > > > > > > > > > > > Position Independent Executable (PIE) support will allow to > > extended the > > > > > > KASLR randomization range below the -2G memory limit. > > > > > > > > > What testing did this get? > > > > > > > > Tested boot, hibernation and performance on qemu and dedicated machine. > > > > > Well, this is suspend, not hibernation code. > > > > > So "sudo pm-suspend" or "echo mem > /sys/power/state" would be good > > > way to test this. > > > > Thanks, it worked. I added this to the testsuite I use for KASLR. > Thanks! > You can add my Acked-by:. Will do. Thanks for the review. > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- Thomas