From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Garnier via Virtualization Subject: Re: [PATCH v3 09/27] x86/acpi: Adapt assembly for PIE support Date: Tue, 29 May 2018 08:55:34 -0700 Message-ID: References: <20180523195421.180248-1-thgarnie@google.com> <20180523195421.180248-10-thgarnie@google.com> <20180524110306.GA20225@amd> <20180525091447.GC9666@amd> <20180529123114.GB21399@amd> Reply-To: Thomas Garnier Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180529123114.GB21399@amd> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Pavel Machek Cc: Kate Stewart , Nicolas Pitre , the arch/x86 maintainers , Sergey Senozhatsky , Petr Mladek , Len Brown , Peter Zijlstra , Yonghong Song , Christopher Li , Dave Hansen , Dominik Brodowski , LKML , Masahiro Yamada , Jan Beulich , "H . Peter Anvin" , Kernel Hardening , Christoph Lameter , Alok Kataria , Linux Doc Mailing List , linux-arch , Jonathan Corbet , Herbert Xu List-Id: virtualization@lists.linuxfoundation.org On Tue, May 29, 2018 at 5:31 AM Pavel Machek wrote: > On Fri 2018-05-25 10:00:04, Thomas Garnier wrote: > > On Fri, May 25, 2018 at 2:14 AM Pavel Machek wrote: > > > > > On Thu 2018-05-24 09:35:42, Thomas Garnier wrote: > > > > On Thu, May 24, 2018 at 4:03 AM Pavel Machek wrote: > > > > > > > > > On Wed 2018-05-23 12:54:03, Thomas Garnier wrote: > > > > > > Change the assembly code to use only relative references of symbols > > for > > > > the > > > > > > kernel to be PIE compatible. > > > > > > > > > > > > Position Independent Executable (PIE) support will allow to > > extended the > > > > > > KASLR randomization range below the -2G memory limit. > > > > > > > > > What testing did this get? > > > > > > > > Tested boot, hibernation and performance on qemu and dedicated machine. > > > > > Well, this is suspend, not hibernation code. > > > > > So "sudo pm-suspend" or "echo mem > /sys/power/state" would be good > > > way to test this. > > > > Thanks, it worked. I added this to the testsuite I use for KASLR. > Thanks! > You can add my Acked-by:. Will do. Thanks for the review. > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- Thomas