From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753415Ab3COBah (ORCPT ); Thu, 14 Mar 2013 21:30:37 -0400 Received: from mail-oa0-f41.google.com ([209.85.219.41]:58581 "EHLO mail-oa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626Ab3COBag (ORCPT ); Thu, 14 Mar 2013 21:30:36 -0400 MIME-Version: 1.0 In-Reply-To: <1363283435-7666-9-git-send-email-kirill.shutemov@linux.intel.com> References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-9-git-send-email-kirill.shutemov@linux.intel.com> Date: Fri, 15 Mar 2013 09:30:35 +0800 Message-ID: Subject: Re: [PATCHv2, RFC 08/30] thp, mm: rewrite add_to_page_cache_locked() to support huge pages From: Hillf Danton To: "Kirill A. Shutemov" Cc: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov wrote: > + page_cache_get(page); > + spin_lock_irq(&mapping->tree_lock); > + page->mapping = mapping; > + page->index = offset; > + error = radix_tree_insert(&mapping->page_tree, offset, page); > + if (unlikely(error)) > + goto err; > + if (PageTransHuge(page)) { > + int i; > + for (i = 1; i < HPAGE_CACHE_NR; i++) { struct page *tail = page + i; to easy reader > + page_cache_get(page + i); s/page_cache_get/get_page_foll/ ? > + page[i].index = offset + i; > + error = radix_tree_insert(&mapping->page_tree, > + offset + i, page + i); > + if (error) { > + page_cache_release(page + i); > + break; > + } > } > - radix_tree_preload_end(); > - } else > - mem_cgroup_uncharge_cache_page(page); > -out: > + if (error) { > + error = ENOSPC; /* no space for a huge page */ s/E/-E/ > + for (i--; i > 0; i--) { > + radix_tree_delete(&mapping->page_tree, > + offset + i); > + page_cache_release(page + i); > + } > + radix_tree_delete(&mapping->page_tree, offset); > + goto err; > + } > + } From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hillf Danton Subject: Re: [PATCHv2, RFC 08/30] thp, mm: rewrite add_to_page_cache_locked() to support huge pages Date: Fri, 15 Mar 2013 09:30:35 +0800 Message-ID: References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-9-git-send-email-kirill.shutemov@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: "Kirill A. Shutemov" Return-path: In-Reply-To: <1363283435-7666-9-git-send-email-kirill.shutemov@linux.intel.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov wrote: > + page_cache_get(page); > + spin_lock_irq(&mapping->tree_lock); > + page->mapping = mapping; > + page->index = offset; > + error = radix_tree_insert(&mapping->page_tree, offset, page); > + if (unlikely(error)) > + goto err; > + if (PageTransHuge(page)) { > + int i; > + for (i = 1; i < HPAGE_CACHE_NR; i++) { struct page *tail = page + i; to easy reader > + page_cache_get(page + i); s/page_cache_get/get_page_foll/ ? > + page[i].index = offset + i; > + error = radix_tree_insert(&mapping->page_tree, > + offset + i, page + i); > + if (error) { > + page_cache_release(page + i); > + break; > + } > } > - radix_tree_preload_end(); > - } else > - mem_cgroup_uncharge_cache_page(page); > -out: > + if (error) { > + error = ENOSPC; /* no space for a huge page */ s/E/-E/ > + for (i--; i > 0; i--) { > + radix_tree_delete(&mapping->page_tree, > + offset + i); > + page_cache_release(page + i); > + } > + radix_tree_delete(&mapping->page_tree, offset); > + goto err; > + } > + } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org