From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752480Ab2HMNYj (ORCPT ); Mon, 13 Aug 2012 09:24:39 -0400 Received: from mail-vb0-f46.google.com ([209.85.212.46]:62541 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751736Ab2HMNYh (ORCPT ); Mon, 13 Aug 2012 09:24:37 -0400 MIME-Version: 1.0 Date: Mon, 13 Aug 2012 21:24:36 +0800 Message-ID: Subject: Re: [PATCH] hugetlb: do not use vma_hugecache_offset for vma_prio_tree_foreach From: Hillf Danton To: Michal Hocko Cc: Mel Gorman , Andrew Morton , Linux-MM , LKML , KAMEZAWA Hiroyuki , David Rientjes Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 13, 2012 at 9:09 PM, Michal Hocko wrote: > On Mon 13-08-12 20:10:41, Hillf Danton wrote: >> On Sun, Aug 12, 2012 at 5:31 PM, Michal Hocko wrote: >> > From d07b88a70ee1dbcc96502c48cde878931e7deb38 Mon Sep 17 00:00:00 2001 >> > From: Michal Hocko >> > Date: Fri, 10 Aug 2012 15:03:07 +0200 >> > Subject: [PATCH] hugetlb: do not use vma_hugecache_offset for >> > vma_prio_tree_foreach >> > >> > 0c176d5 (mm: hugetlb: fix pgoff computation when unmapping page >> > from vma) fixed pgoff calculation but it has replaced it by >> > vma_hugecache_offset which is not approapriate for offsets used for >> > vma_prio_tree_foreach because that one expects index in page units >> > rather than in huge_page_shift. >> >> >> What if another case of vma_prio_tree_foreach in try_to_unmap_file >> is correct? > > That one is surely correct (linear_page_index converts the page offset). But linear_page_index is not used in this patch, why? > Anyway do you actually have any _real_ objection to the patch? I will sign ack only after I see your answers to my questions. Feel free to info me if you are unlikely to answer questions, Michal. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx115.postini.com [74.125.245.115]) by kanga.kvack.org (Postfix) with SMTP id 439DA6B002B for ; Mon, 13 Aug 2012 09:24:38 -0400 (EDT) Received: by vbkv13 with SMTP id v13so4281449vbk.14 for ; Mon, 13 Aug 2012 06:24:37 -0700 (PDT) MIME-Version: 1.0 Date: Mon, 13 Aug 2012 21:24:36 +0800 Message-ID: Subject: Re: [PATCH] hugetlb: do not use vma_hugecache_offset for vma_prio_tree_foreach From: Hillf Danton Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Mel Gorman , Andrew Morton , Linux-MM , LKML , KAMEZAWA Hiroyuki , David Rientjes On Mon, Aug 13, 2012 at 9:09 PM, Michal Hocko wrote: > On Mon 13-08-12 20:10:41, Hillf Danton wrote: >> On Sun, Aug 12, 2012 at 5:31 PM, Michal Hocko wrote: >> > From d07b88a70ee1dbcc96502c48cde878931e7deb38 Mon Sep 17 00:00:00 2001 >> > From: Michal Hocko >> > Date: Fri, 10 Aug 2012 15:03:07 +0200 >> > Subject: [PATCH] hugetlb: do not use vma_hugecache_offset for >> > vma_prio_tree_foreach >> > >> > 0c176d5 (mm: hugetlb: fix pgoff computation when unmapping page >> > from vma) fixed pgoff calculation but it has replaced it by >> > vma_hugecache_offset which is not approapriate for offsets used for >> > vma_prio_tree_foreach because that one expects index in page units >> > rather than in huge_page_shift. >> >> >> What if another case of vma_prio_tree_foreach in try_to_unmap_file >> is correct? > > That one is surely correct (linear_page_index converts the page offset). But linear_page_index is not used in this patch, why? > Anyway do you actually have any _real_ objection to the patch? I will sign ack only after I see your answers to my questions. Feel free to info me if you are unlikely to answer questions, Michal. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org